Merge ~wgrant/launchpad:buildd-manager-failure-metrics into launchpad:master
Proposed by
William Grant
Status: | Merged |
---|---|
Approved by: | William Grant |
Approved revision: | 812872093d67ad2597cd96713d2152e3410180c7 |
Merge reported by: | Otto Co-Pilot |
Merged at revision: | not available |
Proposed branch: | ~wgrant/launchpad:buildd-manager-failure-metrics |
Merge into: | launchpad:master |
Prerequisite: | ~wgrant/launchpad:buildd-manager-failure-refactor |
Diff against target: |
293 lines (+124/-37) 2 files modified
lib/lp/buildmaster/manager.py (+31/-24) lib/lp/buildmaster/tests/test_manager.py (+93/-13) |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Colin Watson (community) | Approve | ||
Review via email: mp+454693@code.launchpad.net |
Commit message
Tweak buildd-manager failure handling metrics
Description of the change
They all now start with "builders.failure", labels are more consistent,
and builder failure/reset are counted.
To post a comment you must log in.
I guess we don't currently have any graphs monitoring the existing metric names, so the slightly gratuitous (although neater) renaming is probably OK.