~wgrant/launchpad:buildd-manager-failure-metrics

Branch merges

Propose for merging

Merged into launchpad:master

Colin Watson (community): Approve on 2023-10-27

Diff: 293 lines (+124/-37)

2 files modified

lib/lp/buildmaster/manager.py (+31/-24)
lib/lp/buildmaster/tests/test_manager.py (+93/-13)

api

Related source package recipes

No recipes using this branch. (?)

Create packaging recipe

Related snap packages

Related charm recipes

8128720... by William Grant on 2023-10-27

Rename base failure count metric to not clash with numbercruncher

	docs:0 (build)
	lint:0 (build)
	mypy:0 (build)

1 → 3 of 3 results

First • Previous • Next • Last

0d9cfad... by William Grant on 2023-10-27

Tweak buildd-manager failure handling metrics

They all now start with "builders.failure", labels are more consistent,
and builder failure/reset are counted.

	docs:0 (build)
	lint:0 (build)
	mypy:0 (build)

1 → 3 of 3 results

First • Previous • Next • Last

a981c18... by William Grant on 2023-10-27

Refactor buildd-manager job dispatch error handling

Previously scan sometimes caught its own errors so it could _scanFailed
with retry=False. Instead use a flag that's reset at the start of every
scan, so singleCycle can always invoke _scanFailed the right way. This
means singleCycle can always know whether a scan succeeded or failed.

	docs:0 (build)
	lint:0 (build)
	mypy:0 (build)

1 → 3 of 3 results

First • Previous • Next • Last

d53bc13... by William Grant on 2023-10-27

Convert buildd-manager's singleCycle to inlineCallbacks

_scanFailed also needed porting from failures to exceptions.

c9f30b9... by Ines Almeida on 2023-10-23

Fix failing pro-enable unit test

Merged from https://code.launchpad.net/~ines-almeida/launchpad/+git/launchpad/+merge/454273

29afe26... by Colin Watson on 2023-10-23

Fix test failures caused by "Remove/rename unused loop variables"

Merged from https://code.launchpad.net/~cjwatson/launchpad/+git/launchpad/+merge/454266

3bee7b2... by Ines Almeida on 2023-10-23

Fix failing pro-enable unit test

a64e35b... by Colin Watson on 2023-10-23

charm: Bump launchpad-layers to 0fd04056ad

Merged from https://code.launchpad.net/~cjwatson/launchpad/+git/launchpad/+merge/454263

c5cfb73... by Colin Watson on 2023-10-23

Fix librarian GC merge_duplicates

I missed out a variable when removing use of `vars()` recently, causing
some extremely verbose test fallout.

a5afdfa... by Colin Watson on 2023-10-23

Fix test_findSharedGroupsPOTMsgSet

I made an off-by-one error while fixing what `flake8-bugbear` thought
was an unused loop variable.