Launchpad itself

Code review comment for lp:~wgrant/launchpad/better-publisher-index-tests

  1. better-publisher-index-tests
  2. Merge into devel
Revision history for this message
Brad Crittenden (bac) wrote :

Hi William,

Thanks for this branch.

As we discussed on IRC, in TestArchiveIndices you created two new methods that have default values of '[]'. Since you make the claim you never mutate them please change to be an empty tuple to enforce it.

Otherwise it looks fine.

review: Approve (code)

« Back to merge proposal