* Would it be better to use attrgetter instead of the lambda?: sorted(.., key=attrgetter('value.version'))
* Just a comment, but the call to term.value.version breaks the Law of Demeter (http://en.wikipedia.org/wiki/Law_of_Demeter). That often indicates an object design problem, but since we are working with data objects, I think it can pass here.
Hi William,
The fix looks good, but I had two concerns:
* Would it be better to use attrgetter instead of the lambda?: sorted(.., key=attrgetter( 'value. version' ))
* Just a comment, but the call to term.value.version breaks the Law of Demeter (http:// en.wikipedia. org/wiki/ Law_of_ Demeter). That often indicates an object design problem, but since we are working with data objects, I think it can pass here.
Looks good! r=mars
Maris