Launchpad itself

Code review comment for lp:~wgrant/launchpad/bug-612157-ppa-quota-ddebs

  1. bug-612157-ppa-quota-ddebs
  2. Merge into devel
Revision history for this message
Māris Fogels (mars) wrote :

Hi William,

This is a nice, simple change. One potential issue: you removed the requirement that DDEBS not be counted, and you removed the associated test - good. This means that DDEBS should now be included in the archive size, but I see no test asserting that this is true. A previously excluded number is now included in the sum total archive size - some test somewhere should have changed to reflect this.

But maybe not - if you feel that my worry is unfounded, then feel free to land this. The code looks good. r=mars

Maris

review: Approve (code)

« Back to merge proposal