Code review comment for lp:~wgrant/launchpad/export-das-chroot

Revision history for this message
Francis J. Lacoste (flacoste) wrote :

On February 22, 2010, Julian Edwards wrote:
> > On Mon, Feb 22, 2010 at 10:27:17AM -0000, Julian Edwards wrote:
> > > > Why not export getChroot() instead? It seems more useful to get the
> > > > actual librarian file, rather than just a URL.
> > >
> > > chroots are several hundred meg big - way too much to proxy through the
> >
> > webapp.
> >
> > Why does this matter if ILibraryFileAlias is exported, exposing meta
> > data, including http_url?
>
> Oh I see, expose the LFA. Yeah that would be ok, but I'd do it in addition
> to the other URL so that it's not yet another traversal to get the data
> you need. And LFA is not currently exported of course :)

We don't want to export LibraryFileAlias directly. These are mapped to
HostedFile in the web service implementation.

  reviewer leonardr

Leonard, could you give us some pointers on how this should be mapped to a
HostedFile.

Thanks

--
Francis J. Lacoste
<email address hidden>

« Back to merge proposal