Code review comment for lp:~wgrant/launchpad/gina-3.0-support

Revision history for this message
William Grant (wgrant) wrote :

gina needs to support 3.0 (quilt) and 3.0 (native) sources. To do this, it just needs to identify files as the correct types. Since archiveuploader already has a function to do this, I've altered gina to use that rather than the duplicated canonical.launchpad.helpers.getFileType. As gina was the final callsite of getFileType, I've removed that.

Since determine_source_file_type only does source files, I've added determine_binary_file_type. It could possibly go along with determine_source_file_type in lp.archiveuploader.utils, but I'm not quite sure.

For testing, I've added a 3.0 (quilt) source to the test archive.

« Back to merge proposal