Merge lp:~wgrant/launchpad/remove-dbnote into lp:launchpad
Proposed by
William Grant
Status: | Merged |
---|---|
Approved by: | Michael Hudson-Doyle |
Approved revision: | no longer in the source branch. |
Merged at revision: | not available |
Proposed branch: | lp:~wgrant/launchpad/remove-dbnote |
Merge into: | lp:launchpad |
Prerequisite: | lp:~wgrant/launchpad/amputate-buildergroup |
Diff against target: |
119 lines (+0/-92) 3 files modified
lib/canonical/buildd/utils.py (+0/-53) lib/lp/buildmaster/manager.py (+0/-4) lib/lp/soyuz/doc/buildd-dbnotes.txt (+0/-35) |
To merge this branch: | bzr merge lp:~wgrant/launchpad/remove-dbnote |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Michael Nelson (community) | code | Approve | |
Brad Crittenden (community) | Needs Information | ||
Review via email: mp+22736@code.launchpad.net |
Commit message
Remove unused DBNote and related paraphernalia.
Description of the change
This branch removes canonical.
To post a comment you must log in.
Thanks for the branch William. It makes sense to me but before I can approve it I need to verify that you discussed this with Julian or another Soyuz-er.
As an aside, you may want to install Aaron's plugin for 'bzr lpsend' (lp:lpreview-body) since it creates a template for merge proposals and includes the output of 'make lint' for you. Having the template to fill out makes it less likely that you'll forget to mention some of the required information.
Again, thanks for the work. Have a quick chat with Soyuz and then I'll be happy to land this.