Code review comment for lp:~wgrant/launchpad/remove-dbnote

Revision history for this message
Brad Crittenden (bac) wrote :

Thanks for the branch William. It makes sense to me but before I can approve it I need to verify that you discussed this with Julian or another Soyuz-er.

As an aside, you may want to install Aaron's plugin for 'bzr lpsend' (lp:lpreview-body) since it creates a template for merge proposals and includes the output of 'make lint' for you. Having the template to fill out makes it less likely that you'll forget to mention some of the required information.

Again, thanks for the work. Have a quick chat with Soyuz and then I'll be happy to land this.

review: Needs Information

« Back to merge proposal