Code review comment for lp:~wgrant/launchpad/rework-dominator-tests

Revision history for this message
Robert Collins (lifeless) wrote :

Nice.

raising AssertionError in production code sucks, but I realise you're just defining the contract. Please consider adding a 'this is a bad contract' comment there and in the place raising it - otherwise future programmers may believe that the current behaviour is your /intent/.

review: Approve

« Back to merge proposal