Code review comment for lp:~wgrant/launchpad/sync-source-v3-fix
Revision history for this message
| William Grant (wgrant) wrote | # |
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
0e1f616
(Get the code!)
Since Debian now has many v3 source packages, bug #474163 is going to crash the autosyncer and make archive admins very unhappy.
My suggested fix is to just float() the first space-separated part. I could have instead moved the format check inside the "if not is_a_dsc" block, but splitting seems like a sane enough approach for .changes files as well.
I've tested sync-source.py (the only user of this code) with all three formats, and it works fine.