Code review comment for lp:~wgrant/launchpad/team-verbose-bugnotifications-bug-253788

Revision history for this message
William Grant (wgrant) wrote :

This branch fixes bug #253788, by making bugmail to a team member use the member's verbose_bugnotifications, not the team's.

bugnotification-sending.txt relied on dict ordering in construct_email_notifications, and I needed to rekey that dict with Persons. As they don't hash reliably, the order changed between test runs, so I decided to sort the returned messages by emailaddress. The majority of the changes in bugnotification-sending.txt are reorderings based on this; only the hunks mentioning salgado are new tests.

« Back to merge proposal