Code review comment for lp:~wgrant/launchpad/team-verbose-bugnotifications-bug-253788

Revision history for this message
Barry Warsaw (barry) wrote :

On Jul 23, 2009, at 11:18 AM, Graham Binns wrote:

>>
>> + >>> switch_db_to_launchpad()
>> + >>> bug =
>> factory.makeBug(product=factory.makeProduct(title='Foo'),
>> + ... title='Foo is broken',
>> description='desc')
>
> We prefer to do wrapping of method calls thus:
>
>>>> bug = factory.makeBug(
> ... product=factory.makeProduct(title='Foo'), title='Foo is
> broken',
> ... description='desc')
>
> See http://dev.launchpad.net/PythonStyleGuide for details. The way
> you've done it is okay, but we've pretty much standardised on the
> style above, so we should stick with that (in fact I don't know why
> the
> other version is in the style guide any more; this one is the one that
> gets used).

TOOWTDI. I've updated the style guide.

-Barry

« Back to merge proposal