Merge lp:~woutervb/charms/trusty/logstash-forwarder/bionic-support into lp:~canonical-is-sa/charms/trusty/logstash-forwarder/trunk

Proposed by Wouter van Bommel
Status: Merged
Approved by: Haw Loeung
Approved revision: 25
Merged at revision: 25
Proposed branch: lp:~woutervb/charms/trusty/logstash-forwarder/bionic-support
Merge into: lp:~canonical-is-sa/charms/trusty/logstash-forwarder/trunk
Diff against target: 47 lines (+20/-0)
2 files modified
hooks/hooks.py (+19/-0)
metadata.yaml (+1/-0)
To merge this branch: bzr merge lp:~woutervb/charms/trusty/logstash-forwarder/bionic-support
Reviewer Review Type Date Requested Status
Haw Loeung +1 Approve
Review via email: mp+402683@code.launchpad.net
To post a comment you must log in.
Revision history for this message
Haw Loeung (hloeung) wrote :

LGTM

review: Approve (+1)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'hooks/hooks.py'
--- hooks/hooks.py 2019-08-22 13:09:17 +0000
+++ hooks/hooks.py 2021-05-13 02:21:01 +0000
@@ -47,12 +47,31 @@
47 apt_update()47 apt_update()
48 apt_install(conf.packageName(), options=['--force-yes'])48 apt_install(conf.packageName(), options=['--force-yes'])
4949
50def lsb_release():
51 """Return /etc/lsb-release in a dict"""
52 d = {}
53 with open('/etc/lsb-release', 'r') as lsb:
54 for l in lsb:
55 k, v = l.split('=')
56 d[k.strip()] = v.strip()
57 return d
58
59
60def get_distrib_codename():
61 """Return the codename of the distribution
62 :returns: The codename
63 :rtype: str
64 """
65 return lsb_release()['DISTRIB_CODENAME'].lower()
66
5067
51def replaceInitScript():68def replaceInitScript():
52 src = os.path.join(charm_dir(), "files", "init.sh")69 src = os.path.join(charm_dir(), "files", "init.sh")
53 dest = "/etc/init.d/logstash-forwarder"70 dest = "/etc/init.d/logstash-forwarder"
54 shutil.copyfile(src, dest)71 shutil.copyfile(src, dest)
55 os.chmod(dest, 0755)72 os.chmod(dest, 0755)
73 if get_distrib_codename() == 'bionic':
74 subprocess.call(['systemctl', 'daemon-reload'])
5675
5776
58def writeEtcDefault():77def writeEtcDefault():
5978
=== modified file 'metadata.yaml'
--- metadata.yaml 2017-03-06 12:49:07 +0000
+++ metadata.yaml 2021-05-13 02:21:01 +0000
@@ -10,6 +10,7 @@
10series:10series:
11 - trusty11 - trusty
12 - xenial12 - xenial
13 - bionic
13provides:14provides:
14 nrpe-external-master:15 nrpe-external-master:
15 interface: nrpe-external-master16 interface: nrpe-external-master

Subscribers

People subscribed via source and target branches