Code review comment for lp:~xnox/bzr/bug.569934

Revision history for this message
Vincent Ladeuil (vila) wrote :

Design-wise, the approach sounds fine, yet, I don't understand why you delete the 'revisions' and 'file-revisions' only to let the existing code re-create them (in much the same way that the base class does).

Two tests are failing with your patch, you can avoid running the whole test suite
by using:
 './bzr selftest -s bt.test_version'

Note that since this formatter is for python we may want to preserve revno being an int (so you may have to convert it from the rio string).

Finally, we need you sign the contributor agreement to accept your patch, see http://www.canonical.com/contributors, thanks for giving it a look.

review: Needs Fixing

« Back to merge proposal