desktopcouch

couchgrid selected_records property is buggy and should be removed for karmic if possible

Bug #448357 reported by Rick Spencer
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
desktopcouch
Fix Released
Undecided
Rick Spencer
desktopcouch (Ubuntu)
Fix Released
Undecided
Unassigned

Bug Description

The property is merely constructing a Record from the id, and not populating the record fully from the database:
            rec = self.database.get_record(rec_id)

This is completely wrong and stupid. There is an easy workaround, as the selected_record_ids property works as expected and those ids can be used to retrieve records from the database.

Note that records can be added to the grid with an id "", and not saved to the database, which can happen if rows are appended with auto_save = False.

Proposed solution is to remove this property until it can be properly thought out and coded.

Related branches

lp:~rick-rickspencer3/desktopcouch/remove_buggy_prop_from_couchgrid
Mark G. Saye (community): Approve
Stuart Langridge (community): Approve
Diff: 75 lines
2 files modified
desktopcouch/records/couchgrid.py (+1/-18)
desktopcouch/records/tests/test_couchgrid.py (+21/-0)
lp:ubuntu/karmic/desktopcouch
Rick Spencer (rick-rickspencer3)
Changed in desktopcouch:
assignee: nobody → Rick Spencer (rick-rickspencer3)
Revision history for this message
Rick Spencer (rick-rickspencer3) wrote :

This fix was a simple deletion, which is available in the attached branch

Changed in desktopcouch:
status: New → Fix Committed
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package desktopcouch - 0.4.4-0ubuntu1

---------------
desktopcouch (0.4.4-0ubuntu1) karmic; urgency=low

  * New upstream release.
    + Include doc "txt" and translation files in sources.
    + couchgrid does not correctly retrieve record id (LP: #447512)
    + couchgrid selected_records property is buggy and should be removed for
      karmic if possible (LP: #448357)

desktopcouch (0.4.3-0ubuntu1) karmic; urgency=low

  * Include compulsory-auth INI file to be secure by default.
    (LP: #438800)
  * Make debhelper warn about files not installed to some package.
  * Shorten debhelper install paths using dh_install exlusions.
  * New upstream release:
    + couchgrid did not correctly retrieve record id (LP: #447512)
    + HTTP 401 for valid auth information when talking to couchdb over SSL
      (LP: #446516)
    + Support headless apps. (LP: #428681)
    + desktopcouch-service "ValueError: dictionary update sequence..." on
      stdout(LP: #446511)

 -- Chad MILLER <email address hidden> Mon, 12 Oct 2009 10:17:50 -0400

Changed in desktopcouch (Ubuntu):
status: New → Fix Released
Chad Miller (cmiller)
Changed in desktopcouch:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.