Internet 8.2.1: The button uses an icon not 'unlock', and the field is labeled "Password"

Bug #518117 reported by AJenbo
10
This bug affects 1 person
Affects Status Importance Assigned to Milestone
ubuntu-docs (Ubuntu)
Fix Released
Undecided
Alex Wardle

Bug Description

Binary package hint: ubuntu-docs

Press the <guibutton>Unlock</guibutton> button and enter your password in the <guilabel>Password for (username): </guilabel> field.

When you open shares-admin (Shared Folders), the button doesn't say "Unlock", it just has the keychain icon.

When the regulare password prompt appears the password field is labled password, not "Password for (username): "

Alex Wardle (awardle)
summary: - Internet #205: The button uses an icon, and the field is labled
- "Password"
+ Internet 8.2.1: The button uses an icon not 'unlock', and the field is
+ labeled "Password"
Revision history for this message
Alex Wardle (awardle) wrote :

I have attached a patch that deals with the points in this bug.

Alex Wardle (awardle)
Changed in ubuntu-docs (Ubuntu):
status: New → In Progress
assignee: nobody → Alex Wardle (awardle)
Revision history for this message
AJenbo (ajenbo) wrote :

Thanks

Revision history for this message
Connor Imes (ckimes) wrote :

Hi Alex, thanks for your work. I've looked at your patch but it doesn't look quite right. Have you updated your bzr branch before making the diff? It is showing changes from your last patch for another bug. Also, it looks like you just removed the line about unlocking rather than explaining how to unlock.

You can revert your changes and update with
   bzr revert
   bzr update
then make your changes accordingly. I look forward to seeing another patch, cheers.

Revision history for this message
Alex Wardle (awardle) wrote :

I have attached a new patch that changes the 'Unlock' to a image of the button. This patch should only have the changes required for this bug.

Revision history for this message
Connor Imes (ckimes) wrote :

Alex, thanks for your patch - I like seeing the icon inline (we're just getting started with using graphics in the docs). You may have done this locally already, but you need to copy the "dialog-password.png" file to the libs/img/ directory in your local copy of the bzr branch. Before taking the diff, you need to run
   bzr add libs/img/dialog-password.png
in order for the fix-urls.sh script to run correctly during build and therefore include the image in the build.

I've done this on my computer already, but I'd like Mathew's feedback before committing.

Mathew, are we ready to start putting graphics in other sections of the docs? I don't see any reason why not, but I'd like your feedback first. Thanks.

tags: added: patch
Revision history for this message
AJenbo (ajenbo) wrote :

This also apples to this line

Internet line 1084
Press <guibutton>Unlock</guibutton> and type your password to unlock the settings

Revision history for this message
Matthew East (mdke) wrote :

Sorry for the delay - it looks good to me.

Revision history for this message
Connor Imes (ckimes) wrote :

Thanks for your patch, Alex. I have added the file and committed the fix to the Lucid dev branch, rev. 448.

AJenbo, I think you are looking at a different portion of the internet section, for a different application. If there is still a problem, please file a new bug - thanks!

Changed in ubuntu-docs (Ubuntu):
status: In Progress → Fix Committed
Revision history for this message
AJenbo (ajenbo) wrote :

I am looking in the po fil that i downloaded from rosetta, ill try and get you a link or file an line number

Revision history for this message
AJenbo (ajenbo) wrote :
Revision history for this message
Connor Imes (ckimes) wrote :

AJenbo, a different icon is used in gnome-network-admin than in shares-admin. Can you please file a new bug report for this? Thanks.

Revision history for this message
AJenbo (ajenbo) wrote :

Ok, ill do that :)

Revision history for this message
Launchpad Janitor (janitor) wrote :
Download full text (5.5 KiB)

This bug was fixed in the package ubuntu-docs - 10.04.2

---------------
ubuntu-docs (10.04.2) lucid; urgency=low

  * General:
    - Fixes to scripts/fix-url.sh (including LP: #482862)
    - Fix character encoding in contributors.xml (LP: #448618)
    - Updated version in browser-startpage html files, LP: #526320
    - Refresh pot files
  * Add-applications:
    - Updates for UI changes, Phil Bull
  * Config-desktop:
    - Added topic on changing window buttons from the left, Phil Bull
  * Hardware:
    - Added mention of gsynaptics, Connor Imes, LP: #450567
  * Internet:
    - Refresh list of plugins supplied by ubuntu-restricted-extras, branch
      from Nathan Murray, LP: #504981
    - Updates to reflect that Ekiga no longer installed by default, Connor Imes,
      LP: #508572
    - Grammar fix from Alex Wardle, LP: #517776
    - Order adjustment for shares-admin usage, Alex Wardle, LP: #518119
    - Button name change for shares-admin app, Alex Wardle, LP: #518170
    - Use unlock icon in networking section, Alex Wardle, LP: #518117
    - Updated directions on changing text size and page zooming in firefox,
      Alison Rowland, LP: #512556
    - Fixed guilabel usage in modem section. Alex Wardle, LP: #521243
    - Updated button and tab names in Static Connections section,
      Alex Wardle, LP: #521508
    - Typo fix in adsl section. Alex Wardle, LP: #525349
    - Removed unused and empty basics.xml, LP: #525431
    - Minor wording update to directions for sharing folders via nautilus,
      Connor Imes, LP: #518175
    - Use 'NetworkManager' not 'Network Manager' for consistency, Connor Imes
      LP: #518107
    - Update to troubleshooting mobile devices, Connor Imes, LP: #453459
    - Adjusted description of NetworkManager applet icons, Connor Imes
      LP: #440826
    - Additions to VPN section of connecting guide, Alex Wardle, LP: #452647
    - Expanded on using config files for vpn connections, Connor Imes
    - Command line substitution for Services utility which is not in Karmic or
      Lucid, Connor Imes, LP: #518460
    - Structural and language changes + updates for UI changes, Phil Bull
  * Musicvideophotos:
    - Added section for recording and editing video, Book 'em Dano, LP: #367569
  * Newtoubuntu:
    - Complete rewrite, Matthew East
  * Printing:
    - Simple Scan replaced xsane for scanning documents, Alex Wardle, LP: #546193
  * Serverguide:
    - Rename link to serverguide in advanced-topics.xml, Gilbert
      Mendoza, LP: #505708
    - Use distro-short-codename variable for vmbuilder documentation in
      serverguide rather than static version example, Connor Imes,. LP: #509653
    - Small fixes to security chapter, Connor Imes, LP: #510703
    - Small fixes from Nathan Handler, LP: #507624
    - Configuration change for OpenLDAP, Connor Imes, LP: #511090
    - Refresh of network-config section, Gilbert Mendoza, LP: #506800
    - Update manpage links to use distro-short-codename, Connor Imes
    - Changed OpenLDAP replication to use single Provider/Consumer configuration,
      Adam Sommer
    - Removed grub-password-security section - it does not apply to Grub2,
      Gilbert Mendoza, LP: #384148
    - Refere...

Read more...

Changed in ubuntu-docs (Ubuntu):
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.