incorrect dependencies for acpi-support

Bug #74683 reported by Rolf Leggewie
10
This bug affects 1 person
Affects Status Importance Assigned to Milestone
acpi-support (Ubuntu)
Fix Released
Low
Steve Langasek

Bug Description

acpi-support should not depend on laptop-specific packages. They should be recommended instead. Smartdimmer and Toshset do not apply to me (Thinkpad X24) and are mutually exclusive. Radeontool should be recommended only as well.

Matthew Garrett (mjg59)
Changed in acpi-support:
status: New → Fix Committed
Rolf Leggewie (r0lf)
Changed in acpi-support:
importance: Undecided → Low
Changed in acpi-support:
status: Fix Committed → Fix Released
Revision history for this message
Rolf Leggewie (r0lf) wrote :

reopening.

smartdimmer and radeontool are still depends. I'm not quite sure why that is the case for radeontool which is listed as recommends in debian/control.

There is another oddity that I just discovered. laptop-mode-tools is listed both in Suggests and Depends.

Changed in acpi-support (Ubuntu):
status: Fix Released → New
Revision history for this message
Steve Langasek (vorlon) wrote :

I don't know what you're looking at, but radeontool and smartdimmer are *not* depends. Closing the bug again.

Changed in acpi-support (Ubuntu):
status: New → Fix Released
Revision history for this message
Rolf Leggewie (r0lf) wrote : Re: [Bug 74683] Re: incorrect dependencies for acpi-support

Steve Langasek wrote:
> I don't know what you're looking at, but radeontool and smartdimmer are
> *not* depends. Closing the bug again.
>

Steve, I don't know what you're looking at, either. My sources are
aptitude, getting the sources and looking at the control files and
http://packages.ubuntu.com/karmic/acpi-support. Feel free to verify
there that radeontool and smartdimmer *are* listed as depends. Please
reopen after you've done the verification. Thank you.

Rolf Leggewie (r0lf)
Changed in acpi-support (Ubuntu):
status: Fix Released → New
Revision history for this message
Steve Langasek (vorlon) wrote :

On Sun, Jul 12, 2009 at 01:57:53AM -0000, Rolf Leggewie wrote:
> Steve Langasek wrote:
> > I don't know what you're looking at, but radeontool and smartdimmer are
> > *not* depends. Closing the bug again.

> Steve, I don't know what you're looking at, either. My sources are
> aptitude, getting the sources and looking at the control files and
> http://packages.ubuntu.com/karmic/acpi-support.

Ah, this gives the answer - it's only on i386 that these dependencies are
present, being assembled (who knows why) in debian/rules.

I'll clean these up and move them to arch-conditional package relationships
in debian/control so we don't lose track of them again.

--
Steve Langasek Give me a lever long enough and a Free OS
Debian Developer to set it on, and I can move the world.
Ubuntu Developer http://www.debian.org/
<email address hidden> <email address hidden>

Changed in acpi-support (Ubuntu):
assignee: nobody → Steve Langasek (vorlon)
status: New → Triaged
Steve Langasek (vorlon)
Changed in acpi-support (Ubuntu):
status: Triaged → Fix Committed
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package acpi-support - 0.125

---------------
acpi-support (0.125) karmic; urgency=low

  * debian/rules, debian/control: drop "arch:Depends" substvar in favor of
    using arch-dependent package relationships directly, and clean up
    various deps that were supposed to be demoted to Recommends long ago.
    LP: #74683.
  * Drop dependency on vbetool entirely, no longer needed now that we've
    handed suspend/resume quirks off to pm-utils.

 -- Steve Langasek <email address hidden> Mon, 13 Jul 2009 11:44:27 -0700

Changed in acpi-support (Ubuntu):
status: Fix Committed → Fix Released
Revision history for this message
Rolf Leggewie (r0lf) wrote :

Thank you for the fix. Judging by what I see in the bzr branch, I don't think the issue is fixed completely, yet. laptop-mode-tools is still listed both in depends and suggests as noted earlier.

Reopening.

Changed in acpi-support (Ubuntu):
status: Fix Released → Triaged
Steve Langasek (vorlon)
Changed in acpi-support (Ubuntu):
status: Triaged → Fix Committed
Revision history for this message
Rolf Leggewie (r0lf) wrote :

Thank you for fixing this issue.

Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package acpi-support - 0.128

---------------
acpi-support (0.128) karmic; urgency=low

  [ Steve Langasek ]
  * Get laptop-mode-tools out of Suggests. Finally-really-fixes LP: #74683.
  * Fix the touchpad handler to use xinput instead of (unreliable)
    synclient, and add a corresponding Recommends; and call getXconsole so
    we can actually talk to the X server. LP: #447211.
  * new events/asus-f8sv-touchpad: handle another touchpad ACPI event on
    another ASUS model. LP: #218598.
  * lib/power-funcs: adjust getXconsole to work when the tty number is not
    present on the X commandline.

  [ Felix Geyer ]
  * lib/policy-funcs: Recognize KDE4 PowerDevil as a power manager.
    LP: #387750.

 -- Steve Langasek <email address hidden> Mon, 12 Oct 2009 16:49:00 -0700

Changed in acpi-support (Ubuntu):
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Duplicates of this bug

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.