View Bazaar branches
Get this repository:
git clone https://git.launchpad.net/rt

See all merge proposals.

Import details

Import Status: Reviewed

This repository is an import of the Git repository at https://github.com/bestpractical/rt.git.

The next import is scheduled to run .

Last successful import was .

Import started on juju-98ee42-prod-launchpad-codeimport-1 and finished taking 1 minute — see the log
Import started on juju-98ee42-prod-launchpad-codeimport-0 and finished taking 1 minute — see the log
Import started on juju-98ee42-prod-launchpad-codeimport-5 and finished taking 1 minute — see the log
Import started on juju-98ee42-prod-launchpad-codeimport-4 and finished taking 1 minute — see the log
Import started on juju-98ee42-prod-launchpad-codeimport-1 and finished taking 1 minute — see the log
Import started on juju-98ee42-prod-launchpad-codeimport-1 and finished taking 3 minutes — see the log
Import started on juju-98ee42-prod-launchpad-codeimport-1 and finished taking 50 seconds — see the log
Import started on juju-98ee42-prod-launchpad-codeimport-0 and finished taking 1 minute — see the log
Import started on juju-98ee42-prod-launchpad-codeimport-0 and finished taking 1 minute — see the log
Import started on juju-98ee42-prod-launchpad-codeimport-5 and finished taking 1 minute — see the log

Branches

Name Last Modified Last Commit
6.0/htmx 2024-05-15 19:48:14 UTC
Document packages needed for selenium tests

Author: sunnavy
Author Date: 2024-05-15 19:48:14 UTC

Document packages needed for selenium tests

5.0/confirm-before-leaving-create-or-update-page 2024-05-13 16:34:19 UTC
Confirm before leaving create or update page

Author: Ronaldo Richieri
Author Date: 2024-05-13 16:34:19 UTC

Confirm before leaving create or update page

Sometimes users accidentally navigate away from a create or update ticket
page without posting their changes.

This commit adds a confirmation dialog before leaving a create or update
ticket page if the user has made changes to the form.

5.0-trunk 2024-05-13 13:37:08 UTC
Merge branch '5.0/save-reports-order-in-update-this-menu' into 5.0-trunk

Author: sunnavy
Author Date: 2024-05-13 13:37:08 UTC

Merge branch '5.0/save-reports-order-in-update-this-menu' into 5.0-trunk

stable 2024-05-13 13:37:08 UTC
Merge branch '5.0/save-reports-order-in-update-this-menu' into 5.0-trunk

Author: sunnavy
Author Date: 2024-05-13 13:37:08 UTC

Merge branch '5.0/save-reports-order-in-update-this-menu' into 5.0-trunk

5.0/scrip-log-queue-changes-before-commit 2024-05-10 18:40:31 UTC
Add helper text to guide admins to not modify RT data in condition/prepare code

Author: sunnavy
Author Date: 2024-05-10 18:07:58 UTC

Add helper text to guide admins to not modify RT data in condition/prepare code

5.0/always-pass-import-arg-ldap-import 2024-05-09 15:30:14 UTC
Always pass import flag within LDAP import

Author: Jason Crome
Author Date: 2024-05-09 15:30:14 UTC

Always pass import flag within LDAP import

When constructing a user object in the LDAP import, the import flag was
not passed through as it is elsewhere in the import process. If this
flag is needed in the LDAP field mapping, there was no guaranteed
availability.

Explicitly passing the import argument to _build_user_object ensures
that LDAP mappings will always be aware of whether this is a live or
test import.

5.0/dont-overflow-center-aligned-form-rows-when-small 2024-05-08 12:55:28 UTC
Fix overflow in center-aligned form elements

Author: Ronaldo Richieri
Author Date: 2024-05-08 12:55:28 UTC

Fix overflow in center-aligned form elements

Some admin pages had an issue where form rows overflowed the right side
of the container on smaller windows. This was due to some classes that
fixed the width of container elements.

This commit replaces this approach by picking classes that define
max-width instead of width.

5.0/remove-warning-when-creating-dashboard 2024-05-08 12:34:35 UTC
Fix privacy warning during dashboard creation

Author: Ronaldo Richieri
Author Date: 2024-05-08 12:34:35 UTC

Fix privacy warning during dashboard creation

The dashboard creation page previously displayed a warning about the
privacy setting due to prematurely checking if the user could delete
the dashboard. This check occurred before the privacy setting was
defined, as it was not yet saved.

This commit moves this check to a more appropriate place, where the
privacy setting is already defined.

master 2024-05-07 15:43:29 UTC
Merge branch '5.0-trunk'

Author: sunnavy
Author Date: 2024-05-06 22:18:47 UTC

Merge branch '5.0-trunk'

5.0/doc-customize-sla-how-to-send-overdue-notification 2024-05-07 14:22:10 UTC
Add links to overdue automation examples on SLA POD

Author: Ronaldo Richieri
Author Date: 2024-05-07 14:22:10 UTC

Add links to overdue automation examples on SLA POD

5.0/check-rt-address-thoroughly 2024-05-06 19:37:59 UTC
Fix IsRTAddress in CanonicalizePrincipal in case User param is an object

Author: sunnavy
Author Date: 2024-05-06 19:12:02 UTC

Fix IsRTAddress in CanonicalizePrincipal in case User param is an object

5.0/update-github-actions-dependencies 2024-05-06 14:39:42 UTC
Remove simple-slack-notify GitHub action

Author: Ronaldo Richieri
Author Date: 2024-05-06 14:39:42 UTC

Remove simple-slack-notify GitHub action

This action was used to send notifications to Slack when a build/test
finished. It was deprecated and there is no new version compatible with
node 20, which is required by the new GitHub Actions.

We have the alternative of using the GitHub App from Slack, which also
provides notifications for workflows, so we can remove this action.

5.0/add-oracle-test-github-action 2024-05-06 13:28:09 UTC
Update Oracle test workflow to run only manually

Author: Ronaldo Richieri
Author Date: 2024-05-06 13:28:09 UTC

Update Oracle test workflow to run only manually

5.0/center-queue-watchers-info 2024-05-03 13:18:29 UTC
Improve new queue watchers search results layout

Author: Ronaldo Richieri
Author Date: 2024-05-03 13:18:29 UTC

Improve new queue watchers search results layout

Center vertically the search results in the Queue Watchers tab for both
users and groups. This enhancement ensures the display aligns better
visually, improving user experience.

Additionally, expand the width of the search results to match the search
form, creating a more consistent and aesthetically pleasing interface.

5.0/test-bullseye-image 2024-04-30 20:53:03 UTC
Test bullseye docker image

Author: Jim Brandt
Author Date: 2024-04-30 20:53:03 UTC

Test bullseye docker image

5.0/one-time-cc-value-format 2024-04-30 20:47:54 UTC
Keep all default values for email inputs

Author: sunnavy
Author Date: 2024-04-30 20:47:54 UTC

Keep all default values for email inputs

Previously default values only allowed emails of RT users, which is an
unnecessary limitation.

This commit fixes the issue that non-RT-user emails in UpdateCc/UpdateBcc
are lost after form submission that is triggered by "include an article" on
ticket update page.

5.0/reset-bulk-values 2024-04-30 18:43:28 UTC
Add button to Reset Bulk Update values

Author: Ronaldo Richieri
Author Date: 2024-04-30 17:14:19 UTC

Add button to Reset Bulk Update values

The form on the bulk update page was keeping its values after updates,
in case you need to run it multiple times. However, the form is large,
and if you are doing several different bulk updates, it was possible to
accidentally apply a previous change to a new bulk update.

This commit adds a "Reset" button to the bulk update page that will clear
all the values in the form, allowing the user to start fresh.

5.0/user-transaction-portlet-recent-correspondence 2024-04-22 19:05:12 UTC
Add Recent Correspondence portlet to User Summary

Author: Jason Crome
Author Date: 2024-04-12 20:15:26 UTC

Add Recent Correspondence portlet to User Summary

This also provides a TransactionList component that can be reused.

6.0/htmx-logall 2024-04-22 12:43:07 UTC
Add option to log all htmx requests to browser console

Author: Ronaldo Richieri
Author Date: 2024-04-22 12:43:07 UTC

Add option to log all htmx requests to browser console

Add a new option to RT_Config.pm, $HtmxLogAll, which when set to a true
value will cause all htmx requests to be logged to the browser console.

5.0/add-missing-overlays 2024-04-19 20:37:12 UTC
Test overlays of RT packages

Author: sunnavy
Author Date: 2024-04-19 19:29:01 UTC

Test overlays of RT packages

5.0/create-rt-crontool-admin-interface 2024-04-19 20:20:50 UTC
Update Automating RT docs

Author: Brad Embree
Author Date: 2024-04-18 02:09:47 UTC

Update Automating RT docs

5.0/crypt-skip-deferred-recipient-check 2024-04-17 17:32:38 UTC
Test smime encryption behavior for deferred recipients without valid keys

Author: sunnavy
Author Date: 2024-04-17 17:32:38 UTC

Test smime encryption behavior for deferred recipients without valid keys

5.0/create-chart-images-for-dashboard-emails-2 2024-04-12 20:13:27 UTC
Test UTF-8 BOM to make sure all static files do not have it

Author: sunnavy
Author Date: 2023-12-19 19:09:00 UTC

Test UTF-8 BOM to make sure all static files do not have it

5.0/tweak-ticket-search-acl-owner 2024-04-12 17:36:44 UTC
Test ticket searches where Owner has ShowTicket granted

Author: sunnavy
Author Date: 2024-04-12 17:34:29 UTC

Test ticket searches where Owner has ShowTicket granted

5.0/show-list-of-open-timers 2024-04-12 15:02:47 UTC
Show list of open timers in RT menu

Author: Jason Crome
Author Date: 2024-03-28 14:59:47 UTC

Show list of open timers in RT menu

5.0/cgm-cascade-delete 2024-04-03 13:26:16 UTC
Test cascaded deletion of cached group members

Author: sunnavy
Author Date: 2023-12-07 20:48:17 UTC

Test cascaded deletion of cached group members

5.0/add-forward-transaction-action 2024-03-17 23:25:56 UTC
Add RT::Action::ForwardTransaction

Author: Brad Embree
Author Date: 2024-03-17 23:25:56 UTC

Add RT::Action::ForwardTransaction

Add an action to be used from rt-crontool for forwarding transactions to
a specified email, optionally with some comment for the forward
transaction.

5.0/search-user-cf-in-sql 2024-02-26 18:44:37 UTC
Add user cfs to query builder criteria

Author: sunnavy
Author Date: 2022-05-20 18:37:26 UTC

Add user cfs to query builder criteria

6.0/button-cursor-pointer-on-hover 2024-02-23 19:00:33 UTC
Restore the pointer cursor behavior for buttons

Author: sunnavy
Author Date: 2024-02-23 18:50:55 UTC

Restore the pointer cursor behavior for buttons

Since the bootstrap 5 upgrade, this obsolete rule for ".button:hover"
overrode the correct one(cursor: pointer) defined in bootstrap. Bootstrap 4
doesn't have this issue as the correct rule has a higher precedence there.

5.0/db-type-mariadb 2024-02-16 20:01:35 UTC
Test with new docker image

Author: Jim Brandt
Author Date: 2024-02-16 20:01:35 UTC

Test with new docker image

5.0/template-split-headers-and-body 2024-02-09 19:17:57 UTC
Avoid the newline after <textarea> tag to make WWW::Mechanize happy

Author: sunnavy
Author Date: 2024-02-09 19:16:40 UTC

Avoid the newline after <textarea> tag to make WWW::Mechanize happy

Like the removed $TODO says: WWW::Mechanize doesn't strip newline following
<textarea> tag like browsers do.

5.0/oracle-escape-fts-terms 2024-02-08 21:30:21 UTC
Automatically escape fulltext search terms for Oracle

Author: sunnavy
Author Date: 2024-02-08 21:03:04 UTC

Automatically escape fulltext search terms for Oracle

This is usually what user really means. Without it, searching reserved words
like "about" would break the search.

5.0/support-multipe-checkbox-cfs 2024-02-06 14:38:08 UTC
Dynamically get target element from the display element for checkbox cfs

Author: sunnavy
Author Date: 2024-02-06 14:28:59 UTC

Dynamically get target element from the display element for checkbox cfs

The "id" var is a global variable that's shared the whole page, for pages
that have multiple checkbox cfs, previously changing any display element
would always change the value of the last hidden checkbox input, which the
final id value points to.

5.0/split-fulltext-searches 2024-02-02 13:17:50 UTC
Bump database version requirements for the full support of INTERSECT/UNION SQL

Author: sunnavy
Author Date: 2024-02-02 13:15:34 UTC

Bump database version requirements for the full support of INTERSECT/UNION SQL

MySQL 5.7 and MariaDB 10.3 have reached EOF anyway.

5.0/skip-additional-initialdata-serialization 2024-01-21 15:39:32 UTC
Skip additional attributes when serializing JSON

Author: Jason Crome
Author Date: 2024-01-21 15:39:32 UTC

Skip additional attributes when serializing JSON

Even when the --no-users option is provided to rt-dump-initialdata, RT
can still serialize users required to maintain internal consistency of
data. These additional options to rt-dump-initialdata can help to
minimize the amount of data produced for these users:

    --no-dashboards
    --no-subscriptions
    --no-bookmarks

5.0/validator-remove-invalid-subscriptions 2024-01-19 21:03:29 UTC
Remove subscriptions for deleted dashboards w/rt-validator

Author: Jason Crome
Author Date: 2024-01-19 21:03:29 UTC

Remove subscriptions for deleted dashboards w/rt-validator

Serializing initialdata to JSON will fail when trying to serialize a
dashboard subscription for a dashboard that no longer exists (i.e.,
deleted). The dashboard ID ends up as a scalar reference that JSON can't
encode. This allows rt-validator to find and remove these subscriptions
when they're present.

6.0/upgrade-ckeditor5 2024-01-12 18:26:28 UTC
Test extracting inline/internal images from HTML content

Author: sunnavy
Author Date: 2024-01-09 21:48:33 UTC

Test extracting inline/internal images from HTML content

5.0/add-checkboxes-multiple-selection 2023-12-21 21:19:07 UTC
Allow multiple selection of checkboxes holding shift key

Author: Ronaldo Richieri
Author Date: 2023-07-14 15:30:24 UTC

Allow multiple selection of checkboxes holding shift key

Improve usability of the checkboxes in ticket bulk update form, as
well as in many administration pages, by allowing to select range of
checkboxes by holding shift key.

5.0/add-create-tickets-template-gui 2023-12-20 23:43:34 UTC
Update tests

Author: Brad Embree
Author Date: 2023-12-18 02:11:22 UTC

Update tests

5.0/pod-unread-messages 2023-12-18 19:46:56 UTC
Add POD for Unread Messages feature

Author: Ronaldo Richieri
Author Date: 2023-12-18 19:46:56 UTC

Add POD for Unread Messages feature

Present the Unread Messages Notification and describe how to enable it
at user and admin levels.

Also describe how to use the Unread Messages column in the ticket
search results.

Finally describe how to search tickets that have unread messages.

5.0/rt-importer-split-batch-for-large-query 2023-12-16 23:24:30 UTC
Ensure batches stay under 1GB for Postgres

Author: Brad Embree
Author Date: 2023-12-16 23:21:42 UTC

Ensure batches stay under 1GB for Postgres

Postgres has a hard coded query size limit of 1GB. If a batch is large
enough it can exceed the limit.

Added code to check the size of values in a batch and split the batch to
ensure it stays under the size limit.

5.0/cf-input-required-attr 2023-11-16 15:41:35 UTC
Add "required" attribute for mandatory custom field inputs

Author: sunnavy
Author Date: 2023-11-03 17:27:24 UTC

Add "required" attribute for mandatory custom field inputs

The attribute isn't enabled for "List" style of multi-value select
custom fields: "required" means each "required" checkbox must be
checked, but we want to allow to check just some of them.

For mandatory select inputs, previously in a67e05ea49 we chose to keep
"(no value)" as the initial state to force user to manually select one
valid option. This commit implements the logic in js, and there is no
need to keep the invalid "(no value)" option any more.

5.0/pg-fts-websearch 2023-10-31 15:51:30 UTC
Add search tips for MySQL and MariaDB

Author: Jim Brandt
Author Date: 2023-10-31 15:51:30 UTC

Add search tips for MySQL and MariaDB

maint 2023-10-19 19:21:12 UTC
Merge branch '4.4.7-releng' into 4.4-trunk

Author: sunnavy
Author Date: 2023-10-19 19:21:12 UTC

Merge branch '4.4.7-releng' into 4.4-trunk

4.4-trunk 2023-10-19 19:21:12 UTC
Merge branch '4.4.7-releng' into 4.4-trunk

Author: sunnavy
Author Date: 2023-10-19 19:21:12 UTC

Merge branch '4.4.7-releng' into 4.4-trunk

5.0/cf-autocomplete-users 2023-10-13 22:09:02 UTC
Support to autocomplete users/groups for Autocomplete custom fields

Author: sunnavy
Author Date: 2023-10-13 21:39:22 UTC

Support to autocomplete users/groups for Autocomplete custom fields

5.0/lifecycle-viewer 2023-10-11 19:16:53 UTC
Support to show lifecycle UI on ticket/asset display pages

Author: sunnavy
Author Date: 2022-07-12 20:02:50 UTC

Support to show lifecycle UI on ticket/asset display pages

5.0/cf-numeric-values 2023-10-11 14:04:22 UTC
Test searching/sorting cf values numerically

Author: sunnavy
Author Date: 2022-02-14 19:57:43 UTC

Test searching/sorting cf values numerically

5.0/add-full-scrip-copy-feature 2023-09-20 20:55:54 UTC
Add ability to copy a scrip to create new

Author: Ronaldo Richieri
Author Date: 2023-09-20 20:55:54 UTC

Add ability to copy a scrip to create new

Previously, to copy the parameters from an existing scrip to a new one,
you have to manually recreate each field.

This commit adds a "Copy" link to the Modify page for a scrip. By
clicking the link, RT will clone the scrip and disable the new version.
It will also copy the applied objects and stages.

This also updates the Stage method of Scrip, allowing it
to receive queue_id named argument to get the Stage of
the scrip informing the queue directly and not only
the ticket.

5.0/update-smime-test-revoked-certs 2023-09-06 14:31:05 UTC
Make SMIME revocation check with OSCP work with OpenSSL 3

Author: sunnavy
Author Date: 2023-09-06 13:45:24 UTC

Make SMIME revocation check with OSCP work with OpenSSL 3

At least with OpenSSL 3.1.2, oscp's -cert argument doesn't support
STDIN("-") :/

5.0/remove-cf-dropdown-render-type 2023-09-05 15:50:23 UTC
Drop size attribute for cf selects

Author: sunnavy
Author Date: 2023-09-05 15:50:21 UTC

Drop size attribute for cf selects

It has no effects since we use selectpicker for all select cfs.

5.0/edit-plugins-config-ui 2023-09-04 08:17:32 UTC
make plugin's configs editabe in UI

Author: ruz
Author Date: 2023-09-04 08:17:32 UTC

make plugin's configs editabe in UI

4.4/automating-rt-multiple-actions 2023-08-25 18:57:25 UTC
Document using multiple actions with rt-crontool

Author: Craig Kaiser
Author Date: 2017-12-13 13:36:10 UTC

Document using multiple actions with rt-crontool

4.4/shred-external-storage 2023-07-25 19:59:59 UTC
Test shredding external contents

Author: sunnavy
Author Date: 2023-07-25 19:33:54 UTC

Test shredding external contents

5.0/document-self-service-interface 2023-07-13 18:24:38 UTC
Rename Self-Service Interface Documentation

Author: Ronaldo Richieri
Author Date: 2023-07-13 18:24:38 UTC

Rename Self-Service Interface Documentation

5.0/fix-select-status-active-inactive 2023-07-06 19:19:12 UTC
Fix SelectStatus element to pre select active/inactive status

Author: Ronaldo Richieri
Author Date: 2023-03-30 18:21:37 UTC

Fix SelectStatus element to pre select active/inactive status

Element did not pre select active/inactive status when submitting a
form with __Active__ or __Inactive__ value selected.

4.4/add-clean-sessions-all-option 2023-06-30 20:58:10 UTC
Add clean-all option

Author: Brad Embree
Author Date: 2022-01-27 23:43:44 UTC

Add clean-all option

5.0/top-bottom-posting 2023-06-03 16:44:27 UTC
Add MessageBoxTopPostinng option

Author: ruz
Author Date: 2023-06-03 16:44:27 UTC

Add MessageBoxTopPostinng option

5.0/validator-ace-principal-check 2023-05-28 12:39:24 UTC
Add ACL.PrincipalId -> Principals.id check rt-validator

Author: ruz
Author Date: 2023-05-28 12:38:36 UTC

Add ACL.PrincipalId -> Principals.id check rt-validator

5.0/shred-attachments-fts-index 2023-05-28 10:42:50 UTC
Wipeout full text index records during shredding

Author: ruz
Author Date: 2023-05-24 05:39:52 UTC

Wipeout full text index records during shredding

* Shredder::RawRecord allows us to delete a record in a table without
  RT::Record mapping, for example AttachmentsIndex
* wipeout AttachmentsIndex if it's enabled
* write a test that works with mysql and Pg
* Remove some old outdated wording in shredder's docs

6.0/turbo 2023-05-05 20:59:45 UTC
Update login tests for new results parameter

Author: Jim Brandt
Author Date: 2023-05-05 20:59:45 UTC

Update login tests for new results parameter

With the redirect, there is now a results param at
the end of the URL after a failed login. Update tests to
expect that.

5.0/improve-adding-action-links-to-search-results 2023-04-25 00:51:38 UTC
Improve adding of action links to search results

Author: Jason Crome
Author Date: 2023-04-25 00:51:38 UTC

Improve adding of action links to search results

This is streamlining existing functionality; previously, you'd need to
select a column, a link, and maybe a column title to add an action link
to search results. The user would end up with either a column title they
picked or the name of the field, and the clickable action would be the
value of that field. The user could then make changes to the format to
replace the header with a space (therefore removing the header) and
replacing the field value with the name of the action to take.

This commit assumes that users prefer the latter as the default
functionality, and treats the action link as other columns. Users can
then edit the format if they want to revert to the original format (or
something different, of course).

5.0/fix-delimiter-during-upgrade-in-recipient-list 2023-03-31 19:13:28 UTC
Fix delimiter during upgrade in recipient list

Author: Blaine Motsinger
Author Date: 2022-08-23 23:30:08 UTC

Fix delimiter during upgrade in recipient list

In older RT, the dashboard recipient list supported being delimited
by semicolon or space. The 4.4.1 upgrade content step migrates the
list, but on newer RTs, fails to split the list correctly.

This commit updates the 4.4.1 upgrade content step to correct the
semicolon and space delimited list to then be correctly split and
migrated.

5.0/improve-text-indexes2 2023-03-28 14:47:27 UTC
Update tests to correct lower cased system group names

Author: sunnavy
Author Date: 2023-03-27 23:59:32 UTC

Update tests to correct lower cased system group names

System groups names are case sensitive now.

5.0/login-logout-adjustments 2023-03-02 13:12:34 UTC
Move ModifyLoginRedirect Callback to the end of Logout processing

Author: Ronaldo Richieri
Author Date: 2023-03-02 13:12:34 UTC

Move ModifyLoginRedirect Callback to the end of Logout processing

The URL generated by the ModifyLoginRedirect callback could be
overwritten by the LogoutURL config if Web External Auth was enabled.
This change moves the callback to the end of the Logout processing so
that the callback can override the final URL to redirect the user.

5.0/cf-sort-order-inputs 2022-12-27 22:03:23 UTC
Support SortOrder edit on ocf admin pages

Author: sunnavy
Author Date: 2018-01-25 22:45:37 UTC

Support SortOrder edit on ocf admin pages

Since we don't support move up/down for global cfs on queue-specific
pages, global cfs' SortOrder inputs are disabled there accordingly.

5.0/improve-menu-active-check 2022-12-23 19:42:49 UTC
Test active search page menus

Author: sunnavy
Author Date: 2021-11-05 18:07:53 UTC

Test active search page menus

5.0/upgrade-web-path-in-saved-search-format 2022-12-13 21:11:35 UTC
Add upgrade-web-path to update outdated URLs in saved searches

Author: sunnavy
Author Date: 2022-12-05 20:26:09 UTC

Add upgrade-web-path to update outdated URLs in saved searches

5.0/update-labeled-value-layout 2022-11-07 13:28:51 UTC
Add back the unintentionally deleted closing div of col-6

Author: sunnavy
Author Date: 2022-11-07 13:28:12 UTC

Add back the unintentionally deleted closing div of col-6

It was removed during LabeledValue refactor by accident.

5.0/jschart-avoid-duplicated-criteria 2022-10-24 20:53:19 UTC
Avoid adding duplicated criteria to queries generated in JSChart

Author: sunnavy
Author Date: 2022-10-24 20:32:34 UTC

Avoid adding duplicated criteria to queries generated in JSChart

For a bar chart grouped by status, each bar represents one status, and
clicking it redirects to search result page that shows tickets with that
status only. This is achieved by adding the extra status criterion to
the original query, e.g. TicketSQL is changed from:

    Queue = 'General'

to

    ( Queue = 'General' ) AND ( (Status = 'new') )

If you go to Chart page and click again, previously we unconditionally
added the extra status criterion, so the TicketSQL would be

    ( Queue = 'General' ) AND ( (Status = 'new') ) AND ( (Status = 'new') )

which is unnecessary. This commit checks the queries beforehand to avoid
the duplication.

5.0/contributed-accessibility-improvements 2022-10-12 14:47:43 UTC
Add aria-label to selectize remove buttons

Author: Brian Conry
Author Date: 2022-09-28 13:56:54 UTC

Add aria-label to selectize remove buttons

This change adds the aria-label attribute to the buttons created by the
remove_button plugin for Selectize.js.

5.0/improve-asset-webconfig 2022-10-12 13:33:54 UTC
Warn on invalid result formats in Asset System Configuration

Author: Brian Conry
Author Date: 2022-02-09 14:39:45 UTC

Warn on invalid result formats in Asset System Configuration

The options AssetDefaultSearchResultFormat, AssetSimpleSearchFormat,
AssetSummaryFormat, AssetSummaryRelatedTicketsFormat, and
UserAssetExtraInfo are intended to contain search result format
specifications for their respective objects for display in specific
places.

This change modifies the System Configuration web UI pages to add
warnings to the update results when portions of a changed format don't
appear to map to any field or attribute of the related object type.
This doesn't necessarily mean that there is an error, but it is unusual
enough to be worth bringing to the user's attention.

It is possible to inadvertently introduce small, subtle, errors into
these strings that prevent them from showing any useful information.
While this can also happen in configuration files,

This is not applied to values set in configuration files.

5.0/core-history-filter2 2022-10-07 22:17:11 UTC
Add Ticket Transaction History Filtering

Author: Brian Conry
Author Date: 2022-02-07 22:54:34 UTC

Add Ticket Transaction History Filtering

This adds the ability to filter transactions in a ticket's history based
on the transaction type. The set of filterable options is configurable
and defaults to 'Create', 'Correspond', and 'Comment'. Queues can be
configured to be filtered by default.

The filtering is controlled by a new widget in the ticket transaction
history header that allows the filter to be turned on/off and for
individual (configured) transaction types to be toggled.

5.0/create-chart-images-for-dashboard-emails 2022-10-06 18:01:35 UTC
Email JSChart images with WWW::Mechanize::Chrome

Author: Brian Conry
Author Date: 2022-10-06 18:01:35 UTC

Email JSChart images with WWW::Mechanize::Chrome

This change allows the dashboard emails to contain image versions of
JSChart graphs obtained using WWW::Mechanize::Chrome.

Previously it was only possible to generate graph images for emails
using the GD module.

This Feature has been tested with Chrome, Chromium, Microsoft Edge, and
Opera.

5.0/add-documented-api-for-scrip-stage-data-sharing 2022-10-04 00:34:36 UTC
Add RT::Scrip::DataCache

Author: Brian Conry
Author Date: 2022-10-04 00:28:31 UTC

Add RT::Scrip::DataCache

This change adds the DataCache accessor method to RT::Scrip objects for
use in safely passing information from one phase of scrip processing to
others, e.g. from Condtion code to a template.

Each Scrip object is created with a new empty hashref for its DataCache.
This is a transient cache and no data is preserved when the object is
destroyed. This cache is not used for any other purpose so that there
is no concern about conflict with current or future RT Scrip attributes
or methods.

5.0/improve-text-indexes 2022-10-01 00:29:51 UTC
Update SQL tests for automatic LOWER conversion

Author: sunnavy
Author Date: 2022-09-30 16:27:26 UTC

Update SQL tests for automatic LOWER conversion

5.0/remove-ldapimport-numeric-username-limit 2022-09-28 18:50:49 UTC
Update ldapimport test for numeric username

Author: Blaine Motsinger
Author Date: 2022-09-28 18:50:49 UTC

Update ldapimport test for numeric username

5.0/lighten-border-colors 2022-09-19 17:05:40 UTC
Lighten border colors for history and header

Author: Blaine Motsinger
Author Date: 2022-09-19 17:05:40 UTC

Lighten border colors for history and header

5.0/lighten-actions-buttons 2022-09-19 15:33:05 UTC
Lighten action buttons in ticket history

Author: Blaine Motsinger
Author Date: 2022-09-19 15:33:05 UTC

Lighten action buttons in ticket history

5.0/remove-attachment-and-filename-icons 2022-09-18 23:05:06 UTC
Remove attachment/filename icons from transactions

Author: Blaine Motsinger
Author Date: 2022-09-18 23:05:06 UTC

Remove attachment/filename icons from transactions

This commit removes the filename and attachment icons from ticket
history transactions, as well as cleanup the styling to fix the
alignment overlap in light and dark theme.

5.0/add-checking-to-verify-attr-match-list-maps 2022-09-14 22:00:45 UTC
Add checking to verify attr_match_list maps

Author: Blaine Motsinger
Author Date: 2022-09-14 22:00:45 UTC

Add checking to verify attr_match_list maps

To allow updating user attributes in RT with concatenated
attributes from LDAP, the ExternalSettings attr_map configuration
supports defining multiple LDAP attributes as an arrayref.
RealName in this example:

 'attr_map' => {
     'Name' => 'uid',
     'EmailAddress' => 'mail',
     'RealName' => [ 'givenName', 'sn' ],
 },

However, if an entry in attr_match_list maps to an arrayref in
attr_map, Net::LDAP::Filter will not build the search filter,
and will not return a filter object, resulting in a failed
response from the LDAP search.

 'attr_match_list' => [ 'Name', 'EmailAddress', 'RealName' ],

This commit adds checking to verify entries defined in
attr_match_list don't map to an arrayref in attr_map. If found,
the LDAP search using that attr_match_list attribute is skipped
and the error logged.

5.0/non-blocking-sessions 2022-08-31 19:41:54 UTC
Make the RT session non-blocking in a request

Author: Jim Brandt
Author Date: 2022-08-19 20:56:21 UTC

Make the RT session non-blocking in a request

Isolate the tied session interaction with Apache::Session
from the full RT web request processing to avoid blocking
requests on the session. This allows multiple requests
to access the session at once. This should only be done
where most requests are reads. If multiple requests
write to the session, this will cause unpredictable
results.

5.0/extract-label-value-rows 2022-08-24 19:37:51 UTC
Port most of Elements to LabeledValue

Author: Jesse Vincent
Author Date: 2022-08-09 01:24:21 UTC

Port most of Elements to LabeledValue

4.4/ckeditor-4.19.1 2022-08-18 02:24:22 UTC
Upgrade CKEditor to 4.19.1 for RT 4

Author: sunnavy
Author Date: 2022-08-17 20:49:58 UTC

Upgrade CKEditor to 4.19.1 for RT 4

5.0/sort-saved-searches 2022-08-10 14:45:45 UTC
Sort SavedSearches

Author: Brian Conry
Author Date: 2022-08-10 13:42:05 UTC

Sort SavedSearches

SavedSearches were previously returned in an unpredictable order
paralleling the order that the database returned the underlying
Attributes, probably based more on the order in which they were created
than on anything else.

This change automatically sorts the SavedSearches by Name (stored in the
Attribute's Description) after they are fetched in LimitToPrivacy.

5.0/update-postgresql-testing-version-to-14 2022-08-09 22:42:52 UTC
Update postgresql testing version to 14.4

Author: Blaine Motsinger
Author Date: 2022-08-09 22:42:52 UTC

Update postgresql testing version to 14.4

5.0/search-format-creator 2022-08-03 20:21:32 UTC
Switch from CreatedBy to Creator in search formats

Author: sunnavy
Author Date: 2022-08-03 20:01:14 UTC

Switch from CreatedBy to Creator in search formats

This is for consistency as "Creator" is also used in search criteria and
sorting. For existing searches with "CreatedBy" in format, it will
continue working.

5.0/cf-numeric-comparison 2022-08-02 22:47:31 UTC
Test searching/sorting cf values numerically

Author: sunnavy
Author Date: 2022-02-14 19:57:43 UTC

Test searching/sorting cf values numerically

5.0/optimize-ticket-display 2022-07-29 16:01:33 UTC
Skip processing when displaying ticket with no update args

Author: Jim Brandt
Author Date: 2022-07-29 14:23:07 UTC

Skip processing when displaying ticket with no update args

If a request to Ticket/Display.html doesn't have update args to process,
skip running all processing code for these display-only requests.

With no update args, this processing makes no updates and is effectively
a no-op on most RTs. However, on some systems these processing steps can
slow down page display.

5.0/menu-search-autocomplete 2022-07-26 15:54:48 UTC
Test article menu searches

Author: sunnavy
Author Date: 2022-07-26 15:44:53 UTC

Test article menu searches

5.0/cli-skip-db-config 2022-07-25 20:42:19 UTC
Add an option to run CLI utilities without DB configuration

Author: Jim Brandt
Author Date: 2022-07-25 20:42:19 UTC

Add an option to run CLI utilities without DB configuration

The Configurations table was added in RT 5, so running RT 5
scripts against an older database, possibly during an upgrade,
results in errors. Provide a way to skip loading DB config
when running some CLI scripts.

5.0/enable-smime-tests 2022-07-22 19:22:02 UTC
Document environment variables for Crypt tests

Author: Jim Brandt
Author Date: 2021-12-17 21:18:07 UTC

Document environment variables for Crypt tests

5.0/add-more-shredder-links 2022-07-21 22:55:58 UTC
Add shredder links to Asset and Transaction search

Author: Brian Conry
Author Date: 2022-07-21 18:50:36 UTC

Add shredder links to Asset and Transaction search

This change provides users with the SuperUser right with a link under
the Feeds menu to got to the Shredder page directly from the Asset and
Transaction search results pages.

4.4/security-tests-2021 2022-07-15 03:48:11 UTC
Add security tests for vulnerabilities released between 2014 and 2021

Author: sunnavy
Author Date: 2022-07-14 21:09:52 UTC

Add security tests for vulnerabilities released between 2014 and 2021

This includes tests for:

    CVE-2014-9472: mailgate dos
    CVE-2021-38562: side channel attack

5.0/adjust-ticket-create-subject-spacing 2022-07-05 15:45:43 UTC
Tweak spacing on ticket create/update with gnupg_widget

Author: Brian Conry
Author Date: 2022-07-05 14:24:06 UTC

Tweak spacing on ticket create/update with gnupg_widget

On the Ticket Create page the Subject is the last item in the "Create a
new ticket in ..." group before the option to include an article (if
present), but when $gnupg_widget is set there is a pair of checkboxes
displayed after the Subject.

The additional spacing after the Subject inputs, due to the "form-group"
class on the containing <div>, makes the checkboxes look like they're
closely related to the "Include Article" input when it is present, but
they are not.

A similar issue existed on the Ticket Update page, but in this case the
UI was inconsistent in that the encryption checkboxes were located above
the Subject textbox. They have been moved to be below the Subject in
addition to fixing the spacing inconsistency.

This change detects when $gnupg_widget is set and adjusts the location
of the "form-group" class appropriately to make the spacing align better
with the logical grouping of the controls.

5.0/make-sysconfig-timezone-selectbox 2022-06-24 13:42:10 UTC
Make the Timezone config option a Select widget

Author: Brian Conry
Author Date: 2022-06-23 14:59:17 UTC

Make the Timezone config option a Select widget

This change converts the Timezone option to a Select widget, from a text
box, on the System Configuration page. This restricts the admin to
choosing from known-valid options.

This is the same list that is built and presented in the User
Preferences.

Note that while this list does not usually include deprecated timezone
names, the current value of the configuration option and the file-only
value of the option (if different from the current value) are both
added at the top of the list, even when they are deprecated.

5.0/validator-delete-dangling-attributes 2022-06-03 18:59:03 UTC
Support to delete dangling attributes

Author: sunnavy
Author Date: 2022-06-03 18:41:46 UTC

Support to delete dangling attributes

In eb06b9aba1, we chose to bypass dangling "ContentHistory" attributes
and related transactions. Old versions still report these records and
allow user to delete transactions(but not attributes). If user uses an
old version and chooses to delete these transactions, which rt-validator
requires to find out dangling-but-allowed attributes, it will continue
reporting these attributes(even with eb06b9aba1):

    Record #31 in Attributes references a nonexistent record in Attributes
      ObjectId => '30' => id

This commit allows user to delete these attributes to clean things up.

5.0/fix-user-sig-spacing-issues 2022-06-01 17:38:39 UTC
Allow CKEDITOR (rich text) boxes to vary in height

Author: Brian Conry
Author Date: 2022-05-25 13:51:59 UTC

Allow CKEDITOR (rich text) boxes to vary in height

Set the height of CKEDITOR based on context.

For ones with the "messagebox" class continue to use
MessageBoxRichTextHeight.

For others use the "rows" attribute of the original textarea to
calculate a height that is approximately equivalent in editable area.

5.0/add-shredder-afterwipeout-callback 2022-04-29 21:02:27 UTC
Add an AfterWipeout callback to Shredder

Author: Brad Embree
Author Date: 2022-04-29 21:02:27 UTC

Add an AfterWipeout callback to Shredder

Used by RT::Site::Symas for returning back to the Ticket display page after clicking a link to shred an attachment.

See ticket 246765.

5.0/refactor-dashboard-subscriptions 2022-04-12 12:49:46 UTC
Define subscription rows in component init

Author: Jason Crome
Author Date: 2022-04-06 18:36:45 UTC

Define subscription rows in component init

The row options were originally hard-coded. By moving this to init, then
iterating over the list of values will allow extensions to modify the
settings in the MassageSubscriptionFields callback, where it wasn't
possible before.

1100 of 263 results

Other repositories

Name Last Modified
lp:rt 2024-05-16
11 of 1 result
You can't create new repositories for RT: Request Tracker.