Code review comment for lp:~adeuring/launchpad/bug-513382

Revision history for this message
Abel Deuring (adeuring) wrote :

Hi Michael,

Perhaps I am a bit thick, but I don't see how the problem mentioned there and implementing all CSS rules affects the confusing search behaviour.

And agreed, not being able to efficiently search for two words is not a big problem -- but it is a problem. (And a funny side effect is that browser searches for a word in the title of the UI bug 513380 I'm fixing will become useless by the fix of the bug -- IOW, we are knowingly introducing another UI bug...)

I short: I understand that using CSS sprites is quite successful to reduce page load times, probably also to reduce the server load and whatever else -- but using sprites by all means for all images where is it technically possible is wrong. If we have an image that is the "main or only carrier of information", we should keep the <img> tag, together with alt and title attributes. Trying anything else is likely to have some kind of weird or annoying side effect.

But anyway, I'll keep the sprite implementation for the heat icons for now...

« Back to merge proposal