Launchpad itself

Merge lp:~bac/launchpad/bug-436978-pg-index into lp:launchpad

  1. bug-436978-pg-index
  2. Merge into devel
Proposed by Brad Crittenden
Status: Merged
Approved by: Edwin Grubbs
Approved revision: no longer in the source branch.
Merged at revision: not available
Proposed branch: lp:~bac/launchpad/bug-436978-pg-index
Merge into: lp:launchpad
Diff against target: 73 lines
2 files modified
lib/lp/registry/stories/project/xx-project-index.txt (+1/-10)
lib/lp/registry/templates/project-index.pt (+4/-23)
To merge this branch: bzr merge lp:~bac/launchpad/bug-436978-pg-index
Reviewer Review Type Date Requested Status
Edwin Grubbs (community) code Approve
Martin Albisetti (community) ui Approve
Review via email: mp+13368@code.launchpad.net

Commit message

Remove project series and milestone information from project group index page.

To post a comment you must log in.
Revision history for this message
Brad Crittenden (bac) wrote :

= Summary =

Bug 436978 reports that project group index pages time out.

== Proposed fix ==

The main reason for the time out is collecting information about milestones for
projects that have a lot of them.

Upon review of that page we determined that including series and milestone
information about all projects in a project group does not make sense. That
information is too detailed for that level view.

== Pre-implementation notes ==

Call with Curtis.

== Implementation details ==

Simply remove the series and milestone data from the page template. The list was
then converted from a <dl> to a <ul>.

The menus at the bottom of that section were placed horizontally which caused ugly
wrapping. They have been changed to be vertical and look much better.

== Tests ==

bin/test -vvt xx-project-index.txt

== Demo and Q/A ==

http://launchpad.dev/mozilla
https://edge.launchpad.net/gnome

= Launchpad lint =

Checking for conflicts. and issues in doctests and templates.
Running jslint, xmllint, pyflakes, and pylint.
Using normal rules.

Linting changed files:
  lib/lp/registry/stories/project/xx-project-index.txt
  lib/lp/registry/templates/project-index.pt

Revision history for this message
Brad Crittenden (bac) wrote :

Screenshots:

http://people.canonical.com/~bac/project-group-index-old.png
http://people.canonical.com/~bac/project-group-index-new.png

Revision history for this message
Martin Albisetti (beuno) wrote :

Add some vertical spacing between the list of projects and "(+) Register a proj..." and ui=me!

review: Approve (ui)
Revision history for this message
Brad Crittenden (bac) wrote :

> Add some vertical spacing between the list of projects and "(+) Register a
> proj..." and ui=me!

Added 0.5em and it looks better. Thanks for the review.

Revision history for this message
Edwin Grubbs (edwin-grubbs) wrote :

Looks good.

merge-approved

-Edwin

review: Approve (code)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'lib/lp/registry/stories/project/xx-project-index.txt'
--- lib/lp/registry/stories/project/xx-project-index.txt 2009-09-18 15:24:30 +0000
+++ lib/lp/registry/stories/project/xx-project-index.txt 2009-10-14 18:50:26 +0000
@@ -30,25 +30,16 @@
30 Projects30 Projects
31 Gnome Applets ...31 Gnome Applets ...
32 Evolution ...32 Evolution ...
33 trunk series: 2.1.6,
34 GNOME Terminal ...33 GNOME Terminal ...
35 gnomebaker ...34 gnomebaker ...
36 trunk series: 2.1.7, 2.1.7
37 NetApplet ...35 NetApplet ...
38 trunk series: 1.0,
39 ...36 ...
4037
41And the projects, milestone, and releases are linked.38The projects are linked.
4239
43 >>> print anon_browser.getLink('gnomebaker').url40 >>> print anon_browser.getLink('gnomebaker').url
44 http://launchpad.dev/gnomebaker41 http://launchpad.dev/gnomebaker
4542
46 >>> print anon_browser.getLink('1.0').url
47 http://launchpad.dev/netapplet/trunk/1.0
48
49 >>> print anon_browser.getLink('2.1.7').url
50 http://launchpad.dev/gnomebaker/trunk/2.1.7
51
52The project overview page contains a link to register new products with the43The project overview page contains a link to register new products with the
53project. It is only available to users which have 'Admin' privileges on the44project. It is only available to users which have 'Admin' privileges on the
54project.45project.
5546
=== modified file 'lib/lp/registry/templates/project-index.pt'
--- lib/lp/registry/templates/project-index.pt 2009-09-22 17:39:22 +0000
+++ lib/lp/registry/templates/project-index.pt 2009-10-14 18:50:26 +0000
@@ -101,29 +101,11 @@
101 There are no projects registered for101 There are no projects registered for
102 <span tal:replace="context/displayname">project displayname</span>.102 <span tal:replace="context/displayname">project displayname</span>.
103 </p>103 </p>
104 <dl tal:condition="context/products"104 <ul tal:condition="context/products"
105 tal:repeat="product context/products">105 tal:repeat="product context/products">
106 <dt><a tal:replace="structure product/fmt:link">product</a></dt>106 <li><a tal:replace="structure product/fmt:link">product</a></li>
107 <dd tal:define="dev_focus product/development_focus">107 </ul>
108 <a tal:attributes="href dev_focus/fmt:url"108 <ul style="margin-top: 0.5em;">
109 tal:content="dev_focus/name">trunk</a>
110 series:
111 <tal:releases repeat="release dev_focus/releases">
112 <strong>
113 <a tal:attributes="href release/fmt:url"
114 tal:content="release/version">release
115 </a></strong>,
116 </tal:releases>
117 <tal:releases repeat="milestone dev_focus/milestones">
118 <strong>
119 <a tal:attributes="href milestone/fmt:url"
120 tal:content="milestone/name">milestone
121 </a></strong><tal:comma
122 condition="not:repeat/milestone/end">,</tal:comma>
123 </tal:releases>
124 </dd>
125 </dl>
126 <ul class="horizontal">
127 <li tal:condition="context/menu:overview/new_product/enabled">109 <li tal:condition="context/menu:overview/new_product/enabled">
128 <a tal:replace="structure context/menu:overview/new_product/fmt:link" />110 <a tal:replace="structure context/menu:overview/new_product/fmt:link" />
129 </li>111 </li>
@@ -158,4 +140,3 @@
158140
159 </body>141 </body>
160</html>142</html>
161