Code review comment for lp:~bac/launchpad/lp3-announcements

= Summary =

Update the <project>/+announcements page for 3.0 goodness, which is bug 414836.

Also solves:

Bug #175936: Announcements action (edit, publish & delete) links too close
 Remedy: links removed

Bug #253920: Project +announcements page should have a "Make announcement" link on it
 Remedy: add link in portlet

Bug #297518: "Created" doesn't make sense for announcements
 Remedy: reworded to 'written by'

== Proposed fix ==

Redesign the page to make individual announcements stand-out more. Removed editing
links which were problematic.

== Pre-implementation notes ==

Lots of helpful discussions with Curtis.

== Implementation details ==

As above.

== Tests ==

bin/test --vvm lp.registry -t announcement

== Demo and Q/A ==

Go to the following and ensure all looks right:
https://launchpad.dev/mozilla/+announcements
https://launchpad.dev/firefox/+announcements
https://launchpad.dev/kubuntu/+announcements

= Launchpad lint =

Checking for conflicts. and issues in doctests and templates.
Running jslint, xmllint, pyflakes, and pylint.
Using normal rules.

Linting changed files:
  lib/lp/registry/browser/configure.zcml
  lib/lp/registry/templates/hasannouncements-index.pt
  lib/lp/registry/stories/announcements/xx-announcements.txt
  lib/lp/registry/browser/announcement.py
  lib/lp/registry/templates/announcement-edit.pt
  lib/canonical/launchpad/icing/style-3-0.css
  lib/lp/registry/templates/announcement-listing-detailed.pt

== XmlLint notices ==

lib/lp/registry/templates/announcement-listing-detailed.pt
    1: namespace error : Namespace prefix tal for attributes on div is not defined
    <div class="portlet" tal:attributes="id string:${context/id}">
    ^
    3: namespace error : Namespace prefix tal for attributes on a is not defined
    <a tal:attributes="href string:${context/fmt:url}">
    ^
    5: namespace error : Namespace prefix tal for condition on date is not defined
    <tal:date tal:condition="context/date_announced">
    ^
    5: namespace error : Namespace prefix tal on date is not defined
    <tal:date tal:condition="context/date_announced">
    ^
    6: namespace error : Namespace prefix tal for replace on span is not defined
    <span tal:replace="context/date_announced/fmt:date"/>:
    ^
    8: namespace error : Namespace prefix tal on title is not defined
    <tal:title content="context/title">News item title</tal:title>
    ^
    14: namespace error : Namespace prefix tal on pillar is not defined
    <tal:pillar replace="structure context/target/fmt:link" />
    ^
    16: namespace error : Namespace prefix tal on registrant is not defined
    <tal:registrant replace="structure context/registrant/fmt:link" />.
    ^
    20: namespace error : Namespace prefix tal for replace on summary is not defined
    tal:replace="structure context/summary/fmt:text-to-html" />
    ^
    20: namespace error : Namespace prefix tal on summary is not defined
    tal:replace="structure context/summary/fmt:text-to-html" />
    ^
    22: namespace error : Namespace prefix tal on future is not defined
    <tal:future condition="context/future">
    ^
    24: namespace error : Namespace prefix tal for condition on strong is not defined
    <strong tal:condition="context/active">
    ^
    25: namespace error : Namespace prefix tal on date_set is not defined
    <tal:date_set condition="context/date_announced">
    ^
    27: namespace error : Namespace prefix tal for replace on span is not defined
    <span tal:replace="context/date_announced/fmt:datetime" />.
    ^
    31: namespace error : Namespace prefix tal for condition on strong is not defined
    <strong tal:condition="not: context/active">
    ^
    35: namespace error : Namespace prefix tal for condition on strong is not defined
    <strong tal:condition="not: context/date_announced">
    ^
    38: namespace error : Namespace prefix tal for condition on strong is not defined
    <strong tal:condition="context/date_last_modified">
    ^
    40: namespace error : Namespace prefix tal for replace on span is not defined
    <span tal:replace="context/date_last_modified/fmt:displaydate" />.
    ^
    43: namespace error : Namespace prefix tal for condition on a is not defined
    tal:attributes="href context/url">
    ^
    43: namespace error : Namespace prefix tal for attributes on a is not defined
    tal:attributes="href context/url">
    ^
I'm not sure what to make of these lint issues.