Code review comment for lp:~barry/launchpad/434072-spec-index

Revision history for this message
Barry Warsaw (barry) wrote :

 reviewer abentley

= Summary =

Very simple conversion of specifications-index.pt
(i.e. http://blueprints.launchpad.* +index page) to UI 3.0.

== Proposed fix ==

Convert the template, update the test, move the label from the template to the
view.

== Pre-implementation notes ==

None. I can do these in my sleep.

== Implementation details ==

Nothing special. This will be an RC.

== Tests ==

bin/test -vv -t stories/blueprints

== Demo and Q/A ==

http://blueprints.launchpad.dev

= Launchpad lint =

Checking for conflicts. and issues in doctests and templates.
Running jslint, xmllint, pyflakes, and pylint.
Using normal rules.

Linting changed files:
  lib/lp/blueprints/stories/blueprints/xx-index.txt
  lib/lp/blueprints/browser/specification.py
  lib/lp/blueprints/templates/specifications-index.pt

== Pyflakes notices ==

lib/lp/blueprints/browser/specification.py
    56: 'smartquote' imported but unused

Craptastic. I'll fix this before landing.

== Pylint notices ==

lib/lp/blueprints/browser/specification.py
    56: [W0611] Unused import smartquote

« Back to merge proposal