Code review comment for lp:~barry/launchpad/434072-spec-index

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

 review approve

Looks straightforward.

Barry Warsaw wrote:
> Barry Warsaw has proposed merging lp:~barry/launchpad/434072-spec-index into lp:launchpad/devel.
>
> Requested reviews:
> Aaron Bentley (abentley)
>
> reviewer abentley
>
> = Summary =
>
> Very simple conversion of specifications-index.pt
> (i.e. http://blueprints.launchpad.* +index page) to UI 3.0.
>
>
> == Proposed fix ==
>
> Convert the template, update the test, move the label from the template to the
> view.
>
>
> == Pre-implementation notes ==
>
> None. I can do these in my sleep.
>
>
> == Implementation details ==
>
> Nothing special. This will be an RC.
>
>
> == Tests ==
>
> bin/test -vv -t stories/blueprints
>
>
> == Demo and Q/A ==
>
> http://blueprints.launchpad.dev
>
>
> = Launchpad lint =
>
> Checking for conflicts. and issues in doctests and templates.
> Running jslint, xmllint, pyflakes, and pylint.
> Using normal rules.
>
> Linting changed files:
> lib/lp/blueprints/stories/blueprints/xx-index.txt
> lib/lp/blueprints/browser/specification.py
> lib/lp/blueprints/templates/specifications-index.pt
>
>
> == Pyflakes notices ==
>
> lib/lp/blueprints/browser/specification.py
> 56: 'smartquote' imported but unused
>
> Craptastic. I'll fix this before landing.
>
>
> == Pylint notices ==
>
> lib/lp/blueprints/browser/specification.py
> 56: [W0611] Unused import smartquote
>
>
>

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iEYEARECAAYFAkq3uz4ACgkQ0F+nu1YWqI3oRQCePFSp5gqgarTjnDsSEa0BUEXL
gDUAnj1r9aun84pnGDbN38TGs+UtYmwC
=+og7
-----END PGP SIGNATURE-----