Merge lp:~edwin-grubbs/launchpad/bug-490593-configure-involvement-portlet into lp:launchpad
- bug-490593-configure-involvement-portlet
- Merge into devel
Proposed by
Edwin Grubbs
| Status: | Merged |
|---|---|
| Approved by: | Curtis Hovey |
| Approved revision: | no longer in the source branch. |
| Merged at revision: | not available |
| Proposed branch: | lp:~edwin-grubbs/launchpad/bug-490593-configure-involvement-portlet |
| Merge into: | lp:launchpad |
| Diff against target: |
1459 lines (+524/-182) 34 files modified
Makefile (+3/-0) lib/canonical/launchpad/icing/style-3-0.css.in (+26/-5) lib/canonical/launchpad/pagetests/standalone/xx-form-layout.txt (+2/-1) lib/lp/blueprints/browser/specificationtarget.py (+1/-1) lib/lp/bugs/stories/bug-also-affects/xx-upstream-bugtracker-links.txt (+4/-2) lib/lp/bugs/stories/bugs/xx-front-page-info.txt (+1/-1) lib/lp/bugs/stories/bugtracker/bugtrackers-index.txt (+2/-1) lib/lp/bugs/stories/bugtracker/xx-bugtracker.txt (+2/-1) lib/lp/bugs/stories/guided-filebug/xx-bug-reporting-guidelines.txt (+11/-11) lib/lp/bugs/stories/guided-filebug/xx-no-launchpadder.txt (+2/-1) lib/lp/bugs/stories/guided-filebug/xx-project-guided-filebug.txt (+1/-1) lib/lp/bugs/stories/initial-bug-contacts/10-set-upstream-bugcontact.txt (+2/-2) lib/lp/bugs/templates/bugtarget-bugs.pt (+8/-3) lib/lp/bugs/templates/bugtarget-macros-filebug.pt (+1/-1) lib/lp/code/stories/branches/xx-branch-tag-cloud.txt (+7/-5) lib/lp/code/stories/branches/xx-product-branches.txt (+12/-8) lib/lp/registry/browser/configure.zcml (+42/-0) lib/lp/registry/browser/pillar.py (+72/-4) lib/lp/registry/browser/product.py (+101/-23) lib/lp/registry/browser/productseries.py (+24/-20) lib/lp/registry/browser/tests/pillar-views.txt (+46/-14) lib/lp/registry/doc/product.txt (+6/-3) lib/lp/registry/model/product.py (+6/-2) lib/lp/registry/stories/product/xx-product-development-focus.txt (+32/-16) lib/lp/registry/stories/product/xx-product-edit.txt (+4/-2) lib/lp/registry/stories/product/xx-product-launchpad-usage.txt (+40/-17) lib/lp/registry/templates/pillar-involvement-portlet.pt (+30/-3) lib/lp/registry/templates/product-index.pt (+0/-4) lib/lp/translations/stories/productseries/xx-productseries-translations.txt (+10/-10) lib/lp/translations/stories/standalone/xx-product-translations.txt (+8/-7) lib/lp/translations/stories/translationgroups/15-product-translation-group.txt (+3/-2) lib/lp/translations/stories/translationgroups/46-test-distro-structured-permissions.txt (+1/-1) lib/lp/translations/stories/translations/55-rosetta-potemplates.txt (+2/-1) lib/lp/translations/templates/product-portlet-not-using-launchpad.pt (+12/-9) |
| To merge this branch: | bzr merge lp:~edwin-grubbs/launchpad/bug-490593-configure-involvement-portlet |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Curtis Hovey (community) | code ui | Approve | |
|
Review via email:
|
|||
Commit message
Description of the change
Summary
-------
This branch uses the "Get Involved" portlet to encourage users to link
projects to the upstream bug tracker. In a later branch, we may open
up permissions to more than the project owner.
Implementation details
-------
Drive-by cleanups.
Makefile
lib/
Split out form elements for configuring Launchpad services into seperate
forms. The visible_
projects that don't have Bugs or Branches configured.
lib/
lib/
lib/
lib/
lib/
lib/
Added styles for a disabled version of the Get Involved links.
lib/
Fixed links that were pointing to +edit.
lib/
lib/
lib/
Fixed tests that were expecting to use +edit.
lib/
lib/
lib/
lib/
lib/
lib/
lib/
lib/
lib/
lib/
lib/
lib/
lib/
lib/
lib/
lib/
Tests
-----
./bin/test -vv -t whatever '/xx-product-
Demo and Q/A
------------
* Open http://
* Test the new forms and links for:
* Configure Launchpad Answers
* Configure Launchpad Branches
* Configure Launchpad Bugs
* Configure Launchpad Translations
* Open http://
* There should be a "Configure Launchpad Blueprints" link.
* Open http://
* If translations is disabled, there should be a
"Configure Launchpad Translations" link.
* Open http://
* If the project is not using launchpad for bug tracking,
there should be a "Configure Launchpad Bugs" link.
To post a comment you must log in.
Revision history for this message
| Edwin Grubbs (edwin-grubbs) wrote : | # |
Download full text (23.5 KiB)
> Hi Edwin.
>
> I really appreciate your effort to solve this usability issue.
>
> UI/Usability
> ------------
>
> ! As the owner of thunderbird, I saw that the "Report a bug" was disabled. I
> used "Configure Launchpad bugs" and choose The Mozilla.org bug tracker and
> provided the remove project.
> * I still see "Report a bug" (This service needs configuration). This is
> wrong. I provided the real information that should satisfy other
> contributors. I expect to see the warning disappear.
Hi Curtis,
Thanks for the review.
As we discussed on Skype, I will focus on code hosting now and fix the logic for displaying the bug tracker warning in another branch.
I have not fixed any of the unit tests for these recent changes, since I want to get your input on the UI changes first. You will notice that "Configure code hosting" switches between a plus-icon and an edit-icon, since I'm re-using the original menu item for +linkbranch. The plus-icon doesn't really make sense with the "configure" verb, but I think it is worth contemplating the use of a different icon to indicate unconfigured services.
> ! As the owner of Firefox and thunderbird, I expect to see a warning that
> "Development focus branch has not been specified" which I can see in the
> Project information portlet.
> * I think this is a case where official_
> We know if the project officially uses code if the branch is neither a
> mirror or import. I expect the Involvement portlet to tell me that this
> is a problem.
> * As an anonymous user I should see a warning that the development focus is
> missing a branch in the Involvement portlet.
> * May be call for action should also be repeated on the series page since
> that is the object that is being edited.
I'm confused here, since a little further down you comment that the warning could be removed from the Project information portlet. Do you want a more noticeable warning message in the involvement portlet than a tooltip?
> ! As the user of evolution, a project that has a link to a package with
> I expect to see a warning that translation syncing should be setup.
> The owner certainly can set official/unofficial usage, but any user
> can enable series sync, and should if Ubuntu has translations for it.
> * This is a unique case were any user can set this. This information
> must be shown on the series overview for any user to act on.
> * We may want alternate configuration link or tool tips about the
> problem.
> * This is case is harder than the others because the official_
> attribute is legitimate.
We agreed to handle translations later.
> ! I think the message for all these services is wrong. We want the user
> to tell Launchpad where the service is and maybe configure it if the
> service is Launchpad's. In the bug tracker example. we need to know the
> bug tracker, and the owner wants to tell every one about the official
> tracker; no one is asking users to enable Launchpad Bugs.
I tried improving the tooltip for the warnings.
> * I noticed that as an anonymous user or no-priv that the Involve...
Revision history for this message
| Curtis Hovey (sinzui) wrote : | # |
Download full text (7.5 KiB)
Hi Edwin.
I have a couple suggestion and questions that I think will take a few minutes
to resolve.
Using the UI:
* "bug tracker" is two words.
* Maybe "Configure support tracking" for answers.
* We are asking users to Configure project development branch? I guess
length is the issue here.
Code:
I see these warnings:
== Pyflakes notices ==
lib/
28: 'IProductSeries' imported but unused
lib/
9: undefined name 'ProductInvolve
> === modified file 'lib/lp/
> --- lib/lp/
> +++ lib/lp/
> @@ -169,9 +169,14 @@
> bug tracking.
>
> <p tal:condition=
> - id="no-
> - <a tal:attributes=
> - bug tracking.</a>
> + id="no-malone-edit"
> + tal:define ="configure_
> + >
> + <a tal:condition=
> + tal:replace=
> + <a tal:condition="not: configure_
> + tal:attributes=
> + Enable bug tracking.</a>
Why isn't this using the context's overview menu edit link that has
permission checking for rendering.
context/
The language looks wrong. We are interested in Configuring, not enabling.
I think this is for the bugs root page which may be fine in this case.
> === modified file 'lib/lp/
> --- lib/lp/
> +++ lib/lp/
> @@ -170,7 +170,7 @@
> the 'Import your project' button is not shown.
>
> >>> admin_browser.
> - >>> admin_browser.
> + >>> admin_browser.
> >>> admin_browser.
> ... 'Code for this project is published in Bazaar branches '
> ... 'on Launchpad').click()
I do not like the use of "Launchpad" in these links. They imply the project
is setting up hosting when we are really interested in gathering project info.
I have dealt with several angry, confused users who see Launchpad masquerading
or is forking project. I think taking "Launchpad" out of the link will make
it clear we want the know where the upstream branch is.
> === modified file 'lib/lp/
> --- lib/lp/
> +++ lib/lp/
> @@ -128,6 +130,78 @@
> link for link in menuapi.
> key=attrgetter(
>
> + @cachedproperty
> + def visible_d...
review:
Needs Information
(code ui)
Revision history for this message
| Edwin Grubbs (edwin-grubbs) wrote : | # |
Download full text (20.2 KiB)
Hi Curtis,
Thanks for the review. I have merged in Brad's branch and pointed
the "Configure product branch" links at +setbranch instead of
+linkbranch, and I have responded to your comments below.
-Edwin
> Hi Edwin.
>
> I have a couple suggestion and questions that I think will take a few minutes
> to resolve.
>
> Using the UI:
>
> * "bug tracker" is two words.
> * Maybe "Configure support tracking" for answers.
> * We are asking users to Configure project development branch? I guess
> length is the issue here.
Fixed.
>
> Code:
>
> I see these warnings:
>
> == Pyflakes notices ==
>
> lib/lp/
> 28: 'IProductSeries' imported but unused
>
> lib/lp/
> 9: undefined name 'ProductInvolve
>
TODO: lint
>
> > === modified file 'lib/lp/
> > --- lib/lp/
> > +++ lib/lp/
> > @@ -169,9 +169,14 @@
> > bug tracking.
> >
> > <p tal:condition=
> > - id="no-
> > - <a tal:attributes=
> > - bug tracking.</a>
> > + id="no-malone-edit"
> > + tal:define ="configure_
> context/
> > + >
> > + <a tal:condition=
> > + tal:replace=
> > + <a tal:condition="not: configure_
> > + tal:attributes=
> > + Enable bug tracking.</a>
>
> Why isn't this using the context's overview menu edit link that has
> permission checking for rendering.
>
> context/
>
> The language looks wrong. We are interested in Configuring, not enabling.
> I think this is for the bugs root page which may be fine in this case.
I was afraid of breaking a bunch more tests if I changed the name of
the link from "Enable bug tracking", not to mention that there may be
push back on the "Configure bug tracker" link later on.
> > === modified file 'lib/lp/
> > --- lib/lp/
> 14:22:42 +0000
> > +++ lib/lp/
> 16:20:16 +0000
> > @@ -170,7 +170,7 @@
> > the 'Import your project' button is not shown.
> >
> > >>> admin_browser.
> > - >>> admin_browser.
> > + >>> admin_browser.
> > >>> admin_browser.
> > ... 'Code for this project is published in Bazaar branches '
> > ... 'on Launchpad').click()
>
> I do not like the use of "Launchpad" in these links. They imply the project
> is setting up hosting when we are really interested in gathering project info.
>
> I have dealt with severa...
Revision history for this message
| Curtis Hovey (sinzui) wrote : | # |
Thanks for these revisions Edwin.
I am very aware of the ProductInvolvem
review:
Approve
(code ui)
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
| 1 | === modified file 'Makefile' | |||
| 2 | --- Makefile 2010-04-06 21:43:23 +0000 | |||
| 3 | +++ Makefile 2010-04-09 18:48:33 +0000 | |||
| 4 | @@ -182,7 +182,10 @@ | |||
| 5 | 182 | --download-base=download-cache/dist --eggs=eggs | 182 | --download-base=download-cache/dist --eggs=eggs |
| 6 | 183 | 183 | ||
| 7 | 184 | # This builds bin/py and all the other bin files except bin/buildout. | 184 | # This builds bin/py and all the other bin files except bin/buildout. |
| 8 | 185 | # Remove the target before calling buildout to ensure that buildout | ||
| 9 | 186 | # updates the timestamp. | ||
| 10 | 185 | $(BUILDOUT_BIN): bin/buildout versions.cfg $(BUILDOUT_CFG) setup.py | 187 | $(BUILDOUT_BIN): bin/buildout versions.cfg $(BUILDOUT_CFG) setup.py |
| 11 | 188 | $(RM) $@ | ||
| 12 | 186 | $(SHHH) PYTHONPATH= ./bin/buildout \ | 189 | $(SHHH) PYTHONPATH= ./bin/buildout \ |
| 13 | 187 | configuration:instance_name=${LPCONFIG} -c $(BUILDOUT_CFG) | 190 | configuration:instance_name=${LPCONFIG} -c $(BUILDOUT_CFG) |
| 14 | 188 | 191 | ||
| 15 | 189 | 192 | ||
| 16 | === modified file 'lib/canonical/launchpad/icing/style-3-0.css.in' | |||
| 17 | --- lib/canonical/launchpad/icing/style-3-0.css.in 2010-04-06 17:12:49 +0000 | |||
| 18 | +++ lib/canonical/launchpad/icing/style-3-0.css.in 2010-04-09 18:48:33 +0000 | |||
| 19 | @@ -525,6 +525,19 @@ | |||
| 20 | 525 | display: block; | 525 | display: block; |
| 21 | 526 | padding: 0.3em; | 526 | padding: 0.3em; |
| 22 | 527 | } | 527 | } |
| 23 | 528 | .involvement li.disabled { | ||
| 24 | 529 | color: #cccccc; | ||
| 25 | 530 | } | ||
| 26 | 531 | .involvement-service-links li.disabled img { | ||
| 27 | 532 | margin-bottom: 0; | ||
| 28 | 533 | } | ||
| 29 | 534 | .involvement-service-links li.disabled span { | ||
| 30 | 535 | margin-bottom: 0; | ||
| 31 | 536 | } | ||
| 32 | 537 | .involvement-service-links li.disabled table { | ||
| 33 | 538 | padding-top: 0.3em; | ||
| 34 | 539 | padding-bottom: 0.3em; | ||
| 35 | 540 | } | ||
| 36 | 528 | .involvement a.bugs { | 541 | .involvement a.bugs { |
| 37 | 529 | color: #b9413e; | 542 | color: #b9413e; |
| 38 | 530 | background: url(/@@/bugs-arrow-right.png) right center no-repeat; | 543 | background: url(/@@/bugs-arrow-right.png) right center no-repeat; |
| 39 | @@ -812,15 +825,23 @@ | |||
| 40 | 812 | padding: 2px 0 5px 18px; | 825 | padding: 2px 0 5px 18px; |
| 41 | 813 | line-height: 18px; | 826 | line-height: 18px; |
| 42 | 814 | } | 827 | } |
| 43 | 828 | .icon-only { | ||
| 44 | 829 | border: 0; | ||
| 45 | 830 | padding: 0; | ||
| 46 | 831 | width: 14px; | ||
| 47 | 832 | } | ||
| 48 | 833 | div.icon-only { | ||
| 49 | 834 | height: 14px; | ||
| 50 | 835 | } | ||
| 51 | 815 | input[type="submit"].icon-only { | 836 | input[type="submit"].icon-only { |
| 57 | 816 | vertical-align: middle; | 837 | height: 14px; |
| 53 | 817 | border: 0; | ||
| 54 | 818 | padding: 0; | ||
| 55 | 819 | height: 16px; | ||
| 56 | 820 | width: 16px; | ||
| 58 | 821 | background-color: inherit; | 838 | background-color: inherit; |
| 59 | 822 | cursor: pointer; | 839 | cursor: pointer; |
| 60 | 823 | } | 840 | } |
| 61 | 841 | span.icon-only { | ||
| 62 | 842 | padding-right: 14px; | ||
| 63 | 843 | line-height: 14px; | ||
| 64 | 844 | } | ||
| 65 | 824 | .vertical .sprite { | 845 | .vertical .sprite { |
| 66 | 825 | /* XXX: EdwinGrubbs 2009-10-29 bug=463032 | 846 | /* XXX: EdwinGrubbs 2009-10-29 bug=463032 |
| 67 | 826 | The reduced padding is only necessary to prevent parts of the | 847 | The reduced padding is only necessary to prevent parts of the |
| 68 | 827 | 848 | ||
| 69 | === added file 'lib/canonical/launchpad/images/gray-arrow-right.png' | |||
| 70 | 828 | Binary files lib/canonical/launchpad/images/gray-arrow-right.png 1970-01-01 00:00:00 +0000 and lib/canonical/launchpad/images/gray-arrow-right.png 2010-04-09 18:48:33 +0000 differ | 849 | Binary files lib/canonical/launchpad/images/gray-arrow-right.png 1970-01-01 00:00:00 +0000 and lib/canonical/launchpad/images/gray-arrow-right.png 2010-04-09 18:48:33 +0000 differ |
| 71 | === modified file 'lib/canonical/launchpad/pagetests/standalone/xx-form-layout.txt' | |||
| 72 | --- lib/canonical/launchpad/pagetests/standalone/xx-form-layout.txt 2010-03-26 13:26:12 +0000 | |||
| 73 | +++ lib/canonical/launchpad/pagetests/standalone/xx-form-layout.txt 2010-04-09 18:48:33 +0000 | |||
| 74 | @@ -91,7 +91,8 @@ | |||
| 75 | 91 | Checkboxes have their label to the right. One example is the checkbox for | 91 | Checkboxes have their label to the right. One example is the checkbox for |
| 76 | 92 | specifying whether your project uses Launchpad Translations. | 92 | specifying whether your project uses Launchpad Translations. |
| 77 | 93 | 93 | ||
| 79 | 94 | >>> admin_browser.open('http://launchpad.dev/evolution/+edit') | 94 | >>> admin_browser.open( |
| 80 | 95 | ... 'http://launchpad.dev/evolution/+configure-translations') | ||
| 81 | 95 | >>> content = find_main_content(admin_browser.contents) | 96 | >>> content = find_main_content(admin_browser.contents) |
| 82 | 96 | 97 | ||
| 83 | 97 | >>> print content | 98 | >>> print content |
| 84 | 98 | 99 | ||
| 85 | === modified file 'lib/lp/blueprints/browser/specificationtarget.py' | |||
| 86 | --- lib/lp/blueprints/browser/specificationtarget.py 2010-02-19 11:55:02 +0000 | |||
| 87 | +++ lib/lp/blueprints/browser/specificationtarget.py 2010-04-09 18:48:33 +0000 | |||
| 88 | @@ -42,7 +42,7 @@ | |||
| 89 | 42 | from canonical.lazr.utils import smartquote | 42 | from canonical.lazr.utils import smartquote |
| 90 | 43 | 43 | ||
| 91 | 44 | 44 | ||
| 93 | 45 | class HasSpecificationsMenuMixin(object): | 45 | class HasSpecificationsMenuMixin: |
| 94 | 46 | 46 | ||
| 95 | 47 | def listall(self): | 47 | def listall(self): |
| 96 | 48 | """Return a link to show all blueprints.""" | 48 | """Return a link to show all blueprints.""" |
| 97 | 49 | 49 | ||
| 98 | === modified file 'lib/lp/bugs/stories/bug-also-affects/xx-upstream-bugtracker-links.txt' | |||
| 99 | --- lib/lp/bugs/stories/bug-also-affects/xx-upstream-bugtracker-links.txt 2009-07-01 13:16:44 +0000 | |||
| 100 | +++ lib/lp/bugs/stories/bug-also-affects/xx-upstream-bugtracker-links.txt 2010-04-09 18:48:33 +0000 | |||
| 101 | @@ -28,7 +28,8 @@ | |||
| 102 | 28 | If we link Thunderbird to an upstream bug tracker, the text will change | 28 | If we link Thunderbird to an upstream bug tracker, the text will change |
| 103 | 29 | to reflect this. | 29 | to reflect this. |
| 104 | 30 | 30 | ||
| 106 | 31 | >>> admin_browser.open('http://launchpad.dev/thunderbird/+edit') | 31 | >>> admin_browser.open( |
| 107 | 32 | ... 'http://launchpad.dev/thunderbird/+configure-bugtracker') | ||
| 108 | 32 | >>> admin_browser.getControl( | 33 | >>> admin_browser.getControl( |
| 109 | 33 | ... name='field.bugtracker').value = ['external'] | 34 | ... name='field.bugtracker').value = ['external'] |
| 110 | 34 | >>> admin_browser.getControl( | 35 | >>> admin_browser.getControl( |
| 111 | @@ -89,7 +90,8 @@ | |||
| 112 | 89 | If the remote bug tracker is one for which Launchpad doesn't offer a bug | 90 | If the remote bug tracker is one for which Launchpad doesn't offer a bug |
| 113 | 90 | filing link, such as Debbugs, only a search link will be displayed. | 91 | filing link, such as Debbugs, only a search link will be displayed. |
| 114 | 91 | 92 | ||
| 116 | 92 | >>> admin_browser.open('http://launchpad.dev/gnome-terminal/+edit') | 93 | >>> admin_browser.open( |
| 117 | 94 | ... 'http://launchpad.dev/gnome-terminal/+configure-bugtracker') | ||
| 118 | 93 | >>> admin_browser.getControl( | 95 | >>> admin_browser.getControl( |
| 119 | 94 | ... 'In a registered bug tracker:').selected = True | 96 | ... 'In a registered bug tracker:').selected = True |
| 120 | 95 | >>> admin_browser.getControl( | 97 | >>> admin_browser.getControl( |
| 121 | 96 | 98 | ||
| 122 | === modified file 'lib/lp/bugs/stories/bugs/xx-front-page-info.txt' | |||
| 123 | --- lib/lp/bugs/stories/bugs/xx-front-page-info.txt 2010-03-12 14:26:46 +0000 | |||
| 124 | +++ lib/lp/bugs/stories/bugs/xx-front-page-info.txt 2010-04-09 18:48:33 +0000 | |||
| 125 | @@ -31,7 +31,7 @@ | |||
| 126 | 31 | >>> enable_tracker = find_tag_by_id( | 31 | >>> enable_tracker = find_tag_by_id( |
| 127 | 32 | ... admin_browser.contents, 'no-malone-edit') | 32 | ... admin_browser.contents, 'no-malone-edit') |
| 128 | 33 | >>> print extract_text(enable_tracker) | 33 | >>> print extract_text(enable_tracker) |
| 130 | 34 | Enable bug tracking. | 34 | Configure bug tracker |
| 131 | 35 | 35 | ||
| 132 | 36 | The bugs home page for a project using Launchpad for bug tracking | 36 | The bugs home page for a project using Launchpad for bug tracking |
| 133 | 37 | shows controls for setting bug supervisor and states that no | 37 | shows controls for setting bug supervisor and states that no |
| 134 | 38 | 38 | ||
| 135 | === modified file 'lib/lp/bugs/stories/bugtracker/bugtrackers-index.txt' | |||
| 136 | --- lib/lp/bugs/stories/bugtracker/bugtrackers-index.txt 2009-09-23 11:10:00 +0000 | |||
| 137 | +++ lib/lp/bugs/stories/bugtracker/bugtrackers-index.txt 2010-04-09 18:48:33 +0000 | |||
| 138 | @@ -88,7 +88,8 @@ | |||
| 139 | 88 | Let's link a pair to debbugs: | 88 | Let's link a pair to debbugs: |
| 140 | 89 | 89 | ||
| 141 | 90 | >>> def link_to_debbugs(name): | 90 | >>> def link_to_debbugs(name): |
| 143 | 91 | ... admin_browser.open("http://launchpad.dev/%s/+edit" % name) | 91 | ... admin_browser.open( |
| 144 | 92 | ... "http://launchpad.dev/%s/+configure-bugtracker" % name) | ||
| 145 | 92 | ... admin_browser.getControl("In a registered bug tracker").click() | 93 | ... admin_browser.getControl("In a registered bug tracker").click() |
| 146 | 93 | ... bt = admin_browser.getControl(name="field.bugtracker.bugtracker") | 94 | ... bt = admin_browser.getControl(name="field.bugtracker.bugtracker") |
| 147 | 94 | ... bt.value = ["3"] | 95 | ... bt.value = ["3"] |
| 148 | 95 | 96 | ||
| 149 | === modified file 'lib/lp/bugs/stories/bugtracker/xx-bugtracker.txt' | |||
| 150 | --- lib/lp/bugs/stories/bugtracker/xx-bugtracker.txt 2010-04-09 12:00:54 +0000 | |||
| 151 | +++ lib/lp/bugs/stories/bugtracker/xx-bugtracker.txt 2010-04-09 18:48:33 +0000 | |||
| 152 | @@ -672,7 +672,8 @@ | |||
| 153 | 672 | ... 'A test Bugzilla Tracker'] | 672 | ... 'A test Bugzilla Tracker'] |
| 154 | 673 | >>> admin_browser.getControl('Change Details').click() | 673 | >>> admin_browser.getControl('Change Details').click() |
| 155 | 674 | 674 | ||
| 157 | 675 | >>> admin_browser.open('http://launchpad.dev/jokosher/+edit') | 675 | >>> admin_browser.open( |
| 158 | 676 | ... 'http://launchpad.dev/jokosher/+configure-bugtracker') | ||
| 159 | 676 | >>> admin_browser.getControl(name='field.bugtracker' | 677 | >>> admin_browser.getControl(name='field.bugtracker' |
| 160 | 677 | ... ).displayValue = ['In a registered bug tracker:'] | 678 | ... ).displayValue = ['In a registered bug tracker:'] |
| 161 | 678 | >>> admin_browser.getControl(name='field.bugtracker.bugtracker' | 679 | >>> admin_browser.getControl(name='field.bugtracker.bugtracker' |
| 162 | 679 | 680 | ||
| 163 | === modified file 'lib/lp/bugs/stories/guided-filebug/xx-bug-reporting-guidelines.txt' | |||
| 164 | --- lib/lp/bugs/stories/guided-filebug/xx-bug-reporting-guidelines.txt 2009-10-30 12:17:48 +0000 | |||
| 165 | +++ lib/lp/bugs/stories/guided-filebug/xx-bug-reporting-guidelines.txt 2010-04-09 18:48:33 +0000 | |||
| 166 | @@ -4,14 +4,14 @@ | |||
| 167 | 4 | distributions, product groups, products, and source packages. | 4 | distributions, product groups, products, and source packages. |
| 168 | 5 | 5 | ||
| 169 | 6 | >>> contexts = [ | 6 | >>> contexts = [ |
| 174 | 7 | ... ('Ubuntu', 'ubuntu'), | 7 | ... ('Ubuntu', 'ubuntu', '+edit'), |
| 175 | 8 | ... ('Mozilla', 'mozilla'), | 8 | ... ('Mozilla', 'mozilla', '+edit'), |
| 176 | 9 | ... ('Firefox', 'firefox'), | 9 | ... ('Firefox', 'firefox', '+configure-bugtracker'), |
| 177 | 10 | ... ('alsa-utils in Ubuntu', 'ubuntu/+source/alsa-utils'), | 10 | ... ('alsa-utils in Ubuntu', 'ubuntu/+source/alsa-utils', '+edit'), |
| 178 | 11 | ... ] | 11 | ... ] |
| 179 | 12 | 12 | ||
| 182 | 13 | >>> for context_name, context_path in contexts: | 13 | >>> for context_name, context_path, view in contexts: |
| 183 | 14 | ... edit_url = 'http://launchpad.dev/%s/+edit' % (context_path,) | 14 | ... edit_url = 'http://launchpad.dev/%s/%s' % (context_path, view) |
| 184 | 15 | ... admin_browser.open(edit_url) | 15 | ... admin_browser.open(edit_url) |
| 185 | 16 | ... admin_browser.getControl( | 16 | ... admin_browser.getControl( |
| 186 | 17 | ... name='field.bug_reporting_guidelines').value = ( | 17 | ... name='field.bug_reporting_guidelines').value = ( |
| 187 | @@ -31,7 +31,7 @@ | |||
| 188 | 31 | ... print extract_text(find_tag_by_id( | 31 | ... print extract_text(find_tag_by_id( |
| 189 | 32 | ... user_browser.contents, 'bug-reporting-guidelines')) | 32 | ... user_browser.contents, 'bug-reporting-guidelines')) |
| 190 | 33 | 33 | ||
| 192 | 34 | >>> for context_name, context_path in contexts: | 34 | >>> for context_name, context_path, view in contexts: |
| 193 | 35 | ... filebug_url = ( | 35 | ... filebug_url = ( |
| 194 | 36 | ... 'http://launchpad.dev/%s/+filebug' % (context_path,)) | 36 | ... 'http://launchpad.dev/%s/+filebug' % (context_path,)) |
| 195 | 37 | ... user_browser.open(filebug_url) | 37 | ... user_browser.open(filebug_url) |
| 196 | @@ -43,7 +43,7 @@ | |||
| 197 | 43 | But they are displayed once you've got to the step of entering a bug | 43 | But they are displayed once you've got to the step of entering a bug |
| 198 | 44 | description. | 44 | description. |
| 199 | 45 | 45 | ||
| 201 | 46 | >>> for context_name, context_path in contexts: | 46 | >>> for context_name, context_path, view in contexts: |
| 202 | 47 | ... filebug_url = ( | 47 | ... filebug_url = ( |
| 203 | 48 | ... 'http://launchpad.dev/%s/+filebug' % (context_path,)) | 48 | ... 'http://launchpad.dev/%s/+filebug' % (context_path,)) |
| 204 | 49 | ... user_browser.open(filebug_url) | 49 | ... user_browser.open(filebug_url) |
| 205 | @@ -143,7 +143,7 @@ | |||
| 206 | 143 | ... pass | 143 | ... pass |
| 207 | 144 | 144 | ||
| 208 | 145 | >>> edit_url_re = re.compile('/[+]edit$') | 145 | >>> edit_url_re = re.compile('/[+]edit$') |
| 210 | 146 | >>> for context_name, context_path in contexts: | 146 | >>> for context_name, context_path, view in contexts: |
| 211 | 147 | ... overview_url = 'http://launchpad.dev/%s' % (context_path,) | 147 | ... overview_url = 'http://launchpad.dev/%s' % (context_path,) |
| 212 | 148 | ... print '* ' + context_name | 148 | ... print '* ' + context_name |
| 213 | 149 | ... print ' - User:', | 149 | ... print ' - User:', |
| 214 | @@ -173,8 +173,8 @@ | |||
| 215 | 173 | Unprivileged cannot access the page for changing bug reporting | 173 | Unprivileged cannot access the page for changing bug reporting |
| 216 | 174 | guidelines. | 174 | guidelines. |
| 217 | 175 | 175 | ||
| 220 | 176 | >>> for context_name, context_path in contexts: | 176 | >>> for context_name, context_path, view in contexts: |
| 221 | 177 | ... edit_url = 'http://launchpad.dev/%s/+edit' % (context_path,) | 177 | ... edit_url = 'http://launchpad.dev/%s/%s' % (context_path, view) |
| 222 | 178 | ... print '* ' + context_name | 178 | ... print '* ' + context_name |
| 223 | 179 | ... try: | 179 | ... try: |
| 224 | 180 | ... user_browser.open(edit_url) | 180 | ... user_browser.open(edit_url) |
| 225 | 181 | 181 | ||
| 226 | === modified file 'lib/lp/bugs/stories/guided-filebug/xx-no-launchpadder.txt' | |||
| 227 | --- lib/lp/bugs/stories/guided-filebug/xx-no-launchpadder.txt 2009-07-27 12:39:34 +0000 | |||
| 228 | +++ lib/lp/bugs/stories/guided-filebug/xx-no-launchpadder.txt 2010-04-09 18:48:33 +0000 | |||
| 229 | @@ -52,7 +52,8 @@ | |||
| 230 | 52 | The advice is slightly different if the upstream bug tracker is | 52 | The advice is slightly different if the upstream bug tracker is |
| 231 | 53 | actually an email address. | 53 | actually an email address. |
| 232 | 54 | 54 | ||
| 234 | 55 | >>> admin_browser.open('http://launchpad.dev/jokosher/+edit') | 55 | >>> admin_browser.open( |
| 235 | 56 | ... 'http://launchpad.dev/jokosher/+configure-bugtracker') | ||
| 236 | 56 | >>> admin_browser.getControl( | 57 | >>> admin_browser.getControl( |
| 237 | 57 | ... 'By emailing an upstream bug contact').selected = True | 58 | ... 'By emailing an upstream bug contact').selected = True |
| 238 | 58 | >>> admin_browser.getControl( | 59 | >>> admin_browser.getControl( |
| 239 | 59 | 60 | ||
| 240 | === modified file 'lib/lp/bugs/stories/guided-filebug/xx-project-guided-filebug.txt' | |||
| 241 | --- lib/lp/bugs/stories/guided-filebug/xx-project-guided-filebug.txt 2010-01-13 15:08:30 +0000 | |||
| 242 | +++ lib/lp/bugs/stories/guided-filebug/xx-project-guided-filebug.txt 2010-04-09 18:48:33 +0000 | |||
| 243 | @@ -217,7 +217,7 @@ | |||
| 244 | 217 | ... sourcepackagename=thunderbird_spn, distroseries=hoary) | 217 | ... sourcepackagename=thunderbird_spn, distroseries=hoary) |
| 245 | 218 | >>> logout() | 218 | >>> logout() |
| 246 | 219 | 219 | ||
| 248 | 220 | >>> admin_browser.open('http://launchpad.dev/testy/+edit') | 220 | >>> admin_browser.open('http://launchpad.dev/testy/+configure-bugtracker') |
| 249 | 221 | >>> admin_browser.getControl(name='field.bugtracker').value = ['external'] | 221 | >>> admin_browser.getControl(name='field.bugtracker').value = ['external'] |
| 250 | 222 | >>> admin_browser.getControl( | 222 | >>> admin_browser.getControl( |
| 251 | 223 | ... name='field.bugtracker.bugtracker').value = ['3'] | 223 | ... name='field.bugtracker.bugtracker').value = ['3'] |
| 252 | 224 | 224 | ||
| 253 | === modified file 'lib/lp/bugs/stories/initial-bug-contacts/10-set-upstream-bugcontact.txt' | |||
| 254 | --- lib/lp/bugs/stories/initial-bug-contacts/10-set-upstream-bugcontact.txt 2010-01-19 16:37:15 +0000 | |||
| 255 | +++ lib/lp/bugs/stories/initial-bug-contacts/10-set-upstream-bugcontact.txt 2010-04-09 18:48:33 +0000 | |||
| 256 | @@ -122,9 +122,9 @@ | |||
| 257 | 122 | We can change the settings to use Launchpad for bug tracking. | 122 | We can change the settings to use Launchpad for bug tracking. |
| 258 | 123 | 123 | ||
| 259 | 124 | >>> sample_browser.getLink( | 124 | >>> sample_browser.getLink( |
| 261 | 125 | ... 'Enable bug tracking.').click() | 125 | ... 'Configure bug tracker').click() |
| 262 | 126 | >>> print sample_browser.title | 126 | >>> print sample_browser.title |
| 264 | 127 | Change A product for testing things's details : Bugs : Test Product | 127 | Configure bug tracker : Bugs : Test Product |
| 265 | 128 | >>> sample_browser.getControl('In Launchpad').click() | 128 | >>> sample_browser.getControl('In Launchpad').click() |
| 266 | 129 | >>> sample_browser.getControl('Change').click() | 129 | >>> sample_browser.getControl('Change').click() |
| 267 | 130 | 130 | ||
| 268 | 131 | 131 | ||
| 269 | === modified file 'lib/lp/bugs/templates/bugtarget-bugs.pt' | |||
| 270 | --- lib/lp/bugs/templates/bugtarget-bugs.pt 2010-03-04 15:09:10 +0000 | |||
| 271 | +++ lib/lp/bugs/templates/bugtarget-bugs.pt 2010-04-09 18:48:33 +0000 | |||
| 272 | @@ -169,9 +169,14 @@ | |||
| 273 | 169 | bug tracking.</strong></p> | 169 | bug tracking.</strong></p> |
| 274 | 170 | 170 | ||
| 275 | 171 | <p tal:condition="context/required:launchpad.Edit" | 171 | <p tal:condition="context/required:launchpad.Edit" |
| 279 | 172 | id="no-malone-edit"> | 172 | id="no-malone-edit" |
| 280 | 173 | <a tal:attributes="href string:${context/fmt:url/+edit}">Enable | 173 | tal:define ="configure_bugtracker context/menu:overview/configure_bugtracker | nothing" |
| 281 | 174 | bug tracking.</a> | 174 | > |
| 282 | 175 | <a tal:condition="configure_bugtracker" | ||
| 283 | 176 | tal:replace="structure configure_bugtracker/fmt:link"/> | ||
| 284 | 177 | <a tal:condition="not: configure_bugtracker" | ||
| 285 | 178 | tal:attributes="href string:${context/fmt:url/+edit}"> | ||
| 286 | 179 | Enable bug tracking.</a> | ||
| 287 | 175 | </p> | 180 | </p> |
| 288 | 176 | </tal:not_uses_malone> | 181 | </tal:not_uses_malone> |
| 289 | 177 | 182 | ||
| 290 | 178 | 183 | ||
| 291 | === modified file 'lib/lp/bugs/templates/bugtarget-macros-filebug.pt' | |||
| 292 | --- lib/lp/bugs/templates/bugtarget-macros-filebug.pt 2009-12-04 12:12:35 +0000 | |||
| 293 | +++ lib/lp/bugs/templates/bugtarget-macros-filebug.pt 2010-04-09 18:48:33 +0000 | |||
| 294 | @@ -143,7 +143,7 @@ | |||
| 295 | 143 | <div class="highlight-message"> | 143 | <div class="highlight-message"> |
| 296 | 144 | <a tal:replace="structure product_or_distro/fmt:link">Alsa Utils</a> | 144 | <a tal:replace="structure product_or_distro/fmt:link">Alsa Utils</a> |
| 297 | 145 | <strong>does not use</strong> Launchpad as its bug tracker. | 145 | <strong>does not use</strong> Launchpad as its bug tracker. |
| 299 | 146 | <a tal:attributes="href context/menu:overview/edit/fmt:url" | 146 | <a tal:attributes="href context/menu:overview/configure_bugtracker/fmt:url" |
| 300 | 147 | tal:condition="context/required:launchpad.Edit"> | 147 | tal:condition="context/required:launchpad.Edit"> |
| 301 | 148 | Change this <span class="sprite edit"></span> | 148 | Change this <span class="sprite edit"></span> |
| 302 | 149 | </a> | 149 | </a> |
| 303 | 150 | 150 | ||
| 304 | === modified file 'lib/lp/code/stories/branches/xx-branch-tag-cloud.txt' | |||
| 305 | --- lib/lp/code/stories/branches/xx-branch-tag-cloud.txt 2009-08-28 05:57:37 +0000 | |||
| 306 | +++ lib/lp/code/stories/branches/xx-branch-tag-cloud.txt 2010-04-09 18:48:33 +0000 | |||
| 307 | @@ -22,11 +22,13 @@ | |||
| 308 | 22 | 22 | ||
| 309 | 23 | Update firefox to officially use codehosting: | 23 | Update firefox to officially use codehosting: |
| 310 | 24 | 24 | ||
| 316 | 25 | >>> admin_browser.open('http://launchpad.dev/firefox/+edit') | 25 | >>> from lp.registry.interfaces.product import IProductSet |
| 317 | 26 | >>> admin_browser.getControl( | 26 | >>> from zope.component import getUtility |
| 318 | 27 | ... 'Code for this project is published in Bazaar branches on ' | 27 | >>> login('admin@canonical.com') |
| 319 | 28 | ... 'Launchpad').click() | 28 | >>> firefox = getUtility(IProductSet).getByName('firefox') |
| 320 | 29 | >>> admin_browser.getControl('Change').click() | 29 | >>> firefox.development_focus.branch = factory.makeBranch( |
| 321 | 30 | ... product=firefox) | ||
| 322 | 31 | >>> logout() | ||
| 323 | 30 | 32 | ||
| 324 | 31 | The class for firefox in the project tag cloud will now show 'highlight' rather | 33 | The class for firefox in the project tag cloud will now show 'highlight' rather |
| 325 | 32 | than shade. | 34 | than shade. |
| 326 | 33 | 35 | ||
| 327 | === modified file 'lib/lp/code/stories/branches/xx-product-branches.txt' | |||
| 328 | --- lib/lp/code/stories/branches/xx-product-branches.txt 2010-01-08 14:22:42 +0000 | |||
| 329 | +++ lib/lp/code/stories/branches/xx-product-branches.txt 2010-04-09 18:48:33 +0000 | |||
| 330 | @@ -158,10 +158,18 @@ | |||
| 331 | 158 | There are two buttons that show on the right hand side of the screen | 158 | There are two buttons that show on the right hand side of the screen |
| 332 | 159 | for project branch listings. 'Register a branch' and 'Import your project'. | 159 | for project branch listings. 'Register a branch' and 'Import your project'. |
| 333 | 160 | 160 | ||
| 334 | 161 | >>> from zope.component import getUtility | ||
| 335 | 162 | >>> from lp.registry.interfaces.product import IProductSet | ||
| 336 | 163 | >>> login('admin@canonical.com') | ||
| 337 | 164 | >>> product = getUtility(IProductSet).getByName('firefox') | ||
| 338 | 165 | >>> old_branch = product.development_focus.branch | ||
| 339 | 166 | >>> product.development_focus.branch = None | ||
| 340 | 167 | >>> logout() | ||
| 341 | 161 | >>> def print_links(browser): | 168 | >>> def print_links(browser): |
| 342 | 162 | ... links = find_tag_by_id(browser.contents, 'floating-links') | 169 | ... links = find_tag_by_id(browser.contents, 'floating-links') |
| 343 | 163 | ... for link in links.findAll('a'): | 170 | ... for link in links.findAll('a'): |
| 344 | 164 | ... print extract_text(link) | 171 | ... print extract_text(link) |
| 345 | 172 | >>> browser.open('http://code.launchpad.dev/firefox') | ||
| 346 | 165 | >>> print_links(browser) | 173 | >>> print_links(browser) |
| 347 | 166 | Register a branch | 174 | Register a branch |
| 348 | 167 | Import your project | 175 | Import your project |
| 349 | @@ -169,14 +177,10 @@ | |||
| 350 | 169 | If the product specifies that it officially uses Launchpad code, then | 177 | If the product specifies that it officially uses Launchpad code, then |
| 351 | 170 | the 'Import your project' button is not shown. | 178 | the 'Import your project' button is not shown. |
| 352 | 171 | 179 | ||
| 361 | 172 | >>> admin_browser.open('http://launchpad.dev/gnome-terminal') | 180 | >>> login('admin@canonical.com') |
| 362 | 173 | >>> admin_browser.getLink('Change details').click() | 181 | >>> product.development_focus.branch = old_branch |
| 363 | 174 | >>> admin_browser.getControl( | 182 | >>> logout() |
| 364 | 175 | ... 'Code for this project is published in Bazaar branches ' | 183 | >>> browser.open('http://code.launchpad.dev/firefox') |
| 357 | 176 | ... 'on Launchpad').click() | ||
| 358 | 177 | >>> admin_browser.getControl('Change').click() | ||
| 359 | 178 | |||
| 360 | 179 | >>> browser.open('http://code.launchpad.dev/gnome-terminal') | ||
| 365 | 180 | >>> print_links(browser) | 184 | >>> print_links(browser) |
| 366 | 181 | Register a branch | 185 | Register a branch |
| 367 | 182 | 186 | ||
| 368 | 183 | 187 | ||
| 369 | === modified file 'lib/lp/registry/browser/configure.zcml' | |||
| 370 | --- lib/lp/registry/browser/configure.zcml 2010-04-06 18:49:52 +0000 | |||
| 371 | +++ lib/lp/registry/browser/configure.zcml 2010-04-09 18:48:33 +0000 | |||
| 372 | @@ -495,6 +495,20 @@ | |||
| 373 | 495 | facet="overview" | 495 | facet="overview" |
| 374 | 496 | permission="zope.Public" | 496 | permission="zope.Public" |
| 375 | 497 | template="../templates/pillar-involvement-portlet.pt"/> | 497 | template="../templates/pillar-involvement-portlet.pt"/> |
| 376 | 498 | <browser:page | ||
| 377 | 499 | name="+get-involved" | ||
| 378 | 500 | for="lp.registry.interfaces.product.IProduct" | ||
| 379 | 501 | class="lp.registry.browser.pillar.ProductInvolvementView" | ||
| 380 | 502 | facet="overview" | ||
| 381 | 503 | permission="zope.Public" | ||
| 382 | 504 | template="../templates/pillar-involvement-portlet.pt"/> | ||
| 383 | 505 | <browser:page | ||
| 384 | 506 | name="+get-involved" | ||
| 385 | 507 | for="lp.registry.interfaces.product.IProductSeries" | ||
| 386 | 508 | class="lp.registry.browser.pillar.ProductSeriesInvolvementView" | ||
| 387 | 509 | facet="overview" | ||
| 388 | 510 | permission="zope.Public" | ||
| 389 | 511 | template="../templates/pillar-involvement-portlet.pt"/> | ||
| 390 | 498 | <facet | 512 | <facet |
| 391 | 499 | facet="overview"> | 513 | facet="overview"> |
| 392 | 500 | <browser:url | 514 | <browser:url |
| 393 | @@ -1458,6 +1472,34 @@ | |||
| 394 | 1458 | permission="launchpad.Edit" | 1472 | permission="launchpad.Edit" |
| 395 | 1459 | template="../../app/templates/generic-edit.pt"/> | 1473 | template="../../app/templates/generic-edit.pt"/> |
| 396 | 1460 | <browser:page | 1474 | <browser:page |
| 397 | 1475 | for="lp.registry.interfaces.product.IProduct" | ||
| 398 | 1476 | facet="overview" | ||
| 399 | 1477 | permission="launchpad.Edit" | ||
| 400 | 1478 | name="+configure-answers" | ||
| 401 | 1479 | template="../../app/templates/generic-edit.pt" | ||
| 402 | 1480 | class="lp.registry.browser.product.ProductConfigureAnswersView"/> | ||
| 403 | 1481 | <browser:page | ||
| 404 | 1482 | for="lp.registry.interfaces.product.IProduct" | ||
| 405 | 1483 | facet="overview" | ||
| 406 | 1484 | permission="launchpad.Edit" | ||
| 407 | 1485 | name="+configure-blueprints" | ||
| 408 | 1486 | template="../../app/templates/generic-edit.pt" | ||
| 409 | 1487 | class="lp.registry.browser.product.ProductConfigureBlueprintsView"/> | ||
| 410 | 1488 | <browser:page | ||
| 411 | 1489 | for="lp.registry.interfaces.product.IProduct" | ||
| 412 | 1490 | facet="overview" | ||
| 413 | 1491 | permission="launchpad.Edit" | ||
| 414 | 1492 | name="+configure-bugtracker" | ||
| 415 | 1493 | template="../../app/templates/generic-edit.pt" | ||
| 416 | 1494 | class="lp.registry.browser.product.ProductConfigureBugTrackerView"/> | ||
| 417 | 1495 | <browser:page | ||
| 418 | 1496 | for="lp.registry.interfaces.product.IProduct" | ||
| 419 | 1497 | facet="overview" | ||
| 420 | 1498 | permission="launchpad.Edit" | ||
| 421 | 1499 | name="+configure-translations" | ||
| 422 | 1500 | template="../../app/templates/generic-edit.pt" | ||
| 423 | 1501 | class="lp.registry.browser.product.ProductConfigureTranslationsView"/> | ||
| 424 | 1502 | <browser:page | ||
| 425 | 1461 | name="+branding" | 1503 | name="+branding" |
| 426 | 1462 | for="lp.registry.interfaces.product.IProduct" | 1504 | for="lp.registry.interfaces.product.IProduct" |
| 427 | 1463 | facet="overview" | 1505 | facet="overview" |
| 428 | 1464 | 1506 | ||
| 429 | === modified file 'lib/lp/registry/browser/pillar.py' | |||
| 430 | --- lib/lp/registry/browser/pillar.py 2010-02-17 11:19:42 +0000 | |||
| 431 | +++ lib/lp/registry/browser/pillar.py 2010-04-09 18:48:33 +0000 | |||
| 432 | @@ -15,6 +15,7 @@ | |||
| 433 | 15 | from zope.component.globalregistry import provideAdapter | 15 | from zope.component.globalregistry import provideAdapter |
| 434 | 16 | from zope.interface import implements, Interface | 16 | from zope.interface import implements, Interface |
| 435 | 17 | 17 | ||
| 436 | 18 | from canonical.cachedproperty import cachedproperty | ||
| 437 | 18 | from canonical.launchpad.webapp.interfaces import INavigationMenu | 19 | from canonical.launchpad.webapp.interfaces import INavigationMenu |
| 438 | 19 | from canonical.launchpad.webapp.menu import Link, NavigationMenu | 20 | from canonical.launchpad.webapp.menu import Link, NavigationMenu |
| 439 | 20 | from canonical.launchpad.webapp.publisher import LaunchpadView, nearest | 21 | from canonical.launchpad.webapp.publisher import LaunchpadView, nearest |
| 440 | @@ -24,7 +25,6 @@ | |||
| 441 | 24 | from lp.registry.interfaces.distributionsourcepackage import ( | 25 | from lp.registry.interfaces.distributionsourcepackage import ( |
| 442 | 25 | IDistributionSourcePackage) | 26 | IDistributionSourcePackage) |
| 443 | 26 | from lp.registry.interfaces.pillar import IPillar | 27 | from lp.registry.interfaces.pillar import IPillar |
| 444 | 27 | from lp.registry.interfaces.productseries import IProductSeries | ||
| 445 | 28 | from lp.registry.interfaces.projectgroup import IProjectGroup | 28 | from lp.registry.interfaces.projectgroup import IProjectGroup |
| 446 | 29 | 29 | ||
| 447 | 30 | 30 | ||
| 448 | @@ -69,6 +69,9 @@ | |||
| 449 | 69 | """A view for any `IPillar`.""" | 69 | """A view for any `IPillar`.""" |
| 450 | 70 | implements(IInvolved) | 70 | implements(IInvolved) |
| 451 | 71 | 71 | ||
| 452 | 72 | configuration_links = [] | ||
| 453 | 73 | visible_disabled_link_names = [] | ||
| 454 | 74 | |||
| 455 | 72 | def __init__(self, context, request): | 75 | def __init__(self, context, request): |
| 456 | 73 | super(PillarView, self).__init__(context, request) | 76 | super(PillarView, self).__init__(context, request) |
| 457 | 74 | self.official_malone = False | 77 | self.official_malone = False |
| 458 | @@ -85,9 +88,7 @@ | |||
| 459 | 85 | self.official_codehosting = False | 88 | self.official_codehosting = False |
| 460 | 86 | else: | 89 | else: |
| 461 | 87 | self._set_official_launchpad(pillar) | 90 | self._set_official_launchpad(pillar) |
| 465 | 88 | if IProductSeries.providedBy(self.context): | 91 | if IDistroSeries.providedBy(self.context): |
| 463 | 89 | self.official_answers = False | ||
| 464 | 90 | elif IDistroSeries.providedBy(self.context): | ||
| 466 | 91 | self.official_answers = False | 92 | self.official_answers = False |
| 467 | 92 | self.official_codehosting = False | 93 | self.official_codehosting = False |
| 468 | 93 | elif IDistributionSourcePackage.providedBy(self.context): | 94 | elif IDistributionSourcePackage.providedBy(self.context): |
| 469 | @@ -128,6 +129,73 @@ | |||
| 470 | 128 | link for link in menuapi.navigation.values() if link.enabled], | 129 | link for link in menuapi.navigation.values() if link.enabled], |
| 471 | 129 | key=attrgetter('sort_key')) | 130 | key=attrgetter('sort_key')) |
| 472 | 130 | 131 | ||
| 473 | 132 | @cachedproperty | ||
| 474 | 133 | def visible_disabled_links(self): | ||
| 475 | 134 | """Important disabled links. | ||
| 476 | 135 | |||
| 477 | 136 | These are displayed to notify the user to provide configuration | ||
| 478 | 137 | info to enable the links. | ||
| 479 | 138 | |||
| 480 | 139 | Override the visible_disabled_link_names attribute to change | ||
| 481 | 140 | the results. | ||
| 482 | 141 | """ | ||
| 483 | 142 | involved_menu = MenuAPI(self).navigation | ||
| 484 | 143 | important_links = [ | ||
| 485 | 144 | involved_menu[name] | ||
| 486 | 145 | for name in self.visible_disabled_link_names] | ||
| 487 | 146 | return sorted([ | ||
| 488 | 147 | link for link in important_links if not link.enabled], | ||
| 489 | 148 | key=attrgetter('sort_key')) | ||
| 490 | 149 | |||
| 491 | 131 | 150 | ||
| 492 | 132 | provideAdapter( | 151 | provideAdapter( |
| 493 | 133 | InvolvedMenu, [IInvolved], INavigationMenu, name="overview") | 152 | InvolvedMenu, [IInvolved], INavigationMenu, name="overview") |
| 494 | 153 | |||
| 495 | 154 | |||
| 496 | 155 | # This class can't be moved into the browser/product.py file, since | ||
| 497 | 156 | # the pillar-views.txt test will fail due to the MenuAPI adapter | ||
| 498 | 157 | # for PillarView.enabled_links not working. | ||
| 499 | 158 | class ProductInvolvementView(PillarView): | ||
| 500 | 159 | """Encourage configuration of involvement links for projects.""" | ||
| 501 | 160 | |||
| 502 | 161 | has_involvement = True | ||
| 503 | 162 | visible_disabled_link_names = ['submit_code'] | ||
| 504 | 163 | |||
| 505 | 164 | @property | ||
| 506 | 165 | def configuration_links(self): | ||
| 507 | 166 | """The enabled involvement links.""" | ||
| 508 | 167 | overview_menu = MenuAPI(self.context).overview | ||
| 509 | 168 | series_menu = MenuAPI(self.context.development_focus).overview | ||
| 510 | 169 | configuration_names = [ | ||
| 511 | 170 | 'configure_answers', | ||
| 512 | 171 | 'configure_bugtracker', | ||
| 513 | 172 | 'configure_translations', | ||
| 514 | 173 | ] | ||
| 515 | 174 | configuration_links = [ | ||
| 516 | 175 | overview_menu[name] for name in configuration_names] | ||
| 517 | 176 | set_branch = series_menu['set_branch'] | ||
| 518 | 177 | set_branch.text = 'Configure project branch' | ||
| 519 | 178 | configuration_links.append(set_branch) | ||
| 520 | 179 | return sorted([ | ||
| 521 | 180 | link for link in configuration_links if link.enabled], | ||
| 522 | 181 | key=attrgetter('sort_key')) | ||
| 523 | 182 | |||
| 524 | 183 | |||
| 525 | 184 | class ProductSeriesInvolvementView(PillarView): | ||
| 526 | 185 | """Encourage configuration of involvement links for project series.""" | ||
| 527 | 186 | |||
| 528 | 187 | has_involvement = True | ||
| 529 | 188 | visible_disabled_link_names = ['submit_code'] | ||
| 530 | 189 | |||
| 531 | 190 | def __init__(self, context, request): | ||
| 532 | 191 | super(ProductSeriesInvolvementView, self).__init__(context, request) | ||
| 533 | 192 | self.official_codehosting = self.context.branch is not None | ||
| 534 | 193 | self.official_answers = False | ||
| 535 | 194 | |||
| 536 | 195 | @property | ||
| 537 | 196 | def configuration_links(self): | ||
| 538 | 197 | """The enabled involvement links.""" | ||
| 539 | 198 | series_menu = MenuAPI(self.context).overview | ||
| 540 | 199 | set_branch = series_menu['set_branch'] | ||
| 541 | 200 | set_branch.text = 'Configure series branch' | ||
| 542 | 201 | return [set_branch] | ||
| 543 | 134 | 202 | ||
| 544 | === modified file 'lib/lp/registry/browser/product.py' | |||
| 545 | --- lib/lp/registry/browser/product.py 2010-04-06 20:25:12 +0000 | |||
| 546 | +++ lib/lp/registry/browser/product.py 2010-04-09 18:48:33 +0000 | |||
| 547 | @@ -12,11 +12,17 @@ | |||
| 548 | 12 | 'ProductAdminView', | 12 | 'ProductAdminView', |
| 549 | 13 | 'ProductBrandingView', | 13 | 'ProductBrandingView', |
| 550 | 14 | 'ProductBugsMenu', | 14 | 'ProductBugsMenu', |
| 551 | 15 | 'ProductConfigureAnswersView', | ||
| 552 | 16 | 'ProductConfigureBlueprintsView', | ||
| 553 | 17 | 'ProductConfigureBranchesView', | ||
| 554 | 18 | 'ProductConfigureBugTrackerView', | ||
| 555 | 19 | 'ProductConfigureTranslationsView', | ||
| 556 | 15 | 'ProductDownloadFileMixin', | 20 | 'ProductDownloadFileMixin', |
| 557 | 16 | 'ProductDownloadFilesView', | 21 | 'ProductDownloadFilesView', |
| 558 | 17 | 'ProductEditPeopleView', | 22 | 'ProductEditPeopleView', |
| 559 | 18 | 'ProductEditView', | 23 | 'ProductEditView', |
| 560 | 19 | 'ProductFacets', | 24 | 'ProductFacets', |
| 561 | 25 | 'ProductInvolvementView', | ||
| 562 | 20 | 'ProductNavigation', | 26 | 'ProductNavigation', |
| 563 | 21 | 'ProductNavigationMenu', | 27 | 'ProductNavigationMenu', |
| 564 | 22 | 'ProductOverviewMenu', | 28 | 'ProductOverviewMenu', |
| 565 | @@ -331,6 +337,30 @@ | |||
| 566 | 331 | return Link('+edit', text, icon='edit') | 337 | return Link('+edit', text, icon='edit') |
| 567 | 332 | 338 | ||
| 568 | 333 | @enabled_with_permission('launchpad.Edit') | 339 | @enabled_with_permission('launchpad.Edit') |
| 569 | 340 | def configure_bugtracker(self): | ||
| 570 | 341 | text = 'Configure bug tracker' | ||
| 571 | 342 | summary = 'Specify where bugs are tracked for this project' | ||
| 572 | 343 | return Link('+configure-bugtracker', text, summary, icon='edit') | ||
| 573 | 344 | |||
| 574 | 345 | @enabled_with_permission('launchpad.Edit') | ||
| 575 | 346 | def configure_translations(self): | ||
| 576 | 347 | text = 'Configure translations' | ||
| 577 | 348 | summary = 'Allow users to submit translations for this project' | ||
| 578 | 349 | return Link('+configure-translations', text, summary, icon='edit') | ||
| 579 | 350 | |||
| 580 | 351 | @enabled_with_permission('launchpad.Edit') | ||
| 581 | 352 | def configure_answers(self): | ||
| 582 | 353 | text = 'Configure support tracker' | ||
| 583 | 354 | summary = 'Allow users to ask questions on this project' | ||
| 584 | 355 | return Link('+configure-answers', text, summary, icon='edit') | ||
| 585 | 356 | |||
| 586 | 357 | @enabled_with_permission('launchpad.Edit') | ||
| 587 | 358 | def configure_blueprints(self): | ||
| 588 | 359 | text = 'Configure blueprints' | ||
| 589 | 360 | summary = 'Enable tracking of specifications and meetings' | ||
| 590 | 361 | return Link('+configure-blueprints', text, summary, icon='edit') | ||
| 591 | 362 | |||
| 592 | 363 | @enabled_with_permission('launchpad.Edit') | ||
| 593 | 334 | def branding(self): | 364 | def branding(self): |
| 594 | 335 | text = 'Change branding' | 365 | text = 'Change branding' |
| 595 | 336 | return Link('+branding', text, icon='edit') | 366 | return Link('+branding', text, icon='edit') |
| 596 | @@ -374,6 +404,10 @@ | |||
| 597 | 374 | facet = 'overview' | 404 | facet = 'overview' |
| 598 | 375 | links = [ | 405 | links = [ |
| 599 | 376 | 'edit', | 406 | 'edit', |
| 600 | 407 | 'configure_answers', | ||
| 601 | 408 | 'configure_blueprints', | ||
| 602 | 409 | 'configure_bugtracker', | ||
| 603 | 410 | 'configure_translations', | ||
| 604 | 377 | 'reassign', | 411 | 'reassign', |
| 605 | 378 | 'top_contributors', | 412 | 'top_contributors', |
| 606 | 379 | 'distributions', | 413 | 'distributions', |
| 607 | @@ -473,11 +507,12 @@ | |||
| 608 | 473 | return Link('+securitycontact', text, icon='edit') | 507 | return Link('+securitycontact', text, icon='edit') |
| 609 | 474 | 508 | ||
| 610 | 475 | 509 | ||
| 612 | 476 | class ProductSpecificationsMenu(NavigationMenu, | 510 | class ProductSpecificationsMenu(NavigationMenu, ProductEditLinksMixin, |
| 613 | 477 | HasSpecificationsMenuMixin): | 511 | HasSpecificationsMenuMixin): |
| 614 | 478 | usedfor = IProduct | 512 | usedfor = IProduct |
| 615 | 479 | facet = 'specifications' | 513 | facet = 'specifications' |
| 617 | 480 | links = ['listall', 'doc', 'assignments', 'new', 'register_sprint'] | 514 | links = ['configure_blueprints', 'listall', 'doc', 'assignments', 'new', |
| 618 | 515 | 'register_sprint'] | ||
| 619 | 481 | 516 | ||
| 620 | 482 | 517 | ||
| 621 | 483 | def _cmp_distros(a, b): | 518 | def _cmp_distros(a, b): |
| 622 | @@ -1145,6 +1180,70 @@ | |||
| 623 | 1145 | return canonical_url(self.context) | 1180 | return canonical_url(self.context) |
| 624 | 1146 | 1181 | ||
| 625 | 1147 | 1182 | ||
| 626 | 1183 | class ProductConfigureBase(ReturnToReferrerMixin, LaunchpadEditFormView): | ||
| 627 | 1184 | implements(IProductEditMenu) | ||
| 628 | 1185 | schema = IProduct | ||
| 629 | 1186 | |||
| 630 | 1187 | @property | ||
| 631 | 1188 | def page_title(self): | ||
| 632 | 1189 | return self.label | ||
| 633 | 1190 | |||
| 634 | 1191 | @action("Change", name='change') | ||
| 635 | 1192 | def change_action(self, action, data): | ||
| 636 | 1193 | self.updateContextFromData(data) | ||
| 637 | 1194 | |||
| 638 | 1195 | |||
| 639 | 1196 | class ProductConfigureBugTrackerView(ProductConfigureBase): | ||
| 640 | 1197 | """View class to configure the bug tracker for a project.""" | ||
| 641 | 1198 | |||
| 642 | 1199 | label = "Configure bug tracker" | ||
| 643 | 1200 | field_names = [ | ||
| 644 | 1201 | "bugtracker", | ||
| 645 | 1202 | "enable_bug_expiration", | ||
| 646 | 1203 | "remote_product", | ||
| 647 | 1204 | "bug_reporting_guidelines", | ||
| 648 | 1205 | ] | ||
| 649 | 1206 | custom_widget('bugtracker', ProductBugTrackerWidget) | ||
| 650 | 1207 | |||
| 651 | 1208 | def validate(self, data): | ||
| 652 | 1209 | """Constrain bug expiration to Launchpad Bugs tracker.""" | ||
| 653 | 1210 | # enable_bug_expiration is disabled by JavaScript when bugtracker | ||
| 654 | 1211 | # is not 'In Launchpad'. The constraint is enforced here in case the | ||
| 655 | 1212 | # JavaScript fails to activate or run. Note that the bugtracker | ||
| 656 | 1213 | # name : values are {'In Launchpad' : object, 'Somewhere else' : None | ||
| 657 | 1214 | # 'In a registered bug tracker' : IBugTracker}. | ||
| 658 | 1215 | bugtracker = data.get('bugtracker', None) | ||
| 659 | 1216 | if bugtracker is None or IBugTracker.providedBy(bugtracker): | ||
| 660 | 1217 | data['enable_bug_expiration'] = False | ||
| 661 | 1218 | |||
| 662 | 1219 | |||
| 663 | 1220 | class ProductConfigureBlueprintsView(ProductConfigureBase): | ||
| 664 | 1221 | """View class to configure the Launchpad Blueprints for a project.""" | ||
| 665 | 1222 | |||
| 666 | 1223 | label = "Configure Blueprints" | ||
| 667 | 1224 | field_names = [ | ||
| 668 | 1225 | "official_blueprints", | ||
| 669 | 1226 | ] | ||
| 670 | 1227 | |||
| 671 | 1228 | |||
| 672 | 1229 | class ProductConfigureTranslationsView(ProductConfigureBase): | ||
| 673 | 1230 | """View class to configure the Launchpad Translations for a project.""" | ||
| 674 | 1231 | |||
| 675 | 1232 | label = "Configure Translations" | ||
| 676 | 1233 | field_names = [ | ||
| 677 | 1234 | "official_rosetta", | ||
| 678 | 1235 | ] | ||
| 679 | 1236 | |||
| 680 | 1237 | |||
| 681 | 1238 | class ProductConfigureAnswersView(ProductConfigureBase): | ||
| 682 | 1239 | """View class to configure the Launchpad Answers for a project.""" | ||
| 683 | 1240 | |||
| 684 | 1241 | label = "Configure Answers" | ||
| 685 | 1242 | field_names = [ | ||
| 686 | 1243 | "official_answers", | ||
| 687 | 1244 | ] | ||
| 688 | 1245 | |||
| 689 | 1246 | |||
| 690 | 1148 | class ProductEditView(ProductLicenseMixin, LaunchpadEditFormView): | 1247 | class ProductEditView(ProductLicenseMixin, LaunchpadEditFormView): |
| 691 | 1149 | """View class that lets you edit a Product object.""" | 1248 | """View class that lets you edit a Product object.""" |
| 692 | 1150 | 1249 | ||
| 693 | @@ -1157,15 +1256,7 @@ | |||
| 694 | 1157 | "title", | 1256 | "title", |
| 695 | 1158 | "summary", | 1257 | "summary", |
| 696 | 1159 | "description", | 1258 | "description", |
| 697 | 1160 | "bug_reporting_guidelines", | ||
| 698 | 1161 | "project", | 1259 | "project", |
| 699 | 1162 | "official_codehosting", | ||
| 700 | 1163 | "bugtracker", | ||
| 701 | 1164 | "enable_bug_expiration", | ||
| 702 | 1165 | "official_blueprints", | ||
| 703 | 1166 | "official_rosetta", | ||
| 704 | 1167 | "official_answers", | ||
| 705 | 1168 | "remote_product", | ||
| 706 | 1169 | "homepageurl", | 1260 | "homepageurl", |
| 707 | 1170 | "sourceforgeproject", | 1261 | "sourceforgeproject", |
| 708 | 1171 | "freshmeatproject", | 1262 | "freshmeatproject", |
| 709 | @@ -1178,7 +1269,6 @@ | |||
| 710 | 1178 | "license_info", | 1269 | "license_info", |
| 711 | 1179 | ] | 1270 | ] |
| 712 | 1180 | custom_widget('licenses', LicenseWidget) | 1271 | custom_widget('licenses', LicenseWidget) |
| 713 | 1181 | custom_widget('bugtracker', ProductBugTrackerWidget) | ||
| 714 | 1182 | custom_widget('license_info', GhostWidget) | 1272 | custom_widget('license_info', GhostWidget) |
| 715 | 1183 | 1273 | ||
| 716 | 1184 | @property | 1274 | @property |
| 717 | @@ -1206,18 +1296,6 @@ | |||
| 718 | 1206 | return False | 1296 | return False |
| 719 | 1207 | return super(ProductEditView, self).showOptionalMarker(field_name) | 1297 | return super(ProductEditView, self).showOptionalMarker(field_name) |
| 720 | 1208 | 1298 | ||
| 721 | 1209 | def validate(self, data): | ||
| 722 | 1210 | """Constrain bug expiration to Launchpad Bugs tracker.""" | ||
| 723 | 1211 | # enable_bug_expiration is disabled by JavaScript when bugtracker | ||
| 724 | 1212 | # is not 'In Launchpad'. The contraint is enforced here in case the | ||
| 725 | 1213 | # JavaScript fails to activate or run. Note that the bugtracker | ||
| 726 | 1214 | # name : values are {'In Launchpad' : object, 'Somewhere else' : None | ||
| 727 | 1215 | # 'In a registered bug tracker' : IBugTracker}. | ||
| 728 | 1216 | bugtracker = data.get('bugtracker', None) | ||
| 729 | 1217 | if bugtracker is None or IBugTracker.providedBy(bugtracker): | ||
| 730 | 1218 | data['enable_bug_expiration'] = False | ||
| 731 | 1219 | ProductLicenseMixin.validate(self, data) | ||
| 732 | 1220 | |||
| 733 | 1221 | @action("Change", name='change') | 1299 | @action("Change", name='change') |
| 734 | 1222 | def change_action(self, action, data): | 1300 | def change_action(self, action, data): |
| 735 | 1223 | previous_licenses = self.context.licenses | 1301 | previous_licenses = self.context.licenses |
| 736 | 1224 | 1302 | ||
| 737 | === modified file 'lib/lp/registry/browser/productseries.py' | |||
| 738 | --- lib/lp/registry/browser/productseries.py 2010-04-08 19:04:48 +0000 | |||
| 739 | +++ lib/lp/registry/browser/productseries.py 2010-04-09 18:48:33 +0000 | |||
| 740 | @@ -81,7 +81,8 @@ | |||
| 741 | 81 | from canonical.launchpad.webapp.interfaces import ( | 81 | from canonical.launchpad.webapp.interfaces import ( |
| 742 | 82 | NotFoundError, UnexpectedFormData) | 82 | NotFoundError, UnexpectedFormData) |
| 743 | 83 | from canonical.launchpad.webapp.launchpadform import ( | 83 | from canonical.launchpad.webapp.launchpadform import ( |
| 745 | 84 | action, custom_widget, LaunchpadEditFormView, LaunchpadFormView) | 84 | action, custom_widget, LaunchpadEditFormView, LaunchpadFormView, |
| 746 | 85 | ReturnToReferrerMixin) | ||
| 747 | 85 | from canonical.launchpad.webapp.menu import structured | 86 | from canonical.launchpad.webapp.menu import structured |
| 748 | 86 | from canonical.widgets.itemswidgets import LaunchpadRadioWidget | 87 | from canonical.widgets.itemswidgets import LaunchpadRadioWidget |
| 749 | 87 | from canonical.widgets.textwidgets import StrippedTextWidget | 88 | from canonical.widgets.textwidgets import StrippedTextWidget |
| 750 | @@ -175,6 +176,7 @@ | |||
| 751 | 175 | links = [ | 176 | links = [ |
| 752 | 176 | 'edit', 'delete', 'driver', 'link_branch', 'branch_add', 'ubuntupkg', | 177 | 'edit', 'delete', 'driver', 'link_branch', 'branch_add', 'ubuntupkg', |
| 753 | 177 | 'create_milestone', 'create_release', 'rdf', 'subscribe', | 178 | 'create_milestone', 'create_release', 'rdf', 'subscribe', |
| 754 | 179 | 'set_branch', | ||
| 755 | 178 | ] | 180 | ] |
| 756 | 179 | 181 | ||
| 757 | 180 | @enabled_with_permission('launchpad.Edit') | 182 | @enabled_with_permission('launchpad.Edit') |
| 758 | @@ -211,6 +213,21 @@ | |||
| 759 | 211 | summary = 'Change the branch for this series' | 213 | summary = 'Change the branch for this series' |
| 760 | 212 | return Link('+linkbranch', text, summary, icon=icon) | 214 | return Link('+linkbranch', text, summary, icon=icon) |
| 761 | 213 | 215 | ||
| 762 | 216 | @enabled_with_permission('launchpad.Edit') | ||
| 763 | 217 | def set_branch(self): | ||
| 764 | 218 | """Return a link to set the bazaar branch for this series.""" | ||
| 765 | 219 | # Once +setbranch has been beta tested thoroughly, it should | ||
| 766 | 220 | # replace the +linkbranch page. | ||
| 767 | 221 | if self.context.branch is None: | ||
| 768 | 222 | text = 'Link to branch' | ||
| 769 | 223 | icon = 'add' | ||
| 770 | 224 | summary = 'Set the branch for this series' | ||
| 771 | 225 | else: | ||
| 772 | 226 | text = "Change branch" | ||
| 773 | 227 | icon = 'edit' | ||
| 774 | 228 | summary = 'Change the branch for this series' | ||
| 775 | 229 | return Link('+setbranch', text, summary, icon=icon) | ||
| 776 | 230 | |||
| 777 | 214 | def branch_add(self): | 231 | def branch_add(self): |
| 778 | 215 | text = 'Register a branch' | 232 | text = 'Register a branch' |
| 779 | 216 | summary = "Register a new Bazaar branch for this series' project" | 233 | summary = "Register a new Bazaar branch for this series' project" |
| 780 | @@ -734,7 +751,8 @@ | |||
| 781 | 734 | ) | 751 | ) |
| 782 | 735 | 752 | ||
| 783 | 736 | 753 | ||
| 785 | 737 | class ProductSeriesSetBranchView(LaunchpadFormView, ProductSeriesView, | 754 | class ProductSeriesSetBranchView(ReturnToReferrerMixin, LaunchpadFormView, |
| 786 | 755 | ProductSeriesView, | ||
| 787 | 738 | BranchNameValidationMixin): | 756 | BranchNameValidationMixin): |
| 788 | 739 | """The view to set a branch for the ProductSeries.""" | 757 | """The view to set a branch for the ProductSeries.""" |
| 789 | 740 | 758 | ||
| 790 | @@ -919,7 +937,6 @@ | |||
| 791 | 919 | 937 | ||
| 792 | 920 | @action(_('Update'), name='update') | 938 | @action(_('Update'), name='update') |
| 793 | 921 | def update_action(self, action, data): | 939 | def update_action(self, action, data): |
| 794 | 922 | self.next_url = canonical_url(self.context) | ||
| 795 | 923 | branch_type = data.get('branch_type') | 940 | branch_type = data.get('branch_type') |
| 796 | 924 | if branch_type == LINK_LP_BZR: | 941 | if branch_type == LINK_LP_BZR: |
| 797 | 925 | branch_location = data.get('branch_location') | 942 | branch_location = data.get('branch_location') |
| 798 | @@ -1011,13 +1028,10 @@ | |||
| 799 | 1011 | self._setBranchExists(e.existing_branch, 'branch_name') | 1028 | self._setBranchExists(e.existing_branch, 'branch_name') |
| 800 | 1012 | return branch | 1029 | return branch |
| 801 | 1013 | 1030 | ||
| 809 | 1014 | @property | 1031 | |
| 810 | 1015 | def cancel_url(self): | 1032 | class ProductSeriesLinkBranchView(ReturnToReferrerMixin, |
| 811 | 1016 | """See `LaunchpadFormView`.""" | 1033 | ProductSeriesView, |
| 812 | 1017 | return canonical_url(self.context) | 1034 | LaunchpadEditFormView): |
| 806 | 1018 | |||
| 807 | 1019 | |||
| 808 | 1020 | class ProductSeriesLinkBranchView(LaunchpadEditFormView, ProductSeriesView): | ||
| 813 | 1021 | """View to set the bazaar branch for a product series.""" | 1035 | """View to set the bazaar branch for a product series.""" |
| 814 | 1022 | 1036 | ||
| 815 | 1023 | schema = IProductSeries | 1037 | schema = IProductSeries |
| 816 | @@ -1034,11 +1048,6 @@ | |||
| 817 | 1034 | """The page title.""" | 1048 | """The page title.""" |
| 818 | 1035 | return self.label | 1049 | return self.label |
| 819 | 1036 | 1050 | ||
| 820 | 1037 | @property | ||
| 821 | 1038 | def next_url(self): | ||
| 822 | 1039 | """See `LaunchpadFormView`.""" | ||
| 823 | 1040 | return canonical_url(self.context) | ||
| 824 | 1041 | |||
| 825 | 1042 | @action(_('Update'), name='update') | 1051 | @action(_('Update'), name='update') |
| 826 | 1043 | def update_action(self, action, data): | 1052 | def update_action(self, action, data): |
| 827 | 1044 | """Update the branch attribute.""" | 1053 | """Update the branch attribute.""" |
| 828 | @@ -1052,11 +1061,6 @@ | |||
| 829 | 1052 | self.request.response.addInfoNotification( | 1061 | self.request.response.addInfoNotification( |
| 830 | 1053 | 'Series code location updated.') | 1062 | 'Series code location updated.') |
| 831 | 1054 | 1063 | ||
| 832 | 1055 | @property | ||
| 833 | 1056 | def cancel_url(self): | ||
| 834 | 1057 | """See `LaunchpadFormView`.""" | ||
| 835 | 1058 | return canonical_url(self.context) | ||
| 836 | 1059 | |||
| 837 | 1060 | 1064 | ||
| 838 | 1061 | class ProductSeriesLinkBranchFromCodeView(ProductSeriesLinkBranchView): | 1065 | class ProductSeriesLinkBranchFromCodeView(ProductSeriesLinkBranchView): |
| 839 | 1062 | """Set the branch link from the code overview page.""" | 1066 | """Set the branch link from the code overview page.""" |
| 840 | 1063 | 1067 | ||
| 841 | === modified file 'lib/lp/registry/browser/tests/pillar-views.txt' | |||
| 842 | --- lib/lp/registry/browser/tests/pillar-views.txt 2009-09-03 19:26:16 +0000 | |||
| 843 | +++ lib/lp/registry/browser/tests/pillar-views.txt 2010-04-09 18:48:33 +0000 | |||
| 844 | @@ -49,19 +49,19 @@ | |||
| 845 | 49 | report_bug ask_question | 49 | report_bug ask_question |
| 846 | 50 | 50 | ||
| 847 | 51 | >>> print view.render() | 51 | >>> print view.render() |
| 849 | 52 | <div id="involvement" class="portlet involvement"> | 52 | <div id="involvement" class="portlet"> |
| 850 | 53 | <h2>Get Involved</h2> | 53 | <h2>Get Involved</h2> |
| 852 | 54 | <ul> | 54 | <ul class="involvement"> |
| 853 | 55 | <li> | 55 | <li> |
| 855 | 56 | <a href="..." class="...bugs">Report a bug</a> | 56 | <a href=... class="...bugs">Report a bug</a> |
| 856 | 57 | </li> | 57 | </li> |
| 857 | 58 | <li> | 58 | <li> |
| 859 | 59 | <a href="..." class="...answers">Ask a question</a> | 59 | <a href=... class="...answers">Ask a question</a> |
| 860 | 60 | </li> | 60 | </li> |
| 861 | 61 | </ul> | 61 | </ul> |
| 863 | 62 | </div> | 62 | ... |
| 864 | 63 | 63 | ||
| 866 | 64 | Products are are supported. | 64 | Products are supported. |
| 867 | 65 | 65 | ||
| 868 | 66 | >>> product = factory.makeProduct(name='bread') | 66 | >>> product = factory.makeProduct(name='bread') |
| 869 | 67 | >>> login_person(product.owner) | 67 | >>> login_person(product.owner) |
| 870 | @@ -69,6 +69,24 @@ | |||
| 871 | 69 | >>> view = create_view(product, '+get-involved') | 69 | >>> view = create_view(product, '+get-involved') |
| 872 | 70 | >>> view.official_blueprints | 70 | >>> view.official_blueprints |
| 873 | 71 | True | 71 | True |
| 874 | 72 | >>> for link in view.enabled_links: | ||
| 875 | 73 | ... print link.name | ||
| 876 | 74 | register_blueprint | ||
| 877 | 75 | |||
| 878 | 76 | Products subclass the view to display disabled links to encourage | ||
| 879 | 77 | configuring that service in Launchpad for the project. The project | ||
| 880 | 78 | also has configuration links that make it easy to figure out where | ||
| 881 | 79 | to configure each service. | ||
| 882 | 80 | |||
| 883 | 81 | >>> for link in view.visible_disabled_links: | ||
| 884 | 82 | ... print link.name | ||
| 885 | 83 | submit_code | ||
| 886 | 84 | >>> for link in view.configuration_links: | ||
| 887 | 85 | ... print link.name | ||
| 888 | 86 | configure_answers | ||
| 889 | 87 | configure_bugtracker | ||
| 890 | 88 | configure_translations | ||
| 891 | 89 | set_branch | ||
| 892 | 72 | 90 | ||
| 893 | 73 | Project are supported too, but they only display the applications used by | 91 | Project are supported too, but they only display the applications used by |
| 894 | 74 | their products. | 92 | their products. |
| 895 | @@ -80,13 +98,27 @@ | |||
| 896 | 80 | >>> view.official_blueprints | 98 | >>> view.official_blueprints |
| 897 | 81 | True | 99 | True |
| 898 | 82 | 100 | ||
| 906 | 83 | Projects cannot make links to register a branch, so official_code is always | 101 | The offical_codehosting for a project is based on whether the project's |
| 907 | 84 | false. | 102 | development focus series has a branch. |
| 908 | 85 | 103 | ||
| 909 | 86 | >>> product.official_codehosting = True | 104 | >>> print product.development_focus.branch |
| 910 | 87 | >>> view = create_view(product, '+get-involved') | 105 | None |
| 911 | 88 | >>> view.official_codehosting | 106 | >>> product.official_codehosting |
| 912 | 89 | True | 107 | False |
| 913 | 108 | >>> view = create_view(product, '+get-involved') | ||
| 914 | 109 | >>> view.official_codehosting | ||
| 915 | 110 | False | ||
| 916 | 111 | |||
| 917 | 112 | >>> product.development_focus.branch = factory.makeBranch( | ||
| 918 | 113 | ... product=product) | ||
| 919 | 114 | >>> product.official_codehosting | ||
| 920 | 115 | True | ||
| 921 | 116 | >>> view = create_view(product, '+get-involved') | ||
| 922 | 117 | >>> view.official_codehosting | ||
| 923 | 118 | True | ||
| 924 | 119 | |||
| 925 | 120 | Project groups cannot make links to register a branch, so | ||
| 926 | 121 | official_codehosting is always false. | ||
| 927 | 90 | 122 | ||
| 928 | 91 | >>> view = create_view(project_group, '+get-involved') | 123 | >>> view = create_view(project_group, '+get-involved') |
| 929 | 92 | >>> view.official_codehosting | 124 | >>> view.official_codehosting |
| 930 | @@ -108,7 +140,7 @@ | |||
| 931 | 108 | >>> view = create_view(series, '+get-involved') | 140 | >>> view = create_view(series, '+get-involved') |
| 932 | 109 | >>> for link in view.enabled_links: | 141 | >>> for link in view.enabled_links: |
| 933 | 110 | ... print link.name | 142 | ... print link.name |
| 935 | 111 | submit_code register_blueprint | 143 | register_blueprint |
| 936 | 112 | 144 | ||
| 937 | 113 | DistributionSourcePackages can use this view. The distribution is used to | 145 | DistributionSourcePackages can use this view. The distribution is used to |
| 938 | 114 | set the links. Despite the fact that the distribution uses blueprints, | 146 | set the links. Despite the fact that the distribution uses blueprints, |
| 939 | 115 | 147 | ||
| 940 | === modified file 'lib/lp/registry/doc/product.txt' | |||
| 941 | --- lib/lp/registry/doc/product.txt 2009-12-13 11:55:40 +0000 | |||
| 942 | +++ lib/lp/registry/doc/product.txt 2010-04-09 18:48:33 +0000 | |||
| 943 | @@ -455,12 +455,15 @@ | |||
| 944 | 455 | 455 | ||
| 945 | 456 | == Products With Branches == | 456 | == Products With Branches == |
| 946 | 457 | 457 | ||
| 949 | 458 | Products can now specify whether they officially support Launchpad as a | 458 | Products are considered to officially support Launchpad as a location |
| 950 | 459 | location for their branches. | 459 | for their branches after a branch is set for the development focus |
| 951 | 460 | series. | ||
| 952 | 460 | 461 | ||
| 953 | 462 | >>> print firefox.development_focus.branch | ||
| 954 | 463 | None | ||
| 955 | 461 | >>> print firefox.official_codehosting | 464 | >>> print firefox.official_codehosting |
| 956 | 462 | False | 465 | False |
| 958 | 463 | >>> firefox.official_codehosting = True | 466 | >>> firefox.development_focus.branch = factory.makeBranch(product=firefox) |
| 959 | 464 | >>> print firefox.official_codehosting | 467 | >>> print firefox.official_codehosting |
| 960 | 465 | True | 468 | True |
| 961 | 466 | 469 | ||
| 962 | 467 | 470 | ||
| 963 | === modified file 'lib/lp/registry/model/product.py' | |||
| 964 | --- lib/lp/registry/model/product.py 2010-04-08 19:27:14 +0000 | |||
| 965 | +++ lib/lp/registry/model/product.py 2010-04-09 18:48:33 +0000 | |||
| 966 | @@ -246,8 +246,6 @@ | |||
| 967 | 246 | dbName='official_answers', notNull=True, default=False) | 246 | dbName='official_answers', notNull=True, default=False) |
| 968 | 247 | official_blueprints = BoolCol( | 247 | official_blueprints = BoolCol( |
| 969 | 248 | dbName='official_blueprints', notNull=True, default=False) | 248 | dbName='official_blueprints', notNull=True, default=False) |
| 970 | 249 | official_codehosting = BoolCol( | ||
| 971 | 250 | dbName='official_codehosting', notNull=True, default=False) | ||
| 972 | 251 | official_malone = BoolCol( | 249 | official_malone = BoolCol( |
| 973 | 252 | dbName='official_malone', notNull=True, default=False) | 250 | dbName='official_malone', notNull=True, default=False) |
| 974 | 253 | official_rosetta = BoolCol( | 251 | official_rosetta = BoolCol( |
| 975 | @@ -256,6 +254,12 @@ | |||
| 976 | 256 | name='remote_product', allow_none=True, default=None) | 254 | name='remote_product', allow_none=True, default=None) |
| 977 | 257 | max_bug_heat = Int() | 255 | max_bug_heat = Int() |
| 978 | 258 | 256 | ||
| 979 | 257 | @property | ||
| 980 | 258 | def official_codehosting(self): | ||
| 981 | 259 | # XXX Need to remove official_codehosting column from Product | ||
| 982 | 260 | # table. | ||
| 983 | 261 | return self.development_focus.branch is not None | ||
| 984 | 262 | |||
| 985 | 259 | def _getMilestoneCondition(self): | 263 | def _getMilestoneCondition(self): |
| 986 | 260 | """See `HasMilestonesMixin`.""" | 264 | """See `HasMilestonesMixin`.""" |
| 987 | 261 | return (Milestone.product == self) | 265 | return (Milestone.product == self) |
| 988 | 262 | 266 | ||
| 989 | === modified file 'lib/lp/registry/stories/product/xx-product-development-focus.txt' | |||
| 990 | --- lib/lp/registry/stories/product/xx-product-development-focus.txt 2009-11-18 04:51:08 +0000 | |||
| 991 | +++ lib/lp/registry/stories/product/xx-product-development-focus.txt 2010-04-09 18:48:33 +0000 | |||
| 992 | @@ -32,6 +32,12 @@ | |||
| 993 | 32 | ... print content | 32 | ... print content |
| 994 | 33 | ... title = a.get('title', '') | 33 | ... title = a.get('title', '') |
| 995 | 34 | ... print "%s (%s)" % (title, a['href']) | 34 | ... print "%s (%s)" % (title, a['href']) |
| 996 | 35 | >>> def print_involvement_portlet(browser): | ||
| 997 | 36 | ... involvement = find_tag_by_id(browser.contents, 'involvement') | ||
| 998 | 37 | ... for a in involvement.findAll('a'): | ||
| 999 | 38 | ... for content in a.contents: | ||
| 1000 | 39 | ... print content | ||
| 1001 | 40 | ... print a['href'] | ||
| 1002 | 35 | 41 | ||
| 1003 | 36 | 42 | ||
| 1004 | 37 | Projects without development focus branches | 43 | Projects without development focus branches |
| 1005 | @@ -39,48 +45,59 @@ | |||
| 1006 | 39 | 45 | ||
| 1007 | 40 | If the project has not specified a development focus branch then the | 46 | If the project has not specified a development focus branch then the |
| 1008 | 41 | development focus section just contains a link to the development focus | 47 | development focus section just contains a link to the development focus |
| 1010 | 42 | series, and text telling the user that no branch has been specified. | 48 | series. |
| 1011 | 43 | 49 | ||
| 1012 | 44 | >>> anon_browser.open('http://launchpad.dev/fooix') | 50 | >>> anon_browser.open('http://launchpad.dev/fooix') |
| 1013 | 45 | >>> print_development_focus(anon_browser) | 51 | >>> print_development_focus(anon_browser) |
| 1014 | 46 | Development focus: | 52 | Development focus: |
| 1015 | 47 | trunk series | 53 | trunk series |
| 1016 | 48 | Development focus branch has not been specified | ||
| 1017 | 49 | Links: | 54 | Links: |
| 1018 | 50 | trunk series (/fooix/trunk) | 55 | trunk series (/fooix/trunk) |
| 1019 | 56 | >>> print_involvement_portlet(anon_browser) | ||
| 1020 | 51 | 57 | ||
| 1021 | 52 | 58 | ||
| 1022 | 53 | Setting the development focus branch | 59 | Setting the development focus branch |
| 1023 | 54 | ------------------------------------ | 60 | ------------------------------------ |
| 1024 | 55 | 61 | ||
| 1025 | 56 | If the user has rights to change the development focus or to specify the | 62 | If the user has rights to change the development focus or to specify the |
| 1027 | 57 | development focus branch, then these links are shown next to the text. | 63 | development focus branch, then these links are shown in the involvement |
| 1028 | 64 | portlet. | ||
| 1029 | 58 | 65 | ||
| 1030 | 59 | >>> owner_browser.open('http://launchpad.dev/fooix') | 66 | >>> owner_browser.open('http://launchpad.dev/fooix') |
| 1031 | 60 | >>> print_development_focus(owner_browser) | 67 | >>> print_development_focus(owner_browser) |
| 1032 | 61 | Development focus: | 68 | Development focus: |
| 1033 | 62 | trunk series Change details | 69 | trunk series Change details |
| 1034 | 63 | Development focus branch has not been specified Link to branch | ||
| 1035 | 64 | Links: | 70 | Links: |
| 1042 | 65 | trunk series (/fooix/trunk) | 71 | trunk series |
| 1043 | 66 | <span class="invisible-link">Change details</span> | 72 | (/fooix/trunk) |
| 1044 | 67 | (http://launchpad.dev/fooix/+edit) | 73 | <span class="invisible-link">Change details</span> |
| 1045 | 68 | <span class="invisible-link">Link to branch</span> | 74 | (http://launchpad.dev/fooix/+edit) |
| 1046 | 69 | Set the branch for this series | 75 | >>> print_involvement_portlet(owner_browser) |
| 1047 | 70 | (http://launchpad.dev/fooix/trunk/+linkbranch) | 76 | Configure support tracker |
| 1048 | 77 | http://launchpad.dev/fooix/+configure-answers | ||
| 1049 | 78 | Configure bug tracker | ||
| 1050 | 79 | http://launchpad.dev/fooix/+configure-bugtracker | ||
| 1051 | 80 | Configure translations | ||
| 1052 | 81 | http://launchpad.dev/fooix/+configure-translations | ||
| 1053 | 82 | Configure project branch | ||
| 1054 | 83 | http://launchpad.dev/fooix/trunk/+setbranch | ||
| 1055 | 71 | 84 | ||
| 1056 | 72 | The owner can specify the development focus branch from the overview page. | 85 | The owner can specify the development focus branch from the overview page. |
| 1057 | 73 | 86 | ||
| 1060 | 74 | >>> owner_browser.getLink(url='+linkbranch').click() | 87 | >>> owner_browser.getLink(url='+setbranch').click() |
| 1061 | 75 | >>> owner_browser.getControl('Branch').value = '~eric/fooix/trunk' | 88 | >>> owner_browser.getControl(name='field.branch_location').value = ( |
| 1062 | 89 | ... '~eric/fooix/trunk') | ||
| 1063 | 76 | >>> owner_browser.getControl('Update').click() | 90 | >>> owner_browser.getControl('Update').click() |
| 1064 | 77 | >>> print_feedback_messages(owner_browser.contents) | 91 | >>> print_feedback_messages(owner_browser.contents) |
| 1065 | 78 | Series code location updated. | 92 | Series code location updated. |
| 1066 | 79 | 93 | ||
| 1068 | 80 | The owner is taken back to the trunk series page. | 94 | The owner is taken back to the project page. |
| 1069 | 81 | 95 | ||
| 1072 | 82 | >>> print_tag_with_id(owner_browser.contents, 'branch-details') | 96 | >>> print_tag_with_id(owner_browser.contents, 'dev-focus') |
| 1073 | 83 | lp://dev/fooix - Eric Change branch | 97 | Development focus: |
| 1074 | 98 | trunk series Change details | ||
| 1075 | 99 | lp://dev/fooix Change branch | ||
| 1076 | 100 | View the branch content | ||
| 1077 | 84 | 101 | ||
| 1078 | 85 | 102 | ||
| 1079 | 86 | Projects with development focus branches | 103 | Projects with development focus branches |
| 1080 | @@ -137,7 +154,6 @@ | |||
| 1081 | 137 | >>> print_development_focus(anon_browser) | 154 | >>> print_development_focus(anon_browser) |
| 1082 | 138 | Development focus: | 155 | Development focus: |
| 1083 | 139 | trunk series | 156 | trunk series |
| 1084 | 140 | Development focus branch has not been specified | ||
| 1085 | 141 | Links: | 157 | Links: |
| 1086 | 142 | trunk series (/fooix/trunk) | 158 | trunk series (/fooix/trunk) |
| 1087 | 143 | 159 | ||
| 1088 | 144 | 160 | ||
| 1089 | === modified file 'lib/lp/registry/stories/product/xx-product-edit.txt' | |||
| 1090 | --- lib/lp/registry/stories/product/xx-product-edit.txt 2009-12-24 01:41:54 +0000 | |||
| 1091 | +++ lib/lp/registry/stories/product/xx-product-edit.txt 2010-04-09 18:48:33 +0000 | |||
| 1092 | @@ -387,10 +387,12 @@ | |||
| 1093 | 387 | The remote_product field - which stores a Product's ID on the remote bug | 387 | The remote_product field - which stores a Product's ID on the remote bug |
| 1094 | 388 | tracker - can be set from the +edit page, too. | 388 | tracker - can be set from the +edit page, too. |
| 1095 | 389 | 389 | ||
| 1097 | 390 | >>> user_browser.open('http://launchpad.dev/thunderbird/+edit') | 390 | >>> user_browser.open( |
| 1098 | 391 | ... 'http://launchpad.dev/thunderbird/+configure-bugtracker') | ||
| 1099 | 391 | >>> user_browser.getControl('Remote project').value = 'Thunderbird' | 392 | >>> user_browser.getControl('Remote project').value = 'Thunderbird' |
| 1100 | 392 | >>> user_browser.getControl('Change').click() | 393 | >>> user_browser.getControl('Change').click() |
| 1101 | 393 | 394 | ||
| 1103 | 394 | >>> user_browser.open('http://launchpad.dev/thunderbird/+edit') | 395 | >>> user_browser.open( |
| 1104 | 396 | ... 'http://launchpad.dev/thunderbird/+configure-bugtracker') | ||
| 1105 | 395 | >>> print user_browser.getControl('Remote project').value | 397 | >>> print user_browser.getControl('Remote project').value |
| 1106 | 396 | Thunderbird | 398 | Thunderbird |
| 1107 | 397 | 399 | ||
| 1108 | === modified file 'lib/lp/registry/stories/product/xx-product-launchpad-usage.txt' | |||
| 1109 | --- lib/lp/registry/stories/product/xx-product-launchpad-usage.txt 2010-01-20 23:10:13 +0000 | |||
| 1110 | +++ lib/lp/registry/stories/product/xx-product-launchpad-usage.txt 2010-04-09 18:48:33 +0000 | |||
| 1111 | @@ -28,20 +28,14 @@ | |||
| 1112 | 28 | >>> registrant_browser = setupBrowser( | 28 | >>> registrant_browser = setupBrowser( |
| 1113 | 29 | ... auth='Basic test@canonical.com:test') | 29 | ... auth='Basic test@canonical.com:test') |
| 1114 | 30 | >>> registrant_browser.open('http://launchpad.dev/firefox') | 30 | >>> registrant_browser.open('http://launchpad.dev/firefox') |
| 1116 | 31 | >>> registrant_browser.getLink('Change details').click() | 31 | >>> registrant_browser.getLink('Configure bug tracker').click() |
| 1117 | 32 | >>> registrant_browser.url | 32 | >>> registrant_browser.url |
| 1119 | 33 | 'http://launchpad.dev/firefox/+edit' | 33 | 'http://launchpad.dev/firefox/+configure-bugtracker' |
| 1120 | 34 | 34 | ||
| 1121 | 35 | Firefox is currently marked as using Bugs. Let's specify that it | 35 | Firefox is currently marked as using Bugs. Let's specify that it |
| 1122 | 36 | doesn't use any bug tracker at all. | 36 | doesn't use any bug tracker at all. |
| 1123 | 37 | 37 | ||
| 1124 | 38 | >>> registrant_browser.getControl( | 38 | >>> registrant_browser.getControl( |
| 1125 | 39 | ... 'Translations for this project are done in Launchpad').selected | ||
| 1126 | 40 | False | ||
| 1127 | 41 | >>> registrant_browser.getControl( | ||
| 1128 | 42 | ... 'People can ask questions in Launchpad Answers').selected | ||
| 1129 | 43 | True | ||
| 1130 | 44 | >>> registrant_browser.getControl( | ||
| 1131 | 45 | ... 'In Launchpad').selected | 39 | ... 'In Launchpad').selected |
| 1132 | 46 | True | 40 | True |
| 1133 | 47 | >>> registrant_browser.getControl( | 41 | >>> registrant_browser.getControl( |
| 1134 | @@ -49,12 +43,39 @@ | |||
| 1135 | 49 | ... 'become inactive').selected | 43 | ... 'become inactive').selected |
| 1136 | 50 | False | 44 | False |
| 1137 | 51 | >>> registrant_browser.getControl('Somewhere else').selected = True | 45 | >>> registrant_browser.getControl('Somewhere else').selected = True |
| 1138 | 46 | >>> registrant_browser.getControl('Change').click() | ||
| 1139 | 52 | 47 | ||
| 1140 | 53 | We'll also set it as officially using codehosting. | 48 | We'll also set it as officially using codehosting. |
| 1141 | 54 | 49 | ||
| 1145 | 55 | >>> registrant_browser.getControl( | 50 | >>> registrant_browser.getLink('Configure project branch').click() |
| 1146 | 56 | ... 'Code for this project is published in Bazaar branches on' | 51 | >>> registrant_browser.getControl(name='field.branch_location').value = ( |
| 1147 | 57 | ... ' Launchpad').selected = True | 52 | ... '~name12/firefox/main') |
| 1148 | 53 | >>> registrant_browser.getControl('Update').click() | ||
| 1149 | 54 | |||
| 1150 | 55 | Translations can be enabled. | ||
| 1151 | 56 | |||
| 1152 | 57 | >>> registrant_browser.open('http://launchpad.dev/firefox') | ||
| 1153 | 58 | >>> registrant_browser.getLink('Configure translations').click() | ||
| 1154 | 59 | >>> registrant_browser.url | ||
| 1155 | 60 | 'http://launchpad.dev/firefox/+configure-translations' | ||
| 1156 | 61 | >>> control = registrant_browser.getControl( | ||
| 1157 | 62 | ... 'Translations for this project are done in Launchpad') | ||
| 1158 | 63 | >>> control.selected | ||
| 1159 | 64 | False | ||
| 1160 | 65 | >>> control.selected = True | ||
| 1161 | 66 | >>> registrant_browser.getControl('Change').click() | ||
| 1162 | 67 | |||
| 1163 | 68 | Answers can be disabled. | ||
| 1164 | 69 | |||
| 1165 | 70 | >>> registrant_browser.open('http://launchpad.dev/firefox') | ||
| 1166 | 71 | >>> registrant_browser.getLink('Configure support tracker').click() | ||
| 1167 | 72 | >>> registrant_browser.url | ||
| 1168 | 73 | 'http://launchpad.dev/firefox/+configure-answers' | ||
| 1169 | 74 | >>> control = registrant_browser.getControl( | ||
| 1170 | 75 | ... 'People can ask questions in Launchpad Answers') | ||
| 1171 | 76 | >>> control.selected | ||
| 1172 | 77 | True | ||
| 1173 | 78 | >>> control.selected = False | ||
| 1174 | 58 | >>> registrant_browser.getControl('Change').click() | 79 | >>> registrant_browser.getControl('Change').click() |
| 1175 | 59 | 80 | ||
| 1176 | 60 | On the product page, we can see that the product doesn't use any bug | 81 | On the product page, we can see that the product doesn't use any bug |
| 1177 | @@ -62,7 +83,7 @@ | |||
| 1178 | 62 | 83 | ||
| 1179 | 63 | >>> uses = find_tag_by_id(registrant_browser.contents, id='uses') | 84 | >>> uses = find_tag_by_id(registrant_browser.contents, id='uses') |
| 1180 | 64 | >>> print extract_text(uses) | 85 | >>> print extract_text(uses) |
| 1182 | 65 | Uses Launchpad for: Answers and Branches. | 86 | Uses Launchpad for: Branches and Translations. |
| 1183 | 66 | 87 | ||
| 1184 | 67 | 88 | ||
| 1185 | 68 | Tracking bugs by email | 89 | Tracking bugs by email |
| 1186 | @@ -71,7 +92,8 @@ | |||
| 1187 | 71 | Instead if using a web-based bug tracker, projects can specify an | 92 | Instead if using a web-based bug tracker, projects can specify an |
| 1188 | 72 | email address where bug reports should be sent. | 93 | email address where bug reports should be sent. |
| 1189 | 73 | 94 | ||
| 1191 | 74 | >>> registrant_browser.open('http://launchpad.dev/firefox/+edit') | 95 | >>> registrant_browser.open( |
| 1192 | 96 | ... 'http://launchpad.dev/firefox/+configure-bugtracker') | ||
| 1193 | 75 | >>> registrant_browser.getControl( | 97 | >>> registrant_browser.getControl( |
| 1194 | 76 | ... 'By emailing an upstream bug contact').selected = True | 98 | ... 'By emailing an upstream bug contact').selected = True |
| 1195 | 77 | >>> registrant_browser.getControl( | 99 | >>> registrant_browser.getControl( |
| 1196 | @@ -90,14 +112,15 @@ | |||
| 1197 | 90 | 112 | ||
| 1198 | 91 | An error message is shown if the email address is not filled in. | 113 | An error message is shown if the email address is not filled in. |
| 1199 | 92 | 114 | ||
| 1201 | 93 | >>> registrant_browser.open('http://launchpad.dev/firefox/+edit') | 115 | >>> registrant_browser.open( |
| 1202 | 116 | ... 'http://launchpad.dev/firefox/+configure-bugtracker') | ||
| 1203 | 94 | >>> registrant_browser.getControl( | 117 | >>> registrant_browser.getControl( |
| 1204 | 95 | ... 'By emailing an upstream bug contact').selected = True | 118 | ... 'By emailing an upstream bug contact').selected = True |
| 1205 | 96 | >>> registrant_browser.getControl( | 119 | >>> registrant_browser.getControl( |
| 1206 | 97 | ... name='field.bugtracker.upstream_email_address').value = '' | 120 | ... name='field.bugtracker.upstream_email_address').value = '' |
| 1207 | 98 | >>> registrant_browser.getControl('Change').click() | 121 | >>> registrant_browser.getControl('Change').click() |
| 1208 | 99 | >>> registrant_browser.url | 122 | >>> registrant_browser.url |
| 1210 | 100 | 'http://launchpad.dev/firefox/+edit' | 123 | 'http://launchpad.dev/firefox/+configure-bugtracker' |
| 1211 | 101 | >>> for message in find_tags_by_class( | 124 | >>> for message in find_tags_by_class( |
| 1212 | 102 | ... registrant_browser.contents, 'message'): | 125 | ... registrant_browser.contents, 'message'): |
| 1213 | 103 | ... print extract_text(message) | 126 | ... print extract_text(message) |
| 1214 | @@ -124,7 +147,7 @@ | |||
| 1215 | 124 | >>> registrant_browser.title | 147 | >>> registrant_browser.title |
| 1216 | 125 | 'Jokosher Audio Editor in Launchpad' | 148 | 'Jokosher Audio Editor in Launchpad' |
| 1217 | 126 | 149 | ||
| 1219 | 127 | >>> registrant_browser.getLink('Change details').click() | 150 | >>> registrant_browser.getLink('Configure bug tracker').click() |
| 1220 | 128 | >>> registrant_browser.getControl('In Launchpad').selected | 151 | >>> registrant_browser.getControl('In Launchpad').selected |
| 1221 | 129 | True | 152 | True |
| 1222 | 130 | 153 | ||
| 1223 | @@ -145,7 +168,7 @@ | |||
| 1224 | 145 | Reviewing the edit page again, Dafydd, can see that bug expiration was | 168 | Reviewing the edit page again, Dafydd, can see that bug expiration was |
| 1225 | 146 | also disabled by the switch from Launchpad Bugs. | 169 | also disabled by the switch from Launchpad Bugs. |
| 1226 | 147 | 170 | ||
| 1228 | 148 | >>> registrant_browser.getLink('Change details').click() | 171 | >>> registrant_browser.getLink('Configure bug tracker').click() |
| 1229 | 149 | >>> registrant_browser.getControl('In Launchpad').selected | 172 | >>> registrant_browser.getControl('In Launchpad').selected |
| 1230 | 150 | False | 173 | False |
| 1231 | 151 | 174 | ||
| 1232 | 152 | 175 | ||
| 1233 | === modified file 'lib/lp/registry/templates/pillar-involvement-portlet.pt' | |||
| 1234 | --- lib/lp/registry/templates/pillar-involvement-portlet.pt 2009-08-15 05:35:13 +0000 | |||
| 1235 | +++ lib/lp/registry/templates/pillar-involvement-portlet.pt 2010-04-09 18:48:33 +0000 | |||
| 1236 | @@ -1,13 +1,40 @@ | |||
| 1237 | 1 | <div | 1 | <div |
| 1238 | 2 | xmlns:tal="http://xml.zope.org/namespaces/tal" | 2 | xmlns:tal="http://xml.zope.org/namespaces/tal" |
| 1239 | 3 | xmlns:i18n="http://xml.zope.org/namespaces/i18n" | 3 | xmlns:i18n="http://xml.zope.org/namespaces/i18n" |
| 1242 | 4 | id="involvement" class="portlet involvement" | 4 | id="involvement" class="portlet" |
| 1243 | 5 | tal:condition="view/has_involvement"> | 5 | tal:condition="view/has_involvement" |
| 1244 | 6 | > | ||
| 1245 | 6 | <h2>Get Involved</h2> | 7 | <h2>Get Involved</h2> |
| 1246 | 7 | 8 | ||
| 1248 | 8 | <ul> | 9 | <ul class="involvement"> |
| 1249 | 9 | <li tal:repeat="link view/enabled_links"> | 10 | <li tal:repeat="link view/enabled_links"> |
| 1250 | 10 | <a tal:replace="structure link/fmt:link" /> | 11 | <a tal:replace="structure link/fmt:link" /> |
| 1251 | 11 | </li> | 12 | </li> |
| 1252 | 13 | |||
| 1253 | 14 | <tal:disabled repeat="link view/visible_disabled_links"> | ||
| 1254 | 15 | <li tal:condition="not: link/enabled" | ||
| 1255 | 16 | tal:attributes="title string:Launchpad needs to know where the user can ${link/text/lower}" | ||
| 1256 | 17 | class="disabled"> | ||
| 1257 | 18 | <div style="padding: 0.3em 0 0.3em 0.3em"> | ||
| 1258 | 19 | <div style="display: inline-block" | ||
| 1259 | 20 | class="sprite icon-only warning-icon"></div> | ||
| 1260 | 21 | |||
| 1261 | 22 | <div style="height: 1.2em; float: right"> | ||
| 1262 | 23 | <img src="/@@/gray-arrow-right.png" | ||
| 1263 | 24 | style="top: 50%; bottom: 50%; margin-top: -5px; | ||
| 1264 | 25 | position: relative; | ||
| 1265 | 26 | height: 9px; width: 14px; padding: 0"/> | ||
| 1266 | 27 | </div> | ||
| 1267 | 28 | |||
| 1268 | 29 | <span tal:content="link/text"/> | ||
| 1269 | 30 | </div> | ||
| 1270 | 31 | </li> | ||
| 1271 | 32 | </tal:disabled> | ||
| 1272 | 33 | </ul> | ||
| 1273 | 34 | |||
| 1274 | 35 | <ul tal:condition="view/configuration_links" style="padding-top: 1em"> | ||
| 1275 | 36 | <li tal:repeat="link view/configuration_links"> | ||
| 1276 | 37 | <a tal:replace="structure link/fmt:link" /> | ||
| 1277 | 38 | </li> | ||
| 1278 | 12 | </ul> | 39 | </ul> |
| 1279 | 13 | </div> | 40 | </div> |
| 1280 | 14 | 41 | ||
| 1281 | === modified file 'lib/lp/registry/templates/product-index.pt' | |||
| 1282 | --- lib/lp/registry/templates/product-index.pt 2009-11-18 04:51:08 +0000 | |||
| 1283 | +++ lib/lp/registry/templates/product-index.pt 2010-04-09 18:48:33 +0000 | |||
| 1284 | @@ -116,10 +116,6 @@ | |||
| 1285 | 116 | <br/> | 116 | <br/> |
| 1286 | 117 | <a tal:replace="structure trunk/menu:context/source/fmt:link"/> | 117 | <a tal:replace="structure trunk/menu:context/source/fmt:link"/> |
| 1287 | 118 | </p> | 118 | </p> |
| 1288 | 119 | <p tal:condition="not: trunk_visible"> | ||
| 1289 | 120 | Development focus branch has not been specified | ||
| 1290 | 121 | <a tal:replace="structure dev_focus/menu:overview/link_branch/fmt:icon" /> | ||
| 1291 | 122 | </p> | ||
| 1292 | 123 | </dd> | 119 | </dd> |
| 1293 | 124 | </dl> | 120 | </dl> |
| 1294 | 125 | 121 | ||
| 1295 | 126 | 122 | ||
| 1296 | === modified file 'lib/lp/translations/stories/productseries/xx-productseries-translations.txt' | |||
| 1297 | --- lib/lp/translations/stories/productseries/xx-productseries-translations.txt 2010-01-29 16:16:19 +0000 | |||
| 1298 | +++ lib/lp/translations/stories/productseries/xx-productseries-translations.txt 2010-04-09 18:48:33 +0000 | |||
| 1299 | @@ -159,14 +159,14 @@ | |||
| 1300 | 159 | ... find_tag_by_id( | 159 | ... find_tag_by_id( |
| 1301 | 160 | ... owner_browser.contents, 'not-translated-in-launchpad')) | 160 | ... owner_browser.contents, 'not-translated-in-launchpad')) |
| 1302 | 161 | This project is not using Launchpad for translations. | 161 | This project is not using Launchpad for translations. |
| 1309 | 162 | You can change this in the project settings. (Getting | 162 | Configure translations |
| 1310 | 163 | started with translating your project in Launchpad) | 163 | Getting started with translating your project in Launchpad |
| 1311 | 164 | 164 | ||
| 1312 | 165 | The notice links to the project settings where the option can be set. | 165 | The notice links to the page for configuring translations on the project. |
| 1313 | 166 | 166 | ||
| 1314 | 167 | >>> owner_browser.getLink('project settings').click() | 167 | >>> owner_browser.getLink('Configure translations').click() |
| 1315 | 168 | >>> print owner_browser.url | 168 | >>> print owner_browser.url |
| 1317 | 169 | http://.../bazaar/+edit | 169 | http://.../bazaar/+configure-translations |
| 1318 | 170 | 170 | ||
| 1319 | 171 | An administrator also sees the notice. | 171 | An administrator also sees the notice. |
| 1320 | 172 | 172 | ||
| 1321 | @@ -177,8 +177,8 @@ | |||
| 1322 | 177 | ... find_tag_by_id( | 177 | ... find_tag_by_id( |
| 1323 | 178 | ... admin_browser.contents, 'not-translated-in-launchpad')) | 178 | ... admin_browser.contents, 'not-translated-in-launchpad')) |
| 1324 | 179 | This project is not using Launchpad for translations. | 179 | This project is not using Launchpad for translations. |
| 1327 | 180 | You can change this in the project settings. (Getting | 180 | Configure translations |
| 1328 | 181 | started with translating your project in Launchpad) | 181 | Getting started with translating your project in Launchpad |
| 1329 | 182 | 182 | ||
| 1330 | 183 | A Translations admin who is neither a Launchpad admin nor the project | 183 | A Translations admin who is neither a Launchpad admin nor the project |
| 1331 | 184 | owner (and so won't be able to change the project's settings) sees the | 184 | owner (and so won't be able to change the project's settings) sees the |
| 1332 | @@ -213,7 +213,7 @@ | |||
| 1333 | 213 | ... find_tag_by_id( | 213 | ... find_tag_by_id( |
| 1334 | 214 | ... jtv_browser.contents, 'not-translated-in-launchpad')) | 214 | ... jtv_browser.contents, 'not-translated-in-launchpad')) |
| 1335 | 215 | This project is not using Launchpad for translations. | 215 | This project is not using Launchpad for translations. |
| 1337 | 216 | (Getting started with translating your project in Launchpad) | 216 | Getting started with translating your project in Launchpad |
| 1338 | 217 | 217 | ||
| 1339 | 218 | 218 | ||
| 1340 | 219 | Branch synchronization options | 219 | Branch synchronization options |
| 1341 | 220 | 220 | ||
| 1342 | === modified file 'lib/lp/translations/stories/standalone/xx-product-translations.txt' | |||
| 1343 | --- lib/lp/translations/stories/standalone/xx-product-translations.txt 2010-01-15 14:00:30 +0000 | |||
| 1344 | +++ lib/lp/translations/stories/standalone/xx-product-translations.txt 2010-04-09 18:48:33 +0000 | |||
| 1345 | @@ -49,20 +49,21 @@ | |||
| 1346 | 49 | ... find_tag_by_id( | 49 | ... find_tag_by_id( |
| 1347 | 50 | ... registrant.contents, 'not-translated-in-launchpad')) | 50 | ... registrant.contents, 'not-translated-in-launchpad')) |
| 1348 | 51 | This project is not using Launchpad for translations. | 51 | This project is not using Launchpad for translations. |
| 1351 | 52 | You can change this in the project settings. (Getting | 52 | Configure translations |
| 1352 | 53 | started with translating your project in Launchpad) | 53 | Getting started with translating your project in Launchpad |
| 1353 | 54 | 54 | ||
| 1354 | 55 | >>> registrant.getLink( | 55 | >>> registrant.getLink( |
| 1355 | 56 | ... url=('/gnomebaker/trunk/' | 56 | ... url=('/gnomebaker/trunk/' |
| 1356 | 57 | ... '+translations-upload')) is not None | 57 | ... '+translations-upload')) is not None |
| 1357 | 58 | True | 58 | True |
| 1358 | 59 | 59 | ||
| 1361 | 60 | The instructions for the registrant link to the settings page, where they can | 60 | The instructions for the registrant link to the translations |
| 1362 | 61 | configure the project to use Launchpad for translations if desired. | 61 | configuration page, where they can configure the project to use |
| 1363 | 62 | Launchpad for translations if desired. | ||
| 1364 | 62 | 63 | ||
| 1366 | 63 | >>> registrant.getLink('project settings').click() | 64 | >>> registrant.getLink('Configure translations').click() |
| 1367 | 64 | >>> print registrant.url | 65 | >>> print registrant.url |
| 1369 | 65 | http://.../gnomebaker/+edit | 66 | http://.../gnomebaker/+configure-translations |
| 1370 | 66 | 67 | ||
| 1371 | 67 | (The template upload process is tested in xx-translation-import-queue.txt.) | 68 | (The template upload process is tested in xx-translation-import-queue.txt.) |
| 1372 | 68 | 69 | ||
| 1373 | @@ -140,7 +141,7 @@ | |||
| 1374 | 140 | >>> admin_browser.getLink('Overview').click() | 141 | >>> admin_browser.getLink('Overview').click() |
| 1375 | 141 | >>> print admin_browser.title | 142 | >>> print admin_browser.title |
| 1376 | 142 | Network Applet in Launchpad | 143 | Network Applet in Launchpad |
| 1378 | 143 | >>> admin_browser.getLink('Change details').click() | 144 | >>> admin_browser.getLink('Configure translations').click() |
| 1379 | 144 | >>> admin_browser.getControl( | 145 | >>> admin_browser.getControl( |
| 1380 | 145 | ... 'Translations for this project are done in Launchpad').selected | 146 | ... 'Translations for this project are done in Launchpad').selected |
| 1381 | 146 | False | 147 | False |
| 1382 | 147 | 148 | ||
| 1383 | === modified file 'lib/lp/translations/stories/translationgroups/15-product-translation-group.txt' | |||
| 1384 | --- lib/lp/translations/stories/translationgroups/15-product-translation-group.txt 2009-09-18 15:42:19 +0000 | |||
| 1385 | +++ lib/lp/translations/stories/translationgroups/15-product-translation-group.txt 2010-04-09 18:48:33 +0000 | |||
| 1386 | @@ -10,9 +10,10 @@ | |||
| 1387 | 10 | ... find_tag_by_id(netapplet_owner_browser.contents, 'uses')) | 10 | ... find_tag_by_id(netapplet_owner_browser.contents, 'uses')) |
| 1388 | 11 | Does not use Launchpad for development. | 11 | Does not use Launchpad for development. |
| 1389 | 12 | 12 | ||
| 1391 | 13 | >>> netapplet_owner_browser.getLink('Change details').click() | 13 | >>> netapplet_owner_browser.getLink( |
| 1392 | 14 | ... 'Configure translations').click() | ||
| 1393 | 14 | >>> print netapplet_owner_browser.title | 15 | >>> print netapplet_owner_browser.title |
| 1395 | 15 | Change Network Applet's details... | 16 | Configure Translations : NetApplet |
| 1396 | 16 | 17 | ||
| 1397 | 17 | >>> netapplet_owner_browser.getControl( | 18 | >>> netapplet_owner_browser.getControl( |
| 1398 | 18 | ... 'Translations for this project are done in Launchpad' | 19 | ... 'Translations for this project are done in Launchpad' |
| 1399 | 19 | 20 | ||
| 1400 | === modified file 'lib/lp/translations/stories/translationgroups/46-test-distro-structured-permissions.txt' | |||
| 1401 | --- lib/lp/translations/stories/translationgroups/46-test-distro-structured-permissions.txt 2010-02-16 21:21:14 +0000 | |||
| 1402 | +++ lib/lp/translations/stories/translationgroups/46-test-distro-structured-permissions.txt 2010-04-09 18:48:33 +0000 | |||
| 1403 | @@ -1,7 +1,7 @@ | |||
| 1404 | 1 | First, we state that netapplet is using Launchpad Translations. | 1 | First, we state that netapplet is using Launchpad Translations. |
| 1405 | 2 | 2 | ||
| 1406 | 3 | >>> admin_browser.open('http://launchpad.dev/netapplet') | 3 | >>> admin_browser.open('http://launchpad.dev/netapplet') |
| 1408 | 4 | >>> admin_browser.getLink('Change details').click() | 4 | >>> admin_browser.getLink('Configure translations').click() |
| 1409 | 5 | >>> admin_browser.getControl( | 5 | >>> admin_browser.getControl( |
| 1410 | 6 | ... 'Translations for this project are done in Launchpad' | 6 | ... 'Translations for this project are done in Launchpad' |
| 1411 | 7 | ... ).selected = True | 7 | ... ).selected = True |
| 1412 | 8 | 8 | ||
| 1413 | === modified file 'lib/lp/translations/stories/translations/55-rosetta-potemplates.txt' | |||
| 1414 | --- lib/lp/translations/stories/translations/55-rosetta-potemplates.txt 2009-12-21 17:27:17 +0000 | |||
| 1415 | +++ lib/lp/translations/stories/translations/55-rosetta-potemplates.txt 2010-04-09 18:48:33 +0000 | |||
| 1416 | @@ -47,7 +47,8 @@ | |||
| 1417 | 47 | 47 | ||
| 1418 | 48 | # To check this, we need to state that this project uses Launchpad for | 48 | # To check this, we need to state that this project uses Launchpad for |
| 1419 | 49 | # translations. | 49 | # translations. |
| 1421 | 50 | >>> admin_browser.open('http://launchpad.dev/netapplet/+edit') | 50 | >>> admin_browser.open( |
| 1422 | 51 | ... 'http://launchpad.dev/netapplet/+configure-translations') | ||
| 1423 | 51 | >>> admin_browser.getControl( | 52 | >>> admin_browser.getControl( |
| 1424 | 52 | ... 'Translations for this project are done in Launchpad' | 53 | ... 'Translations for this project are done in Launchpad' |
| 1425 | 53 | ... ).selected = True | 54 | ... ).selected = True |
| 1426 | 54 | 55 | ||
| 1427 | === modified file 'lib/lp/translations/templates/product-portlet-not-using-launchpad.pt' | |||
| 1428 | --- lib/lp/translations/templates/product-portlet-not-using-launchpad.pt 2009-11-01 20:18:32 +0000 | |||
| 1429 | +++ lib/lp/translations/templates/product-portlet-not-using-launchpad.pt 2010-04-09 18:48:33 +0000 | |||
| 1430 | @@ -4,17 +4,20 @@ | |||
| 1431 | 4 | xmlns:i18n="http://xml.zope.org/namespaces/i18n" | 4 | xmlns:i18n="http://xml.zope.org/namespaces/i18n" |
| 1432 | 5 | omit-tag=""> | 5 | omit-tag=""> |
| 1433 | 6 | 6 | ||
| 1436 | 7 | <p id="not-translated-in-launchpad" | 7 | <div id="not-translated-in-launchpad" |
| 1437 | 8 | tal:condition="not: context/official_rosetta"> | 8 | tal:condition="not: context/official_rosetta"> |
| 1438 | 9 | <strong> | 9 | <strong> |
| 1439 | 10 | This project is not using Launchpad for translations. | 10 | This project is not using Launchpad for translations. |
| 1440 | 11 | </strong> | 11 | </strong> |
| 1448 | 12 | <tal:admin_or_owner condition="context/required:launchpad.Edit"> | 12 | <ul> |
| 1449 | 13 | You can change this in the | 13 | <li> |
| 1450 | 14 | <a tal:attributes="href context/fmt:url/+edit"> | 14 | <a tal:replace="structure context/menu:overview/configure_translations/fmt:link"/> |
| 1451 | 15 | project settings</a>. | 15 | </li> |
| 1452 | 16 | </tal:admin_or_owner> | 16 | <li> |
| 1453 | 17 | (<a href="/+help/getting-started-for-your-project.html" target="help">Getting started with translating your project in Launchpad</a>) | 17 | <a href="/+help/getting-started-for-your-project.html" target="help" |
| 1454 | 18 | </p> | 18 | >Getting started with translating your project in Launchpad</a> |
| 1455 | 19 | </li> | ||
| 1456 | 20 | </ul> | ||
| 1457 | 21 | </div> | ||
| 1458 | 19 | 22 | ||
| 1459 | 20 | </tal:root> | 23 | </tal:root> |
Hi Edwin.
I really appreciate your effort to solve this usability issue.
UI/Usability
------------
! As the owner of thunderbird, I saw that the "Report a bug" was disabled. I
used "Configure Launchpad bugs" and choose The Mozilla.org bug tracker and
provided the remove project.
* I still see "Report a bug" (This service needs configuration). This is
wrong. I provided the real information that should satisfy other
contributors. I expect to see the warning disappear.
! As the owner of Firefox and thunderbird, I expect to see a warning that
"Development focus branch has not been specified" which I can see in the
Project information portlet.
* I think this is a case where official_
We know if the project officially uses code if the branch is neither a
mirror or import. I expect the Involvement portlet to tell me that this
is a problem.
* As an anonymous user I should see a warning that the development focus is
missing a branch in the Involvement portlet.
* May be call for action should also be repeated on the series page since
that is the object that is being edited.
! As the user of evolution, a project that has a link to a package with
I expect to see a warning that translation syncing should be setup.
The owner certainly can set official/unofficial usage, but any user
can enable series sync, and should if Ubuntu has translations for it.
* This is a unique case were any user can set this. This information
must be shown on the series overview for any user to act on.
* We may want alternate configuration link or tool tips about the
problem.
* This is case is harder than the others because the official_
attribute is legitimate.
! I think the message for all these services is wrong. We want the user
to tell Launchpad where the service is and maybe configure it if the
service is Launchpad's. In the bug tracker example. we need to know the
bug tracker, and the owner wants to tell every one about the official
tracker; no one is asking users to enable Launchpad Bugs.
* I noticed that as an anonymous user or no-priv that the Involvement portlet
has about 1em extra padding in the bottom. Oh. The markup has an empty
<ul>; this is invalid HTML.
* I Think the "Uses Launchpad for" item in the Project information portlet
may be redundant. We can discuss removing it after we are certain that this
change is all the information needed. I suspect we need to disable answers
and blueprints first since they are effectively on and it is not clear
that the involvement portlet is 100% related to official uses. Of course,
the involvement portlet is not just about official uses anymore either.
* Think the "Development focus branch has not been specified" link in
the Project information portlet may be removable if we solve the Involvement
portlet issues.
* Note to self, we may want to remove official_
Only Ubuntu can use translations. I recall there was a complaint from a
user that we cannot set a distro bug tracker.
I see your configuration for the bug tracker is similar to my branch and I
...