Code review comment for lp:~edwin-grubbs/launchpad/bug-652232-person-code-action-links

Revision history for this message
Guilherme Salgado (salgado) wrote :

Hi Edwin,

This looks good, but although the sidebar is consistent with other pages, the links themselves are not. For instance, the links on bugs.lp.dev/~mark start with a verb to denote the action, as the sidebar used to hold all our action links. My impression is that we're not going to use them for actions anymore, but then I think we should change the link text on the other pages to be consistent with what we have here.

Is there a wiki page or mailing list thread where this standardization has been discussed. That'd help in making sure everybody is on the same page for future work on this front.

review: Approve (ui*)

« Back to merge proposal