Merge lp:~edwin-grubbs/launchpad/bug-652232-person-code-action-links into lp:launchpad
Status: | Merged | ||||
---|---|---|---|---|---|
Approved by: | Graham Binns | ||||
Approved revision: | no longer in the source branch. | ||||
Merged at revision: | 11763 | ||||
Proposed branch: | lp:~edwin-grubbs/launchpad/bug-652232-person-code-action-links | ||||
Merge into: | lp:launchpad | ||||
Diff against target: |
14 lines (+3/-1) 1 file modified
lib/lp/code/browser/branchlisting.py (+3/-1) |
||||
To merge this branch: | bzr merge lp:~edwin-grubbs/launchpad/bug-652232-person-code-action-links | ||||
Related bugs: |
|
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Graham Binns (community) | code | Approve | |
Curtis Hovey (community) | ui | Approve | |
Guilherme Salgado (community) | ui* | Approve | |
Review via email: mp+38574@code.launchpad.net |
Description of the change
Summary
-------
Moved action links for code.lp.
code.lp.
Implementation details
-------
Moved links into the sidebar.
lib/
lib/
Removed #page-summary css, since it's no longer used.
lib/
The person code pages and the person product code pages now share the
same template.
lib/
lib/
lib/
Fixed tests:
lib/
lib/
lib/
Tests
-----
./bin/test -vv -t 'xx-branchmerge
Demo and Q/A
------------
* Open http://
* The links should be in the sidebar, and clicking on the links
should take you to a page with the sidebar, except for the "active
reviews" page.
* If you log in as that user, you should see the "Register a branch"
link.
* Open http://
* The links should be in the sidebar, and clicking on the links
should take you to a page with the sidebar, except for the "active
reviews" page.
* Even if you are logged in as that user, you should never see the
"Register a branch" link, since that page only registers branches
under +junk, so it would be confusing because the list of firefox
branches wouldn't show it.
Hi Edwin,
This looks good, but although the sidebar is consistent with other pages, the links themselves are not. For instance, the links on bugs.lp.dev/~mark start with a verb to denote the action, as the sidebar used to hold all our action links. My impression is that we're not going to use them for actions anymore, but then I think we should change the link text on the other pages to be consistent with what we have here.
Is there a wiki page or mailing list thread where this standardization has been discussed. That'd help in making sure everybody is on the same page for future work on this front.