Code review comment for lp:~edwin-grubbs/launchpad/bug-652232-person-code-action-links

Revision history for this message
Curtis Hovey (sinzui) wrote :

Links to collections and/or collection slices can begin with a count of the items instead of an action. I do not think this rule was documented. See the bugs page for a project for the example. Beuno suggested the rule because 6 links starting with "View" makes the portlet difficult to scan. eg. View active branches is awkward because we expect following a link always leads to viewing a page. The count is more most important because it sets expectations.

I think we should discuss junk. Junk is not in scope, it is not a part of bridging the gap. I deactivate about 5 projects a week because the user did not know about +junk. The user learned about personal branches in the email I sent. The project code page tells me how to pull code from the project, and has a help link to code. I would like a similar message on the person branches page.

    You can push personal branches (branches that are not related to a project) to:
    lp:~sinzui/+junk

We cannot link to +junk because there is not a view registered to show that slice of the branches collection.

review: Needs Information (ui)

« Back to merge proposal