Code review comment for lp:~edwin-grubbs/launchpad/bug-652232-person-code-action-links

Revision history for this message
Guilherme Salgado (salgado) wrote :

On Mon, 2010-10-18 at 16:31 +0000, Curtis Hovey wrote:
> Review: Needs Information ui
> Links to collections and/or collection slices can begin with a count
> of the items instead of an action. I do not think this rule was
> documented. See the bugs page for a project for the example. Beuno
> suggested the rule because 6 links starting with "View" makes the
> portlet difficult to scan. eg. View active branches is awkward because
> we expect following a link always leads to viewing a page. The count
> is more most important because it sets expectations.

That makes sense, but my point was that if this was the preferred style
now, then we should fix the pages that are still using the old one (e.g.
bugs.lp.net/~user). Should we try and file a bug for each of them or
should each team do so once Edwin sends his email clarifying the rules
to everybody?

« Back to merge proposal