Launchpad itself

Code review comment for lp:~gary/launchpad/launchpad-templates-2

  1. launchpad-templates-2
  2. Merge into devel
Revision history for this message
Gary Poster (gary) wrote :

Thank you very much, Edwin.

I made all requested changes, except I reverted the change to root-index. Henning is working on that page, so I shouldn't stomp on his work.

Incremental diff follows.

Gary

=== modified file 'lib/canonical/launchpad/browser/temporaryblobstorage.py'
--- lib/canonical/launchpad/browser/temporaryblobstorage.py 2009-09-17 22:05:48 +0000
+++ lib/canonical/launchpad/browser/temporaryblobstorage.py 2009-09-18 13:18:15 +0000
@@ -18,6 +18,10 @@

 class TemporaryBlobStorageAddView(LaunchpadFormView):
+ # XXX: gary 2009-09-18 bug=31358
+ # This page might be able to be removed after the referenced bug is
+ # fixed and apport (Ubuntu's bug reporting tool) has been changed to use
+ # it.
     schema = ITemporaryBlobStorage
     label = 'Store BLOB'
     page_title = 'Store a BLOB temporarily in Launchpad'

=== modified file 'lib/canonical/launchpad/templates/root-index.pt'
--- lib/canonical/launchpad/templates/root-index.pt 2009-09-17 22:05:48 +0000
+++ lib/canonical/launchpad/templates/root-index.pt 2009-09-18 13:18:31 +0000
@@ -3,7 +3,10 @@
   xmlns:tal="http://xml.zope.org/namespaces/tal"
   xmlns:metal="http://xml.zope.org/namespaces/metal"
   xmlns:i18n="http://xml.zope.org/namespaces/i18n"
- metal:use-macro="view/macro:page/searchless"
+ xml:lang="en"
+ lang="en"
+ dir="ltr"
+ metal:use-macro="view/macro:page/search"
   i18n:domain="launchpad">
   <body>
     <div metal:fill-slot="main">

=== modified file 'lib/canonical/launchpad/zcml/launchpad.zcml'
--- lib/canonical/launchpad/zcml/launchpad.zcml 2009-09-17 22:05:48 +0000
+++ lib/canonical/launchpad/zcml/launchpad.zcml 2009-09-18 13:19:36 +0000
@@ -256,7 +256,7 @@
   <browser:page
       for="canonical.launchpad.webapp.interfaces.ILaunchpadApplication"
       name="+graphics"
- class="canonical.launchpad.browser.LaunchpadGraphics"
+ class="canonical.launchpad.browser.launchpad.LaunchpadGraphics"
       template="../templates/launchpad-graphics.pt"
       permission="zope.Public"
       />

=== modified file 'lib/canonical/launchpad/zcml/launchpadstatistic.zcml'
--- lib/canonical/launchpad/zcml/launchpadstatistic.zcml 2009-09-17 22:05:48 +0000
+++ lib/canonical/launchpad/zcml/launchpadstatistic.zcml 2009-09-18 13:19:14 +0000
@@ -35,7 +35,7 @@
   <browser:pages
     for="canonical.launchpad.interfaces.ILaunchpadStatisticSet"
     facet="overview"
- class="canonical.launchpad.browser.LaunchpadStatisticSet"
+ class="canonical.launchpad.browser.launchpadstatistic.LaunchpadStatisticSet"
     permission="launchpad.Admin">
     <browser:page
       name="+index"

« Back to merge proposal