Thanks for the quick fix. As I pointed out on IRC you missed fixing a few tests.
These need updating:
...me/bac/canonical/lp-branches/reviewer> bzr ls -VR --kind=file --null | xargs -0 grep -In define\ new\ tag
lib/lp/bugs/browser/tests/bug-views.txt:619: Is this a new tag?...<input ...Yes, define new tag...>
lib/lp/bugs/browser/tests/bug-views.txt:632:If we click on the 'Yes, define new tag' button, we'll get redirected to
lib/lp/bugs/stories/bug-tags/xx-tags-on-bug-page.txt:40: >>> user_browser.getControl('Yes, define new tag', index=0).click()
lib/lp/bugs/stories/bug-tags/xx-tags-on-bug-page.txt:109: >>> user_browser.getControl('Yes, define new tag')
lib/lp/bugs/stories/bug-tags/xx-tags-on-bug-page.txt:112: LookupError: label 'Yes, define new tag'
lib/lp/bugs/stories/bugs/xx-bug-activity.txt:176: >>> admin_browser.getControl('Yes, define new tag', index=0).click()
lib/lp/bugs/stories/bugs/xx-bug-activity.txt:191: >>> admin_browser.getControl('Yes, define new tag', index=0).click()
Otherwise it looks really good. Just some rote test fixing and it'll be ready to land.
Hi Jamal,
Thanks for the quick fix. As I pointed out on IRC you missed fixing a few tests.
These need updating:
...me/bac/ canonical/ lp-branches/ reviewer> bzr ls -VR --kind=file --null | xargs -0 grep -In define\ new\ tag bugs/browser/ tests/bug- views.txt: 619: Is this a new tag?...<input ...Yes, define new tag...> bugs/browser/ tests/bug- views.txt: 632:If we click on the 'Yes, define new tag' button, we'll get redirected to bugs/stories/ bug-tags/ xx-tags- on-bug- page.txt: 40: >>> user_browser. getControl( 'Yes, define new tag', index=0).click() bugs/stories/ bug-tags/ xx-tags- on-bug- page.txt: 109: >>> user_browser. getControl( 'Yes, define new tag') bugs/stories/ bug-tags/ xx-tags- on-bug- page.txt: 112: LookupError: label 'Yes, define new tag' bugs/stories/ bugs/xx- bug-activity. txt:176: >>> admin_browser. getControl( 'Yes, define new tag', index=0).click() bugs/stories/ bugs/xx- bug-activity. txt:191: >>> admin_browser. getControl( 'Yes, define new tag', index=0).click()
lib/lp/
lib/lp/
lib/lp/
lib/lp/
lib/lp/
lib/lp/
lib/lp/
Otherwise it looks really good. Just some rote test fixing and it'll be ready to land.