Merge lp:~jamalta/launchpad/newtag-statement-redundancy into lp:launchpad
Proposed by
Jamal Fanaian
Status: | Merged | ||||||||
---|---|---|---|---|---|---|---|---|---|
Approved by: | Brad Crittenden | ||||||||
Approved revision: | not available | ||||||||
Merged at revision: | not available | ||||||||
Proposed branch: | lp:~jamalta/launchpad/newtag-statement-redundancy | ||||||||
Merge into: | lp:launchpad | ||||||||
Diff against target: |
121 lines (+13/-15) 5 files modified
lib/lp/bugs/browser/bug.py (+2/-3) lib/lp/bugs/browser/tests/bug-views.txt (+3/-3) lib/lp/bugs/stories/bug-tags/xx-tags-on-bug-page.txt (+3/-3) lib/lp/bugs/stories/bugs/xx-bug-activity.txt (+2/-2) lib/lp/bugs/stories/bugs/xx-bug-edit.txt (+3/-4) |
||||||||
To merge this branch: | bzr merge lp:~jamalta/launchpad/newtag-statement-redundancy | ||||||||
Related bugs: |
|
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Brad Crittenden (community) | code | Approve | |
Curtis Hovey (community) | ui | Approve | |
Review via email: mp+17670@code.launchpad.net |
Commit message
Changed the confirmation message when defining a new bug tag to 'The tag "[tagname]" hasn't been used by [targetname] before. (Create the new tag)'. to remove redundancy.
To post a comment you must log in.
= Summary =
The message 'The tag "[tagname]" hasn't yet been used by [targetname] before. Is this a new tag?' is redundant and misleading. "Yet" and "before" should not are redundant in the statement. From bug 106924 and bug 87058.
== Proposed fix ==
Replace statement with 'The tag "[tagname]" hasn't been used by [targetname] before. (Create the new tag)'
== Pre-implementation notes ==
Spoke with bac to confirm the language that should be used to fix the issue.
== Tests ==
% bin/test -vvct xx-bug-edit
== Demo and Q/A ==
* https:/ /bugs.launchpad .dev/firefox/ +bug/1/ +edit
Enter "new-tag" as a tag and click Change
== Launchpad lint ==
Checking for conflicts. and issues in doctests and templates.
Running jslint, xmllint, pyflakes, and pylint.
Using normal rules.
Linting changed files: bugs/browser/ bug.py bugs/stories/ bugs/xx- bug-edit. txt
lib/lp/
lib/lp/
== Pylint notices ==
lib/lp/ bugs/browser/ bug.py MIMEMultipart' (No module named MIMEMultipart) .event' (No module named lifecycle) .snapshot' (No module named lifecycle) interfaces' (No module named restful)
28: [F0401] Unable to import 'email.
29: [F0401] Unable to import 'email.MIMEText' (No module named MIMEText)
43: [F0401] Unable to import 'lazr.enum' (No module named enum)
44: [F0401] Unable to import 'lazr.lifecycle
45: [F0401] Unable to import 'lazr.lifecycle
46: [F0401] Unable to import 'lazr.restful.
Confirmed that the lint notices are not related to my branch by gary_poster in #launchpad-dev