Code review comment for lp:~jamalta/launchpad/newtag-statement-redundancy

Revision history for this message
Jamal Fanaian (jamalta) wrote :

Updated tests that referenced changed language.

=== modified file 'lib/lp/bugs/browser/tests/bug-views.txt'
--- lib/lp/bugs/browser/tests/bug-views.txt 2009-12-24 01:41:54 +0000
+++ lib/lp/bugs/browser/tests/bug-views.txt 2010-01-19 21:33:16 +0000
@@ -615,8 +615,8 @@
     False
     >>> for message in bug_edit.view.notifications:
     ... print message
- The tag "new-tag" hasn't yet been used by Mozilla Firefox before.
- Is this a new tag?...<input ...Yes, define new tag...>
+ The tag "new-tag" hasn't been used by Mozilla Firefox before.
+ <input ...Create the new tag...>

     >>> bug_edit.wasRedirected()
     False
@@ -629,7 +629,7 @@
     >>> [action.label for action in bug_edit.view.actions]
     ['Change']

-If we click on the 'Yes, define new tag' button, we'll get redirected to
+If we click on the 'Create the new tag' button, we'll get redirected to
 the bug page, and the bug will have the new tag.

     >>> bug_edit.submit('confirm_tag', edit_values)

=== modified file 'lib/lp/bugs/stories/bug-tags/xx-tags-on-bug-page.txt'
--- lib/lp/bugs/stories/bug-tags/xx-tags-on-bug-page.txt 2009-06-12 16:36:02 +0000
+++ lib/lp/bugs/stories/bug-tags/xx-tags-on-bug-page.txt 2010-01-19 21:33:16 +0000
@@ -37,7 +37,7 @@

     >>> user_browser.url
     'http://bugs.launchpad.dev/firefox/+bug/1/+edit'
- >>> user_browser.getControl('Yes, define new tag', index=0).click()
+ >>> user_browser.getControl('Create the new tag', index=0).click()
     >>> user_browser.url
     'http://bugs.launchpad.dev/firefox/+bug/1'

@@ -106,9 +106,9 @@
     >>> user_browser.open('http://bugs.launchpad.dev/firefox/+bug/1/+edit')
     >>> user_browser.getControl('Tags').value = 'an-official-tag'
     >>> user_browser.getControl('Change').click()
- >>> user_browser.getControl('Yes, define new tag')
+ >>> user_browser.getControl('Create the new tag')
     Traceback (most recent call last):
     ...
- LookupError: label 'Yes, define new tag'
+ LookupError: label 'Create the new tag'
     >>> print user_browser.url
     http://bugs.launchpad.dev/firefox/+bug/1

=== modified file 'lib/lp/bugs/stories/bugs/xx-bug-activity.txt'
--- lib/lp/bugs/stories/bugs/xx-bug-activity.txt 2009-12-16 21:26:57 +0000
+++ lib/lp/bugs/stories/bugs/xx-bug-activity.txt 2010-01-19 21:33:16 +0000
@@ -173,7 +173,7 @@
     ... 'http://bugs.launchpad.dev/redfish/+bug/15/+edit')
     >>> admin_browser.getControl("Tags").value = "tag1 tag2 tag3"
     >>> admin_browser.getControl("Change").click()
- >>> admin_browser.getControl('Yes, define new tag', index=0).click()
+ >>> admin_browser.getControl('Create the new tag', index=0).click()

     >>> admin_browser.open('http://launchpad.dev/bugs/15')
     >>> print_comments(admin_browser.contents)
@@ -188,7 +188,7 @@
     ... 'http://bugs.launchpad.dev/redfish/+bug/15/+edit')
     >>> admin_browser.getControl("Tags").value = "tag1 tag2 tag4"
     >>> admin_browser.getControl("Change").click()
- >>> admin_browser.getControl('Yes, define new tag', index=0).click()
+ >>> admin_browser.getControl('Create the new tag', index=0).click()

     >>> admin_browser.open('http://launchpad.dev/bugs/15')
     >>> print_comments(admin_browser.contents)

« Back to merge proposal