Code review comment for lp:~jameinel/bzr/2.0.5-switch-unicode-317778

This is an attempt to propose the patch on bug #317778 as a merge request.

I think it has a lot of stuff missing (needs tests, some manual testing to make sure we haven't regressed for other cases, etc.)

get_transport() has a fair amount of DWIM code to allow users to specify whatever works the best for them, and I don't think that is also in urlutils.escape(). We use that mostly to allow people to specify a Unicode path, while internally we treat things as URLs. But users may also specify the url on the command line.

Anyway, getting this put up as a Merge Proposal in some form seemed better than leaving it as an abandoned patch.