Code review comment for lp:~jameinel/bzr/2.0.5-switch-unicode-317778

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Martin Pool wrote:
> Review: Needs Fixing
> It looks basically ok.
>
> If there is an existing test we can amend to use a unicode name that would be nice.
>
> It seems like really this should be lifted out of branch itself though.

so the issue is that if Branch.open(to_location) fails, then we fall back to

 urlutils.join(source, '..', to_location)

And at that point 'to_location' is expected to be a URL, but is actually
a Unicode string. This works for pure ascii, but not otherwise.

We could change the 'join' calls to be

urlutils.join(source, '..', DWIM(to_location)) (or just escape it).

I think there are 2 locations, though. also note that we probably want
to change the order of lookup. We set a lightweight location before a
heavyweight one, but we lookup the heavyweight neighbor before the
lightweight one.

John
=:->

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (Cygwin)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iEYEARECAAYFAkt0VX8ACgkQJdeBCYSNAAOgzwCfQl6fMjOFyQYTwCKLpfAq+dif
E6QAn16WSWrgu5kQ3KUSa4HbYs6F3Oye
=9qBD
-----END PGP SIGNATURE-----