Code review comment for lp:~james-w/python-launchpad-bugs/urlerror-reason

Revision history for this message
James Westby (james-w) wrote :

Hi,

This change should make errors more descriptive when we get an
unknown response from Launchpad.

URLError has a subclass, HTTPError, which has a .code attribute, and
is raised most often, but the base class doesn't have this.

The code also checks for this, but doesn't make use of the .reason
attribute on the base class, which is probably more descriptive than
"unknown error".

Thanks,

James

« Back to merge proposal