Code review comment for lp:~jcsackett/launchpad/project-involvement-translations-contradiction-652287

Hi JC,

This is a nice improvement. I just have a couple of comments below.

-Edwin

>Lint:
> ./lib/lp/registry/model/projectgroup.py
> 321: undefined name 'OfficialBugTag'
>
>I'm not sure what's up with the OfficialBugTag issue. It occurs in storm
>query and isn't part of my branch. I'm happy to fix it, if it's
>something that needs fixing, but I wasn't sure of what's expected there.

That method isn't being used yet due to bug 341203. Please add the
import statement so the lint error goes away.

>=== modified file 'lib/lp/registry/interfaces/projectgroup.py'
>--- lib/lp/registry/interfaces/projectgroup.py 2010-09-22 08:48:24 +0000
>+++ lib/lp/registry/interfaces/projectgroup.py 2010-10-06 18:04:51 +0000
>@@ -320,6 +320,10 @@
> It also should have IProduct.official_rosetta flag set.
> """
>
>+ def has_translatables():
>+ """Return a boolean showing the existance of translatables products.

s/translatables/translatable/

>+ """
>+
> def hasProducts():
> """Returns True if a project has products associated with it, False
> otherwise.
>