Code review comment for lp:~lifeless/launchpad/oops

=== modified file 'lib/lp/services/timeline/tests/test_timedaction.py'
--- lib/lp/services/timeline/tests/test_timedaction.py 2010-09-03 01:09:38 +0000
+++ lib/lp/services/timeline/tests/test_timedaction.py 2010-09-05 05:07:57 +0000
@@ -41,8 +41,10 @@
         action.duration = datetime.timedelta(0, 0, 0, 4)
         log_tuple = action.logTuple()
         self.assertEqual(4, len(log_tuple), "!= 4 elements %s" % (log_tuple,))
+ # The first element is the start offset in ms.
         self.assertAlmostEqual(2, log_tuple[0])
- self.assertAlmostEqual(4, log_tuple[1])
+ # The second element is the end offset in ms.
+ self.assertAlmostEqual(6, log_tuple[1])
         self.assertEqual("foo", log_tuple[2])
         self.assertEqual("bar", log_tuple[3])

@@ -56,6 +58,6 @@
         log_tuple = action.logTuple()
         self.assertEqual(4, len(log_tuple), "!= 4 elements %s" % (log_tuple,))
         self.assertAlmostEqual(2, log_tuple[0])
- self.assertAlmostEqual(999999, log_tuple[1])
+ self.assertAlmostEqual(1000001, log_tuple[1])
         self.assertEqual("foo", log_tuple[2])
         self.assertEqual("bar", log_tuple[3])

=== modified file 'lib/lp/services/timeline/timedaction.py'
--- lib/lp/services/timeline/timedaction.py 2010-09-03 01:09:38 +0000
+++ lib/lp/services/timeline/timedaction.py 2010-09-05 05:07:57 +0000
@@ -57,7 +57,7 @@
             length = 999999
         else:
             length = self._td_to_ms(self.duration)
- return (offset, length, self.category, self.detail)
+ return (offset, offset + length, self.category, self.detail)

     def _td_to_ms(self, td):
         """Tweak on a backport from python 2.7"""