Looked at this bug yesterday as well and this change is the same conclusion I'd drawn. Are you considering _setmode redundant as it's an win ftp server bug, or should that be called on this path as well?
Had looked at the ftp tests as well and bar subclassing both the medusa and pyftpdlib paths it didn't seem like this 'd be properly testable so just the fix is okay I think.
Looked at this bug yesterday as well and this change is the same conclusion I'd drawn. Are you considering _setmode redundant as it's an win ftp server bug, or should that be called on this path as well?
Had looked at the ftp tests as well and bar subclassing both the medusa and pyftpdlib paths it didn't seem like this 'd be properly testable so just the fix is okay I think.