Code review comment for lp:~mbp/bzr/224373-2.2-ftp-response

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Martin Pool wrote:
> Martin Pool has proposed merging lp:~mbp/bzr/224373-2.2-ftp-response into lp:bzr/2.2.
>
> Requested reviews:
> bzr-core (bzr-core)
> Related bugs:
> #224373 Bzr ftp support does not handle 250 response from Windows 2003 server for mkdir
> https://bugs.launchpad.net/bugs/224373
>
>
> Here's a workaround for MS FTP server's habit of returning '250' for successful mkd calls.
>
> This is done 'blind' without a test and without testing it against a Microsoft ftp server, just based on the tracebacks and interactively creating an error that looks like them. If someone could actually test this, that would be good.

Seems reasonable to me. Obviously I'd rather this was tested by someone
actually using it.

I'd also like to ask why you targeted 2.2, but not 2.0 or 2.1? Anyway,
in general:

  merge: approve

Though if you know someone that can actually test it, it would be nice
to wait to land until then. (As *I* don't know anyone, and can't do it
myself, I wouldn't block on this.)

John
=:->

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (Cygwin)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iEYEARECAAYFAkxpaGsACgkQJdeBCYSNAAPNGgCdFTEc3mgXD49GTVX06StxS4Ox
U6oAoJ1rocNHchw0GbNZyTZbBhZRXw+w
=Da49
-----END PGP SIGNATURE-----