Code review comment for lp:~michael.nelson/launchpad/494391-ugly-upload-error-message

Revision history for this message
Henning Eggers (henninge) wrote :

Thanks you for your branch.

Please find another way to word the comment on the test, as these should never state the obvious "Test that ...", "Ensure that ..." etc. Simply "Uploads to the wrong pocket are rejected." is enough. Also, I found it's customary not to use docstrings ("""....""") but comments (# ...) here.

review: Approve (code)

« Back to merge proposal