Merge lp:~michael.nelson/launchpad/distro-series-difference-schema into lp:launchpad/db-devel
Status: | Merged | ||||
---|---|---|---|---|---|
Approved by: | Michael Nelson | ||||
Approved revision: | no longer in the source branch. | ||||
Merged at revision: | 9718 | ||||
Proposed branch: | lp:~michael.nelson/launchpad/distro-series-difference-schema | ||||
Merge into: | lp:launchpad/db-devel | ||||
Diff against target: |
82 lines (+42/-3) 3 files modified
database/schema/comments.sql (+16/-3) database/schema/patch-2208-07-0.sql (+24/-0) database/schema/security.cfg (+2/-0) |
||||
To merge this branch: | bzr merge lp:~michael.nelson/launchpad/distro-series-difference-schema | ||||
Related bugs: |
|
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Brad Crittenden (community) | code | Approve | |
Stuart Bishop (community) | db | Approve | |
Robert Collins | db | Pending | |
Review via email: mp+33515@code.launchpad.net |
Commit message
Add DistroSeriesDif
Description of the change
Overview
=======
This branch is a schema patch to support displaying packages with different versions between two distroseries (specifically, a derived distroseries and its parent series).
Details of the UI at:
https:/
Details
=====
Some details regarding the implementation and schema design were discussed on a long-ish email thread:
https:/
The decisions that came out of that discussion were:
1) Lets just store the derived series which references its parent series (rather than generalising it with two references to distroseries - we can always generalise later if and when we need to).
2) Store the source_
3) The actual diff off the two packages is not required (nullable), and will be generated on request. Also, once its created, its not necessarily a diff of the current packages (new versions could be uploaded since the diff was generated). Hence naming it latest_package_diff rather than simply package_diff.
4) The activity_log field was initially a comment field, but it will be used and appended to (1) by scripts, when new uploads are detected that change the state, or (2) when users add comments (eg. "We're waiting for version 1.4"), hence renaming it activity_log. I don't see a reason to add a separate comment model - but you might.
5) Initially we had just one enum for the type of difference (UNIQUE_
No sampledata changes.
The following branch adds the basic model code:
https:/
Its surprising you don't want delete permissions. How does the derived distribution sync its changes up with its parent distribution?
Having a column called derived_series is confusing. The derived distro series is the child. Having it reference its parent via a column called derived_series seems wrong (The derived distro series is derived from the derived distro series, which is silly). What is the parent distribution of a derived distribution called anyway? Parent or is there some other term?
We should add an index on last_package_diff for garbage collection purposes.
patch-2208-07-0.sql