Code review comment for lp:~michael.nelson/launchpad/distro-series-difference-schema

Hi Robert,

Yes, those versions are stored with the PackageDiff object itself, but do you mean that we should store the exact versions additionally with this DistroSeriesDifference? We were doing that originally, but I'd switched to store simply the source package name as a view displaying these records would need to check and update them anyway, so it I thought it saner to have properties on the model that lookup the latest published version (cheap when we already know *which* packages have differences). Here's the email msg where I brought this up:

https://lists.launchpad.net/launchpad-dev/msg04454.html

And yep, I was using 'latest' in the sense that it is the most recently generated package diff, and irrespective of the above, we could rename this simply to package_diff and automatically remove it when it no longer matches the current published versions - I'd not thought of that.

I'll update latest_package_diff -> package_diff, but let me know about the first issue (storing of exact versions within DistroSeriesDifference in addition to PackageDiff).

Cheers,
M.