Launchpad itself

Code review comment for lp:~michael.nelson/launchpad/distro-series-difference-schema

  1. distro-series-difference-schema
  2. Merge into db-devel
Revision history for this message
Michael Nelson (michael.nelson) wrote :

On Mon, Aug 30, 2010 at 9:41 AM, Stuart Bishop
<email address hidden> wrote:
> Drop the UNIQUE (distro_series_difference, message) constraint, and declare the message column UNIQUE instead.
>
> Drop the index on the message column - one will get created implicitly when the column is declared UNIQUE.

Thanks Stuart. Done in the incremental (as well as renaming
last_package_diff->package_diff).

changes_9692.diff
1=== modified file 'database/schema/comments.sql'
2--- database/schema/comments.sql 2010-08-27 10:59:56 +0000
3+++ database/schema/comments.sql 2010-08-30 07:48:22 +0000
4@@ -507,7 +507,7 @@
5 COMMENT ON TABLE DistroSeriesDifference IS 'A difference of versions for a package in a derived distroseries and its parent distroseries.';
6 COMMENT ON COLUMN DistroSeriesDifference.derived_series IS 'The derived distroseries with the difference from its parent.';
7 COMMENT ON COLUMN DistroSeriesDifference.source_package_name IS 'The name of the source package which is different in the two series.';
8-COMMENT ON COLUMN DistroSeriesDifference.last_package_diff IS 'The most recent package diff that was created for this difference.';
9+COMMENT ON COLUMN DistroSeriesDifference.package_diff IS 'The most recent package diff that was created for this difference.';
10 COMMENT ON COLUMN DistroSeriesDifference.status IS 'A distroseries difference can be needing attention, ignored or resolved.';
11 COMMENT ON COLUMN DistroSeriesDifference.difference_type IS 'The type of difference that this record represents - a package unique to the derived series, or missing, or in both.';
12
13
14=== modified file 'database/schema/patch-2208-07-0.sql'
15--- database/schema/patch-2208-07-0.sql 2010-08-27 10:59:56 +0000
16+++ database/schema/patch-2208-07-0.sql 2010-08-30 07:49:48 +0000
17@@ -4,7 +4,7 @@
18 id serial PRIMARY KEY,
19 derived_series integer NOT NULL CONSTRAINT distroseriesdifference__derived_series__fk REFERENCES distroseries,
20 source_package_name integer NOT NULL CONSTRAINT distroseriesdifference__source_package_name__fk REFERENCES sourcepackagename,
21- last_package_diff integer CONSTRAINT distroseriesdifference__last_package_diff__fk REFERENCES packagediff,
22+ package_diff integer CONSTRAINT distroseriesdifference__package_diff__fk REFERENCES packagediff,
23 status integer NOT NULL,
24 difference_type integer NOT NULL
25 );
26@@ -12,15 +12,13 @@
27 CREATE INDEX distroseriesdifference__source_package_name__idx ON distroseriesdifference(source_package_name);
28 CREATE INDEX distroseriesdifference__status__idx ON distroseriesdifference(status);
29 CREATE INDEX distroseriesdifference__difference_type__idx ON distroseriesdifference(difference_type);
30-CREATE INDEX distroseriesdifference__last_package_diff__idx ON distroseriesdifference(last_package_diff);
31+CREATE INDEX distroseriesdifference__package_diff__idx ON distroseriesdifference(package_diff);
32
33 CREATE TABLE DistroSeriesDifferenceMessage(
34 id serial PRIMARY KEY,
35 distro_series_difference integer NOT NULL CONSTRAINT distroseriesdifferencemessage__distro_series_difference__fk REFERENCES distroseriesdifference,
36- message integer NOT NULL CONSTRAINT distroseriesdifferencemessage__message__fk REFERENCES message,
37- UNIQUE (distro_series_difference, message)
38+ message integer NOT NULL CONSTRAINT distroseriesdifferencemessage__message__fk REFERENCES message UNIQUE
39 );
40 CREATE INDEX distroseriesdifferencemessage__distroseriesdifference__idx ON distroseriesdifferencemessage(distro_series_difference);
41-CREATE INDEX distroseriesdifferencemessage__message__idx ON distroseriesdifferencemessage(message);
42
43 INSERT INTO LaunchpadDatabaseRevision VALUES (2208, 07, 0);

« Back to merge proposal