Code review comment for lp:~mterry/appmenu-gtk/cancellable-register-window

Revision history for this message
Michael Terry (mterry) wrote :

A quick comment about this branch: it fixed the bug for the reporter, though that user then experienced a different crash that he has not been able to reproduce. So this should get a thorough lookover.

Logic seems sound to me though. Basically, the callback for RegisterWindow needs to be cancelled on dispose.

« Back to merge proposal