Merge lp:~mwhudson/launchpad/puller-proxy-argh into lp:launchpad/db-devel
Proposed by
Michael Hudson-Doyle
Status: | Merged |
---|---|
Approved by: | Brad Crittenden |
Approved revision: | no longer in the source branch. |
Merged at revision: | not available |
Proposed branch: | lp:~mwhudson/launchpad/puller-proxy-argh |
Merge into: | lp:launchpad/db-devel |
Diff against target: |
20 lines 1 file modified
scripts/mirror-branch.py (+3/-0) |
To merge this branch: | bzr merge lp:~mwhudson/launchpad/puller-proxy-argh |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Brad Crittenden (community) | release-critical | Approve | |
Tim Penhey (community) | Approve | ||
Review via email: mp+12327@code.launchpad.net |
To post a comment you must log in.
Hi,
Literally a few minutes before rollout I realized that we had a problem with the puller: pulling MIRRORED branches must have $http_proxy set, but pulling IMPORTED branches must not. This was previously handled by setting or not the environment variable in the crontab but now we only have one crontab entry for pulling all branches so this won't work. The option I went for is a hack in the mirror-branch.py script. It's been working on production so far, so let's make sure a re-rollout doesn't obliterate it :)
Cheers,
mwh