Code review comment for lp:~mwhudson/launchpad/puller-proxy-argh

On Thu, 24 Sep 2009 17:05:23 Michael Hudson wrote:
> Michael Hudson has proposed merging
> lp:~mwhudson/launchpad/puller-proxy-argh into lp:launchpad.
>
> Requested reviews:
> Canonical Launchpad Engineering (launchpad)
>
>
> Hi,
>
> Literally a few minutes before rollout I realized that we had a problem
> with the puller: pulling MIRRORED branches must have $http_proxy set, but
> pulling IMPORTED branches must not. This was previously handled by
> setting or not the environment variable in the crontab but now we only
> have one crontab entry for pulling all branches so this won't work. The
> option I went for is a hack in the mirror-branch.py script. It's been
> working on production so far, so let's make sure a re-rollout doesn't
> obliterate it :)
>
>
> Cheers,
> mwh
>

Looks reasonable :-)

  merge approved