Code review comment for lp:~mwhudson/launchpad/puller-proxy-argh
Revision history for this message
| Michael Hudson-Doyle (mwhudson) wrote | # |
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
0e1f616
(Get the code!)
Hi,
Literally a few minutes before rollout I realized that we had a problem with the puller: pulling MIRRORED branches must have $http_proxy set, but pulling IMPORTED branches must not. This was previously handled by setting or not the environment variable in the crontab but now we only have one crontab entry for pulling all branches so this won't work. The option I went for is a hack in the mirror-branch.py script. It's been working on production so far, so let's make sure a re-rollout doesn't obliterate it :)
Cheers,
mwh