Code review comment for lp:~rockstar/launchpad/recipe-security

Sorry - local email fail, so retrying here using the web UI.

The places where you transaction.commit() all make sense to me, right after you create SourcePackageRecipes. They don't all appear to be necessary though (tests still pass after I remove them), presumably because we do commits in other places (that we shouldn't rely on) as well?

Another thought; would it perhaps be possible to use Store.of().flush() rather than transaction.commit()? It seems to work in at least some of the cases.