Launchpad itself

Merge lp:~sinzui/launchpad/latest-release-portlet-bug-424893 into lp:launchpad

  1. latest-release-portlet-bug-424893
  2. Merge into devel
Proposed by Curtis Hovey
Status: Merged
Approved by: Barry Warsaw
Approved revision: no longer in the source branch.
Merged at revision: not available
Proposed branch: lp:~sinzui/launchpad/latest-release-portlet-bug-424893
Merge into: lp:launchpad
Diff against target: 83 lines (+9/-25)
2 files modified
lib/lp/registry/stories/distribution/xx-distribution-packages.txt (+2/-8)
lib/lp/registry/templates/distributionsourcepackage-index.pt (+7/-17)
To merge this branch: bzr merge lp:~sinzui/launchpad/latest-release-portlet-bug-424893
Reviewer Review Type Date Requested Status
Barry Warsaw (community) code Approve
Review via email: mp+14565@code.launchpad.net
To post a comment you must log in.
Revision history for this message
Curtis Hovey (sinzui) wrote :

This is my branch to remove the latest release portlet from the dsp index.

    lp:~sinzui/launchpad/latest-release-portlet-bug-424893
    Diff size: 54
    Launchpad bug: https://bugs.launchpad.net/bugs/424893
    Test command: ./bin/test -vvt "xx-distribution-packages"
    Pre-implementation: geser (Michael Bienia).
    Target release: 3.1.11

= Remove the latest release portlet from the dsp index =

https://edge.launchpad.net/ubuntu/+source/mysql-dfsg-5.1
This page says "Uploaded by Dave Walker" ... however, the .dsc file
disagrees with this, and says that it's uploaded by Mario Limonciello
...
As seen on https://edge.launchpad.net/ubuntu/+source/kde4libs the "Latest
release" doesn't list the latest version in the development version but
instead the most recent upload to any pocket (here jaunty-backports) making
this portlet even more useless.

Summary: We know the portlet is wrong because the content inline contradicts
it. The packages for a DSP happen in paralell series, as the page shows; the
portlet can never be 100% right.

== Rules ==

    * Remove the portlet since the correct information is inline.

== QA ==

    * Visit https://edge.launchpad.net/ubuntu/+source/kde4libs
    * Verify that there is no latest release port among the side portlets.

== Lint ==

Linting changed files:
  lib/lp/registry/stories/distribution/xx-distribution-packages.txt
  lib/lp/registry/templates/distributionsourcepackage-index.pt

== Test ==

Describe test additions, changes, and even tests that must run unchanged.

    * lib/lp/registry/stories/distribution/xx-distribution-packages.txt
      * Deleted the test for the portlet

== Implementation ==

    * lib/lp/registry/templates/distributionsourcepackage-index.pt
      * Deleted the inlined portlet.

Revision history for this message
Barry Warsaw (barry) wrote :

Looks good, thanks for cleaning this up.

review: Approve (code)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'lib/lp/registry/stories/distribution/xx-distribution-packages.txt'
2--- lib/lp/registry/stories/distribution/xx-distribution-packages.txt 2009-11-07 00:16:01 +0000
3+++ lib/lp/registry/stories/distribution/xx-distribution-packages.txt 2009-11-07 22:29:12 +0000
4@@ -268,6 +268,7 @@
5 Urgency:* Low Urgency
6 Component:* main
7 Architectures:* any
8+ Latest upload: 1.0
9 *actual publishing details may vary in this distribution, these are just the package defaults.
10
11 And if the source has direct packaging linkage, the upstream's description
12@@ -304,7 +305,7 @@
13 -------------------------------------
14
15 The page has a side-bar with a global actions menu, a "Get Involved"
16-menu, a "Latest release" portlet and a "Bug subscriptions" portlet.
17+menu, and a "Bug subscriptions" portlet.
18
19 >>> print extract_text(
20 ... find_tag_by_id(user_browser.contents, 'global-actions'))
21@@ -319,13 +320,6 @@
22 Ask a question
23
24 >>> print extract_text(
25- ... find_tag_by_id(user_browser.contents, 'latest-release'))
26- Latest release
27- Version: 1.0
28- Uploaded by: Mark Shuttleworth
29- On date: ...
30-
31- >>> print extract_text(
32 ... find_tag_by_id(user_browser.contents,
33 ... 'portlet-structural-subscribers'))
34 Bug subscriptions
35
36=== modified file 'lib/lp/registry/templates/distributionsourcepackage-index.pt'
37--- lib/lp/registry/templates/distributionsourcepackage-index.pt 2009-11-07 00:16:01 +0000
38+++ lib/lp/registry/templates/distributionsourcepackage-index.pt 2009-11-07 22:29:12 +0000
39@@ -23,22 +23,6 @@
40
41 <tal:involved replace="structure context/@@+get-involved" />
42
43- <tal:current define="current context/currentrelease">
44- <div class="portlet" id="latest-release" tal:condition="current">
45- <h2>Latest release</h2>
46- <dl>
47- <dt>Version:</dt>
48- <dd><a tal:content="current/version"
49- tal:attributes="href current/fmt:url">3.2.1-3</a>
50- </dd>
51- <dt>Uploaded by:</dt>
52- <dd><a tal:replace="structure current/creator/fmt:link">Foo Bar</a></dd>
53- <dt>On date:</dt>
54- <dd tal:content="current/dateuploaded/fmt:datetime"/>
55- </dl>
56- </div>
57- </tal:current>
58-
59 <tal:subscribers
60 replace="structure context/@@+portlet-structural-subscribers"/>
61 </tal:side>
62@@ -92,7 +76,7 @@
63 <dt>Urgency:<sup>*</sup></dt>
64 <dd tal:content="current/urgency/title"/>
65 </dl>
66- <dl>
67+ <dl style="clear:both">
68 <dt>Component:<sup>*</sup></dt>
69 <dd tal:content="current/component/name"/>
70 </dl>
71@@ -100,6 +84,12 @@
72 <dt>Architectures:<sup>*</sup></dt>
73 <dd tal:content="current/architecturehintlist"/>
74 </dl>
75+ <dl style="clear:both">
76+ <dt>Latest upload:</dt>
77+ <dd><a tal:content="current/version"
78+ tal:attributes="href current/fmt:url">3.2.1-3</a>
79+ </dd>
80+ </dl>
81 </div>
82 <p style="font-size: 80%;">
83 <sup>*</sup>actual publishing details may vary in this distribution, these are just the package defaults.